9 use Test::More tests => 49;
18 use Koha::DateUtils qw( dt_from_string output_pref );
22 use lib $FindBin::Bin;
23 use_ok('C4::Reserves');
26 my $dbh = C4::Context->dbh;
29 $dbh->{AutoCommit} = 0;
30 $dbh->{RaiseError} = 1;
32 my $borrowers_count = 5;
34 $dbh->do('DELETE FROM itemtypes');
35 $dbh->do('DELETE FROM reserves');
36 my $insert_sth = $dbh->prepare('INSERT INTO itemtypes (itemtype) VALUES (?)');
37 $insert_sth->execute('CAN');
38 $insert_sth->execute('CANNOT');
39 $insert_sth->execute('DUMMY');
41 # Setup Test------------------------
42 # Create a biblio instance for testing
43 my ($bibnum, $title, $bibitemnum) = create_helper_biblio('DUMMY');
45 # Create item instance for testing.
46 my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
48 # Create some borrowers
50 foreach (1..$borrowers_count) {
51 my $borrowernumber = AddMember(
52 firstname => 'my firstname',
53 surname => 'my surname ' . $_,
57 push @borrowernumbers, $borrowernumber;
60 my $biblionumber = $bibnum;
62 my @branches = GetBranchesLoop();
63 my $branch = $branches[0][0]{value};
65 # Create five item level holds
66 foreach my $borrowernumber ( @borrowernumbers ) {
77 my $checkitem = $itemnumber,
83 my $reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber });
84 is( scalar(@$reserves), $borrowers_count, "Test GetReserves()" );
87 my ( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
88 is( $reservedate, output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }), "GetReservesFromItemnumber should return a valid reserve date");
89 is( $borrowernumber, $borrowernumbers[0], "GetReservesFromItemnumber should return a valid borrowernumber");
90 is( $branchcode, 'CPL', "GetReservesFromItemnumber should return a valid branchcode");
91 ok($reserve_id, "Test GetReservesFromItemnumber()");
93 my $hold = Koha::Holds->find( $reserve_id );
94 ok( $hold, "Koha::Holds found the hold" );
95 my $hold_biblio = $hold->biblio();
96 ok( $hold_biblio, "Got biblio using biblio() method" );
97 ok( $hold_biblio == $hold->biblio(), "biblio method returns stashed biblio" );
98 my $hold_item = $hold->item();
99 ok( $hold_item, "Got item using item() method" );
100 ok( $hold_item == $hold->item(), "item method returns stashed item" );
101 my $hold_branch = $hold->branch();
102 ok( $hold_branch, "Got branch using branch() method" );
103 ok( $hold_branch == $hold->branch(), "branch method returns stashed branch" );
104 my $hold_found = $hold->found();
105 $hold->set({ found => 'W'})->store();
106 is( Koha::Holds->waiting()->count(), 1, "Koha::Holds->waiting returns waiting holds" );
108 my ( $reserve ) = GetReservesFromBorrowernumber($borrowernumbers[0]);
109 ok( $reserve->{'borrowernumber'} eq $borrowernumbers[0], "Test GetReservesFromBorrowernumber()");
112 ok( GetReserveCount( $borrowernumbers[0] ), "Test GetReserveCount()" );
115 CancelReserve({ 'reserve_id' => $reserve_id });
116 $reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber });
117 is( scalar(@$reserves), $borrowers_count - 1, "Test CancelReserve()" );
120 ( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
122 reserve_id => $reserve_id,
124 branchcode => $branch,
125 itemnumber => $itemnumber,
126 suspend_until => C4::Dates->new("2013-01-01","iso")->output(),
128 $reserve = GetReserve( $reserve_id );
129 ok( $reserve->{'priority'} eq '4', "Test GetReserve(), priority changed correctly" );
130 ok( $reserve->{'suspend'}, "Test GetReserve(), suspend hold" );
131 ok( $reserve->{'suspend_until'} eq '2013-01-01 00:00:00', "Test GetReserve(), suspend until date" );
133 ToggleSuspend( $reserve_id );
134 $reserve = GetReserve( $reserve_id );
135 ok( !$reserve->{'suspend'}, "Test ToggleSuspend(), no date" );
137 ToggleSuspend( $reserve_id, '2012-01-01' );
138 $reserve = GetReserve( $reserve_id );
139 ok( $reserve->{'suspend_until'} eq '2012-01-01 00:00:00', "Test ToggleSuspend(), with date" );
141 AutoUnsuspendReserves();
142 $reserve = GetReserve( $reserve_id );
143 ok( !$reserve->{'suspend'}, "Test AutoUnsuspendReserves()" );
145 # Add a new hold for the borrower whose hold we canceled earlier, this time at the bib level
159 ( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
160 my $reserveid = C4::Reserves::GetReserveId(
162 biblionumber => $biblionumber,
163 borrowernumber => $borrowernumber
166 is( $reserveid, $reserve->{reserve_id}, "Test GetReserveId" );
167 ModReserveMinusPriority( $itemnumber, $reserve->{'reserve_id'} );
168 ( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
169 ok( $reserve->{'itemnumber'} eq $itemnumber, "Test ModReserveMinusPriority()" );
172 my $reserve2 = GetReserveInfo( $reserve->{'reserve_id'} );
173 ok( $reserve->{'reserve_id'} eq $reserve2->{'reserve_id'}, "Test GetReserveInfo()" );
176 $reserves = GetReservesFromBiblionumber({ biblionumber => $biblionumber, all_dates => 1 });
177 $reserve = $reserves->[1];
178 AlterPriority( 'top', $reserve->{'reserve_id'} );
179 $reserve = GetReserve( $reserve->{'reserve_id'} );
180 ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move to top" );
182 AlterPriority( 'down', $reserve->{'reserve_id'} );
183 $reserve = GetReserve( $reserve->{'reserve_id'} );
184 ok( $reserve->{'priority'} eq '2', "Test AlterPriority(), move down" );
186 AlterPriority( 'up', $reserve->{'reserve_id'} );
187 $reserve = GetReserve( $reserve->{'reserve_id'} );
188 ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move up" );
190 AlterPriority( 'bottom', $reserve->{'reserve_id'} );
191 $reserve = GetReserve( $reserve->{'reserve_id'} );
192 ok( $reserve->{'priority'} eq '5', "Test AlterPriority(), move to bottom" );
194 # Regression test for bug 2394
196 # If IndependentBranches is ON and canreservefromotherbranches is OFF,
197 # a patron is not permittedo to request an item whose homebranch (i.e.,
198 # owner of the item) is different from the patron's own library.
199 # However, if canreservefromotherbranches is turned ON, the patron can
200 # create such hold requests.
202 # Note that canreservefromotherbranches has no effect if
203 # IndependentBranches is OFF.
205 my ($foreign_bibnum, $foreign_title, $foreign_bibitemnum) = create_helper_biblio('DUMMY');
206 my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber)
207 = AddItem({ homebranch => 'MPL', holdingbranch => 'MPL' } , $foreign_bibnum);
208 $dbh->do('DELETE FROM issuingrules');
210 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
211 VALUES (?, ?, ?, ?)},
216 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
217 VALUES (?, ?, ?, ?)},
219 '*', '*', 'CANNOT', 0
222 # make sure some basic sysprefs are set
223 t::lib::Mocks::mock_preference('ReservesControlBranch', 'homebranch');
224 t::lib::Mocks::mock_preference('item-level_itypes', 1);
226 # if IndependentBranches is OFF, a CPL patron can reserve an MPL item
227 t::lib::Mocks::mock_preference('IndependentBranches', 0);
229 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'OK',
230 'CPL patron allowed to reserve MPL item with IndependentBranches OFF (bug 2394)'
233 # if IndependentBranches is OFF, a CPL patron cannot reserve an MPL item
234 t::lib::Mocks::mock_preference('IndependentBranches', 1);
235 t::lib::Mocks::mock_preference('canreservefromotherbranches', 0);
237 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'cannotReserveFromOtherBranches',
238 'CPL patron NOT allowed to reserve MPL item with IndependentBranches ON ... (bug 2394)'
241 # ... unless canreservefromotherbranches is ON
242 t::lib::Mocks::mock_preference('canreservefromotherbranches', 1);
244 CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'OK',
245 '... unless canreservefromotherbranches is ON (bug 2394)'
248 # Regression test for bug 11336
249 ($bibnum, $title, $bibitemnum) = create_helper_biblio('DUMMY');
250 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
259 my $reserveid1 = C4::Reserves::GetReserveId(
261 biblionumber => $bibnum,
262 borrowernumber => $borrowernumbers[0]
266 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
274 my $reserveid2 = C4::Reserves::GetReserveId(
276 biblionumber => $bibnum,
277 borrowernumber => $borrowernumbers[1]
281 CancelReserve({ reserve_id => $reserveid1 });
283 $reserve2 = GetReserve( $reserveid2 );
284 is( $reserve2->{priority}, 1, "After cancelreserve, the 2nd reserve becomes the first on the waiting list" );
286 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
294 my $reserveid3 = C4::Reserves::GetReserveId(
296 biblionumber => $bibnum,
297 borrowernumber => $borrowernumbers[0]
301 my $reserve3 = GetReserve( $reserveid3 );
302 is( $reserve3->{priority}, 2, "New reserve for patron 0, the reserve has a priority = 2" );
304 ModReserve({ reserve_id => $reserveid2, rank => 'del' });
305 $reserve3 = GetReserve( $reserveid3 );
306 is( $reserve3->{priority}, 1, "After ModReserve, the 3rd reserve becomes the first on the waiting list" );
308 ModItem({ damaged => 1 }, $item_bibnum, $itemnumber);
309 C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 1 );
310 ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'OK', "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" );
311 ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" );
312 C4::Context->set_preference( 'AllowHoldsOnDamagedItems', 0 );
313 ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'damaged', "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" );
314 ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
316 # Regression test for bug 9532
317 ($bibnum, $title, $bibitemnum) = create_helper_biblio('CANNOT');
318 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL', itype => 'CANNOT' } , $bibnum);
327 CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'tooManyReserves',
328 "cannot request item if policy that matches on item-level item type forbids it"
330 ModItem({ itype => 'CAN' }, $item_bibnum, $itemnumber);
332 CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'OK',
333 "can request item if policy that matches on item type allows it"
336 t::lib::Mocks::mock_preference('item-level_itypes', 0);
337 ModItem({ itype => undef }, $item_bibnum, $itemnumber);
339 CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'tooManyReserves',
340 "cannot request item if policy that matches on bib-level item type forbids it (bug 9532)"
344 # Test branch item rules
346 $dbh->do('DELETE FROM issuingrules');
348 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
349 VALUES (?, ?, ?, ?)},
353 $dbh->do('DELETE FROM branch_item_rules');
354 $dbh->do('DELETE FROM default_branch_circ_rules');
355 $dbh->do('DELETE FROM default_branch_item_rules');
356 $dbh->do('DELETE FROM default_circ_rules');
358 INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch)
360 }, {}, 'CPL', 'CANNOT', 0, 'homebranch');
362 INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch)
364 }, {}, 'CPL', 'CAN', 1, 'homebranch');
365 ($bibnum, $title, $bibitemnum) = create_helper_biblio('CANNOT');
366 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
367 { homebranch => 'CPL', holdingbranch => 'CPL', itype => 'CANNOT' } , $bibnum);
368 is(CanItemBeReserved($borrowernumbers[0], $itemnumber), 'notReservable',
369 "CanItemBeReserved should returns 'notReservable'");
371 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
372 { homebranch => 'MPL', holdingbranch => 'CPL', itype => 'CAN' } , $bibnum);
373 is(CanItemBeReserved($borrowernumbers[0], $itemnumber),
374 'cannotReserveFromOtherBranches',
375 "CanItemBeReserved should returns 'cannotReserveFromOtherBranches'");
377 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
378 { homebranch => 'CPL', holdingbranch => 'CPL', itype => 'CAN' } , $bibnum);
379 is(CanItemBeReserved($borrowernumbers[0], $itemnumber), 'OK',
380 "CanItemBeReserved should returns 'OK'");
383 # Test CancelExpiredReserves
384 C4::Context->set_preference('ExpireReservesMaxPickUpDelay', 1);
385 C4::Context->set_preference('ReservesMaxPickUpDelay', 1);
387 my ( $sec, $min, $hour, $mday, $mon, $year, $wday, $yday, $isdst ) = localtime(time);
390 $reserves = $dbh->selectall_arrayref('SELECT * FROM reserves', { Slice => {} });
391 $reserve = $reserves->[0];
392 my $calendar = C4::Calendar->new(branchcode => $reserve->{branchcode});
393 $calendar->insert_single_holiday(
398 description => 'Test',
400 $reserve_id = $reserve->{reserve_id};
401 $dbh->do("UPDATE reserves SET waitingdate = DATE_SUB( NOW(), INTERVAL 5 DAY ), found = 'W', priority = 0 WHERE reserve_id = ?", undef, $reserve_id );
402 C4::Context->set_preference('ExpireReservesOnHolidays', 0);
403 CancelExpiredReserves();
404 my $count = $dbh->selectrow_array("SELECT COUNT(*) FROM reserves WHERE reserve_id = ?", undef, $reserve_id );
405 is( $count, 1, "Waiting reserve beyond max pickup delay *not* canceled on holiday" );
406 C4::Context->set_preference('ExpireReservesOnHolidays', 1);
407 CancelExpiredReserves();
408 $count = $dbh->selectrow_array("SELECT COUNT(*) FROM reserves WHERE reserve_id = ?", undef, $reserve_id );
409 is( $count, 0, "Waiting reserve beyond max pickup delay canceled on holiday" );
411 # Test expirationdate
412 $reserve = $reserves->[1];
413 $reserve_id = $reserve->{reserve_id};
414 $dbh->do("UPDATE reserves SET expirationdate = DATE_SUB( NOW(), INTERVAL 1 DAY ) WHERE reserve_id = ?", undef, $reserve_id );
415 CancelExpiredReserves();
416 $count = $dbh->selectrow_array("SELECT COUNT(*) FROM reserves WHERE reserve_id = ?", undef, $reserve_id );
417 is( $count, 0, "Reserve with manual expiration date canceled correctly" );
419 # Helper method to set up a Biblio.
420 sub create_helper_biblio {
421 my $itemtype = shift;
422 my $bib = MARC::Record->new();
423 my $title = 'Silence in the library';
425 MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
426 MARC::Field->new('245', ' ', ' ', a => $title),
427 MARC::Field->new('942', ' ', ' ', c => $itemtype),
429 return ($bibnum, $title, $bibitemnum) = AddBiblio($bib, '');