projects
/
powerpc.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Pull bugfix into test branch
[powerpc.git]
/
drivers
/
input
/
keyboard
/
newtonkbd.c
diff --git
a/drivers/input/keyboard/newtonkbd.c
b/drivers/input/keyboard/newtonkbd.c
index
9282e4e
..
aa29b50
100644
(file)
--- a/
drivers/input/keyboard/newtonkbd.c
+++ b/
drivers/input/keyboard/newtonkbd.c
@@
-91,7
+91,7
@@
static int nkbd_connect(struct serio *serio, struct serio_driver *drv)
nkbd = kzalloc(sizeof(struct nkbd), GFP_KERNEL);
input_dev = input_allocate_device();
if (!nkbd || !input_dev)
nkbd = kzalloc(sizeof(struct nkbd), GFP_KERNEL);
input_dev = input_allocate_device();
if (!nkbd || !input_dev)
- goto fail;
+ goto fail
1
;
nkbd->serio = serio;
nkbd->dev = input_dev;
nkbd->serio = serio;
nkbd->dev = input_dev;
@@
-119,13
+119,17
@@
static int nkbd_connect(struct serio *serio, struct serio_driver *drv)
err = serio_open(serio, drv);
if (err)
err = serio_open(serio, drv);
if (err)
- goto fail;
+ goto fail2;
+
+ err = input_register_device(nkbd->dev);
+ if (err)
+ goto fail3;
- input_register_device(nkbd->dev);
return 0;
return 0;
- fail: serio_set_drvdata(serio, NULL);
- input_free_device(input_dev);
+ fail3: serio_close(serio);
+ fail2: serio_set_drvdata(serio, NULL);
+ fail1: input_free_device(input_dev);
kfree(nkbd);
return err;
}
kfree(nkbd);
return err;
}
@@
-165,8
+169,7
@@
static struct serio_driver nkbd_drv = {
static int __init nkbd_init(void)
{
static int __init nkbd_init(void)
{
- serio_register_driver(&nkbd_drv);
- return 0;
+ return serio_register_driver(&nkbd_drv);
}
static void __exit nkbd_exit(void)
}
static void __exit nkbd_exit(void)