Issue 508

[zxing.git] / core / src / com / google / zxing / common / ECI.java

diff --git a/core/src/com/google/zxing/common/ECI.java b/core/src/com/google/zxing/common/ECI.java
index 8a6f446..9d725db 100644 (file)
--- a/core/src/com/google/zxing/common/ECI.java
+++ b/core/src/com/google/zxing/common/ECI.java
@@ -17,8 +17,8 @@
 package com.google.zxing.common;
 
 /**
- * Superclass of classes encapsulating types ECIs, according to "Extended Channel Interpretations" 5.3
- * of ISO 18004.
+ * Superclass of classes encapsulating types ECIs, according to "Extended Channel Interpretations"
+ * 5.3 of ISO 18004.
  *
  * @author Sean Owen
  */
@@ -34,6 +34,11 @@ public abstract class ECI {
     return value;
   }
 
+  /**
+   * @param value ECI value
+   * @return {@link ECI} representing ECI of given value, or null if it is legal but unsupported
+   * @throws IllegalArgumentException if ECI value is invalid
+   */
   public static ECI getECIByValue(int value) {
     if (value < 0 || value > 999999) {
       throw new IllegalArgumentException("Bad ECI value: " + value);
@@ -41,7 +46,7 @@ public abstract class ECI {
     if (value < 900) { // Character set ECIs use 000000 - 000899
       return CharacterSetECI.getCharacterSetECIByValue(value);
     }
-    throw new IllegalArgumentException("Unsupported ECI value: " + value);
+    return null;
   }
 
 }