Merge branch 'devel' of master.kernel.org:/home/rmk/linux-2.6-mmc

[powerpc.git] / drivers / acpi / fan.c

diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
index c1d4705..38acc69 100644 (file)
--- a/drivers/acpi/fan.c
+++ b/drivers/acpi/fan.c
@@ -78,7 +78,6 @@ static int acpi_fan_read_state(struct seq_file *seq, void *offset)
        struct acpi_fan *fan = seq->private;
        int state = 0;
 
-       ACPI_FUNCTION_TRACE("acpi_fan_read_state");
 
        if (fan) {
                if (acpi_bus_get_power(fan->handle, &state))
@@ -87,7 +86,7 @@ static int acpi_fan_read_state(struct seq_file *seq, void *offset)
                        seq_printf(seq, "status:                  %s\n",
                                   !state ? "on" : "off");
        }
-       return_VALUE(0);
+       return 0;
 }
 
 static int acpi_fan_state_open_fs(struct inode *inode, struct file *file)
@@ -104,22 +103,21 @@ acpi_fan_write_state(struct file *file, const char __user * buffer,
        struct acpi_fan *fan = (struct acpi_fan *)m->private;
        char state_string[12] = { '\0' };
 
-       ACPI_FUNCTION_TRACE("acpi_fan_write_state");
 
        if (!fan || (count > sizeof(state_string) - 1))
-               return_VALUE(-EINVAL);
+               return -EINVAL;
 
        if (copy_from_user(state_string, buffer, count))
-               return_VALUE(-EFAULT);
+               return -EFAULT;
 
        state_string[count] = '\0';
 
        result = acpi_bus_set_power(fan->handle,
                                    simple_strtoul(state_string, NULL, 0));
        if (result)
-               return_VALUE(result);
+               return result;
 
-       return_VALUE(count);
+       return count;
 }
 
 static struct file_operations acpi_fan_state_ops = {
@@ -135,16 +133,15 @@ static int acpi_fan_add_fs(struct acpi_device *device)
 {
        struct proc_dir_entry *entry = NULL;
 
-       ACPI_FUNCTION_TRACE("acpi_fan_add_fs");
 
        if (!device)
-               return_VALUE(-EINVAL);
+               return -EINVAL;
 
        if (!acpi_device_dir(device)) {
                acpi_device_dir(device) = proc_mkdir(acpi_device_bid(device),
                                                     acpi_fan_dir);
                if (!acpi_device_dir(device))
-                       return_VALUE(-ENODEV);
+                       return -ENODEV;
                acpi_device_dir(device)->owner = THIS_MODULE;
        }
 
@@ -153,19 +150,18 @@ static int acpi_fan_add_fs(struct acpi_device *device)
                                  S_IFREG | S_IRUGO | S_IWUSR,
                                  acpi_device_dir(device));
        if (!entry)
-               return_VALUE(-ENODEV);
+               return -ENODEV;
        else {
                entry->proc_fops = &acpi_fan_state_ops;
                entry->data = acpi_driver_data(device);
                entry->owner = THIS_MODULE;
        }
 
-       return_VALUE(0);
+       return 0;
 }
 
 static int acpi_fan_remove_fs(struct acpi_device *device)
 {
-       ACPI_FUNCTION_TRACE("acpi_fan_remove_fs");
 
        if (acpi_device_dir(device)) {
                remove_proc_entry(ACPI_FAN_FILE_STATE, acpi_device_dir(device));
@@ -173,7 +169,7 @@ static int acpi_fan_remove_fs(struct acpi_device *device)
                acpi_device_dir(device) = NULL;
        }
 
-       return_VALUE(0);
+       return 0;
 }
 
 /* --------------------------------------------------------------------------
@@ -186,14 +182,13 @@ static int acpi_fan_add(struct acpi_device *device)
        struct acpi_fan *fan = NULL;
        int state = 0;
 
-       ACPI_FUNCTION_TRACE("acpi_fan_add");
 
        if (!device)
-               return_VALUE(-EINVAL);
+               return -EINVAL;
 
        fan = kmalloc(sizeof(struct acpi_fan), GFP_KERNEL);
        if (!fan)
-               return_VALUE(-ENOMEM);
+               return -ENOMEM;
        memset(fan, 0, sizeof(struct acpi_fan));
 
        fan->handle = device->handle;
@@ -203,7 +198,7 @@ static int acpi_fan_add(struct acpi_device *device)
 
        result = acpi_bus_get_power(fan->handle, &state);
        if (result) {
-               ACPI_ERROR((AE_INFO, "Reading power state"));
+               printk(KERN_ERR PREFIX "Reading power state\n");
                goto end;
        }
 
@@ -223,17 +218,16 @@ static int acpi_fan_add(struct acpi_device *device)
        if (result)
                kfree(fan);
 
-       return_VALUE(result);
+       return result;
 }
 
 static int acpi_fan_remove(struct acpi_device *device, int type)
 {
        struct acpi_fan *fan = NULL;
 
-       ACPI_FUNCTION_TRACE("acpi_fan_remove");
 
        if (!device || !acpi_driver_data(device))
-               return_VALUE(-EINVAL);
+               return -EINVAL;
 
        fan = (struct acpi_fan *)acpi_driver_data(device);
 
@@ -241,7 +235,7 @@ static int acpi_fan_remove(struct acpi_device *device, int type)
 
        kfree(fan);
 
-       return_VALUE(0);
+       return 0;
 }
 
 static int acpi_fan_suspend(struct acpi_device *device, int state)
@@ -280,31 +274,29 @@ static int __init acpi_fan_init(void)
 {
        int result = 0;
 
-       ACPI_FUNCTION_TRACE("acpi_fan_init");
 
        acpi_fan_dir = proc_mkdir(ACPI_FAN_CLASS, acpi_root_dir);
        if (!acpi_fan_dir)
-               return_VALUE(-ENODEV);
+               return -ENODEV;
        acpi_fan_dir->owner = THIS_MODULE;
 
        result = acpi_bus_register_driver(&acpi_fan_driver);
        if (result < 0) {
                remove_proc_entry(ACPI_FAN_CLASS, acpi_root_dir);
-               return_VALUE(-ENODEV);
+               return -ENODEV;
        }
 
-       return_VALUE(0);
+       return 0;
 }
 
 static void __exit acpi_fan_exit(void)
 {
-       ACPI_FUNCTION_TRACE("acpi_fan_exit");
 
        acpi_bus_unregister_driver(&acpi_fan_driver);
 
        remove_proc_entry(ACPI_FAN_CLASS, acpi_root_dir);
 
-       return_VOID;
+       return;
 }
 
 module_init(acpi_fan_init);