knfsd: fix broken length check in nfs4idmap.c

[powerpc.git] / fs / nfsd / nfsxdr.c

diff --git a/fs/nfsd/nfsxdr.c b/fs/nfsd/nfsxdr.c
index 6035e03..b86e365 100644 (file)
--- a/fs/nfsd/nfsxdr.c
+++ b/fs/nfsd/nfsxdr.c
@@ -231,9 +231,10 @@ int
 nfssvc_decode_sattrargs(struct svc_rqst *rqstp, __be32 *p,
                                        struct nfsd_sattrargs *args)
 {
-       if (!(p = decode_fh(p, &args->fh))
-        || !(p = decode_sattr(p, &args->attrs)))
+       p = decode_fh(p, &args->fh);
+       if (!p)
                return 0;
+       p = decode_sattr(p, &args->attrs);
 
        return xdr_argsize_check(rqstp, p);
 }
@@ -303,29 +304,20 @@ nfssvc_decode_writeargs(struct svc_rqst *rqstp, __be32 *p,
        /*
         * Check to make sure that we got the right number of
         * bytes.
-        *
-        * If more than one page was used, then compute the length
-        * of the data in the request as the total size of the
-        * request minus the transport protocol headers minus the
-        * RPC protocol headers minus the NFS protocol fields
-        * already consumed.  If the request fits into a single
-        * page, then compete the length of the data as the size
-        * of the NFS portion of the request minus the NFS
-        * protocol fields already consumed.
         */
        hdr = (void*)p - rqstp->rq_arg.head[0].iov_base;
-       if (rqstp->rq_respages != rqstp->rq_pages + 1) {
-               dlen = rqstp->rq_arg.len -
-                       (PAGE_SIZE - rqstp->rq_arg.head[0].iov_len) - hdr;
-       } else {
-               dlen = rqstp->rq_arg.head[0].iov_len - hdr;
-       }
+       dlen = rqstp->rq_arg.head[0].iov_len + rqstp->rq_arg.page_len
+               - hdr;
+
        /*
         * Round the length of the data which was specified up to
         * the next multiple of XDR units and then compare that
         * against the length which was actually received.
+        * Note that when RPCSEC/GSS (for example) is used, the
+        * data buffer can be padded so dlen might be larger
+        * than required.  It must never be smaller.
         */
-       if (dlen != ((len + 3) & ~0x3))
+       if (dlen < XDR_QUADLEN(len)*4)
                return 0;
 
        rqstp->rq_vec[0].iov_base = (void*)p;
@@ -346,10 +338,10 @@ int
 nfssvc_decode_createargs(struct svc_rqst *rqstp, __be32 *p,
                                        struct nfsd_createargs *args)
 {
-       if (!(p = decode_fh(p, &args->fh))
-        || !(p = decode_filename(p, &args->name, &args->len))
-        || !(p = decode_sattr(p, &args->attrs)))
+       if (   !(p = decode_fh(p, &args->fh))
+           || !(p = decode_filename(p, &args->name, &args->len)))
                return 0;
+       p = decode_sattr(p, &args->attrs);
 
        return xdr_argsize_check(rqstp, p);
 }
@@ -393,11 +385,11 @@ int
 nfssvc_decode_symlinkargs(struct svc_rqst *rqstp, __be32 *p,
                                        struct nfsd_symlinkargs *args)
 {
-       if (!(p = decode_fh(p, &args->ffh))
-        || !(p = decode_filename(p, &args->fname, &args->flen))
-        || !(p = decode_pathname(p, &args->tname, &args->tlen))
-        || !(p = decode_sattr(p, &args->attrs)))
+       if (   !(p = decode_fh(p, &args->ffh))
+           || !(p = decode_filename(p, &args->fname, &args->flen))
+           || !(p = decode_pathname(p, &args->tname, &args->tlen)))
                return 0;
+       p = decode_sattr(p, &args->attrs);
 
        return xdr_argsize_check(rqstp, p);
 }
@@ -534,6 +526,10 @@ nfssvc_encode_entry(void *ccdv, const char *name,
                cd->common.err = nfserr_toosmall;
                return -EINVAL;
        }
+       if (ino > ~((u32) 0)) {
+               cd->common.err = nfserr_fbig;
+               return -EINVAL;
+       }
        *p++ = xdr_one;                         /* mark entry present */
        *p++ = htonl((u32) ino);                /* file id */
        p    = xdr_encode_array(p, name, namlen);/* name length & name */