Issue 131: reuse Alert objects

[zxing.git] / javame / src / com / google / zxing / client / j2me / ZXingMIDlet.java

diff --git a/javame/src/com/google/zxing/client/j2me/ZXingMIDlet.java b/javame/src/com/google/zxing/client/j2me/ZXingMIDlet.java
index 9f633d4..f07d813 100644 (file)
--- a/javame/src/com/google/zxing/client/j2me/ZXingMIDlet.java
+++ b/javame/src/com/google/zxing/client/j2me/ZXingMIDlet.java
@@ -17,17 +17,14 @@
 package com.google.zxing.client.j2me;
 
 import com.google.zxing.Result;
-import com.google.zxing.client.result.BookmarkDoCoMoParsedResult;
 import com.google.zxing.client.result.EmailAddressParsedResult;
-import com.google.zxing.client.result.EmailDoCoMoParsedResult;
-import com.google.zxing.client.result.ParsedReaderResult;
-import com.google.zxing.client.result.ParsedReaderResultType;
+import com.google.zxing.client.result.ParsedResult;
+import com.google.zxing.client.result.ParsedResultType;
+import com.google.zxing.client.result.ResultParser;
 import com.google.zxing.client.result.SMSParsedResult;
-import com.google.zxing.client.result.SMSTOParsedResult;
 import com.google.zxing.client.result.TelParsedResult;
-import com.google.zxing.client.result.UPCParsedResult;
+import com.google.zxing.client.result.ProductParsedResult;
 import com.google.zxing.client.result.URIParsedResult;
-import com.google.zxing.client.result.URLTOParsedResult;
 
 import javax.microedition.io.ConnectionNotFoundException;
 import javax.microedition.lcdui.Alert;
@@ -48,13 +45,17 @@ import java.io.IOException;
 /**
  * <p>The actual reader application {@link MIDlet}.</p>
  *
- * @author Sean Owen (srowen@google.com)
+ * @author Sean Owen
  */
 public final class ZXingMIDlet extends MIDlet {
 
+  private static final int ALERT_TIMEOUT_MS = 5 * 1000;
+
   private Canvas canvas;
   private Player player;
   private VideoControl videoControl;
+  private Alert confirmation;
+  private Alert alert;
 
   Displayable getCanvas() {
     return canvas;
@@ -68,12 +69,19 @@ public final class ZXingMIDlet extends MIDlet {
     return videoControl;
   }
 
+  static MultimediaManager buildMultimediaManager() {
+    return new AdvancedMultimediaManager();
+    // Comment line above / uncomment below to make the basic version
+    // return new DefaultMultimediaManager();
+  }
+
   protected void startApp() throws MIDletStateChangeException {
     try {
       player = createPlayer();
       player.realize();
-      AdvancedMultimediaManager.setZoom(player);
-      AdvancedMultimediaManager.setExposure(player);
+      MultimediaManager multimediaManager = buildMultimediaManager();
+      multimediaManager.setZoom(player);
+      multimediaManager.setExposure(player);
       videoControl = (VideoControl) player.getControl("VideoControl");
       canvas = new VideoCanvas(this);
       canvas.setFullScreenMode(true);
@@ -88,6 +96,17 @@ public final class ZXingMIDlet extends MIDlet {
     } catch (MediaException me) {
       throw new MIDletStateChangeException(me.toString());
     }
+
+    // Set up one confirmation and alert object to re-use
+    confirmation = new Alert(null);
+    confirmation.setType(AlertType.CONFIRMATION);
+    confirmation.setTimeout(ALERT_TIMEOUT_MS);
+    Command yes = new Command("Yes", Command.OK, 1);
+    confirmation.addCommand(yes);
+    Command no = new Command("No", Command.CANCEL, 1);
+    confirmation.addCommand(no);
+    alert = new Alert(null);
+    alert.setTimeout(ALERT_TIMEOUT_MS);
   }
 
   private static Player createPlayer() throws IOException, MediaException {
@@ -143,12 +162,8 @@ public final class ZXingMIDlet extends MIDlet {
   // Convenience methods to show dialogs
 
   private void showOpenURL(String title, String display, final String uri) {
-    Alert alert = new Alert(title, display, null, AlertType.CONFIRMATION);
-    alert.setTimeout(Alert.FOREVER);
-    Command yes = new Command("Yes", Command.OK, 1);
-    alert.addCommand(yes);
-    Command no = new Command("No", Command.CANCEL, 1);
-    alert.addCommand(no);
+    confirmation.setTitle(title);
+    confirmation.setString(display);
     CommandListener listener = new CommandListener() {
       public void commandAction(Command command, Displayable displayable) {
         if (command.getCommandType() == Command.OK) {
@@ -165,13 +180,14 @@ public final class ZXingMIDlet extends MIDlet {
         }
       }
     };
-    alert.setCommandListener(listener);
-    showAlert(alert);
+    confirmation.setCommandListener(listener);
+    showAlert(confirmation);
   }
 
   private void showAlert(String title, String text) {
-    Alert alert = new Alert(title, text, null, AlertType.INFO);
-    alert.setTimeout(Alert.FOREVER);
+    alert.setTitle(title);
+    alert.setString(text);
+    alert.setType(AlertType.INFO);
     showAlert(alert);
   }
 
@@ -185,7 +201,10 @@ public final class ZXingMIDlet extends MIDlet {
   }
 
   void showError(String message) {
-    showAlert(new Alert("Error", message, null, AlertType.ERROR));
+    alert.setTitle("Error");
+    alert.setString(message);
+    alert.setType(AlertType.ERROR);
+    showAlert(alert);
   }
 
   private void showAlert(Alert alert) {
@@ -194,34 +213,22 @@ public final class ZXingMIDlet extends MIDlet {
   }
 
   void handleDecodedText(Result theResult) {
-    ParsedReaderResult result = ParsedReaderResult.parseReaderResult(theResult);
-    ParsedReaderResultType type = result.getType();
-    if (type.equals(ParsedReaderResultType.URI)) {
+    ParsedResult result = ResultParser.parseResult(theResult);
+    ParsedResultType type = result.getType();
+    if (type.equals(ParsedResultType.URI)) {
       String uri = ((URIParsedResult) result).getURI();
       showOpenURL("Open Web Page?", uri, uri);
-    } else if (type.equals(ParsedReaderResultType.BOOKMARK)) {
-      String uri = ((BookmarkDoCoMoParsedResult) result).getURI();
-      showOpenURL("Open Web Page?", uri, uri);      
-    } else if (type.equals(ParsedReaderResultType.URLTO)) {
-      String uri = ((URLTOParsedResult) result).getURI();
-      showOpenURL("Open Web Page?", uri, uri);
-    } else if (type.equals(ParsedReaderResultType.EMAIL)) {
-      EmailDoCoMoParsedResult emailResult = (EmailDoCoMoParsedResult) result;
-      showOpenURL("Compose E-mail?", emailResult.getTo(), emailResult.getMailtoURI());
-    } else if (type.equals(ParsedReaderResultType.EMAIL_ADDRESS)) {
+    } else if (type.equals(ParsedResultType.EMAIL_ADDRESS)) {
       EmailAddressParsedResult emailResult = (EmailAddressParsedResult) result;
       showOpenURL("Compose E-mail?", emailResult.getEmailAddress(), emailResult.getMailtoURI());
-    } else if (type.equals(ParsedReaderResultType.SMS)) {
+    } else if (type.equals(ParsedResultType.SMS)) {
       SMSParsedResult smsResult = (SMSParsedResult) result;
       showOpenURL("Compose SMS?", smsResult.getNumber(), smsResult.getSMSURI());
-    } else if (type.equals(ParsedReaderResultType.SMSTO)) {
-      SMSTOParsedResult smsToResult = (SMSTOParsedResult) result;
-      showOpenURL("Compose SMS?", smsToResult.getNumber(), smsToResult.getSMSURI());
-    } else if (type.equals(ParsedReaderResultType.UPC)) {
-      String upc = ((UPCParsedResult) result).getUPC();
-      String uri = "http://www.upcdatabase.com/item.asp?upc=" + upc;
-      showOpenURL("Look Up Barcode Online?", upc, uri);
-    } else if (type.equals(ParsedReaderResultType.TEL)) {
+    } else if (type.equals(ParsedResultType.PRODUCT)) {
+      ProductParsedResult productResult = (ProductParsedResult) result;
+      String uri = "http://www.upcdatabase.com/item.asp?upc=" + productResult.getNormalizedProductID();
+      showOpenURL("Look Up Barcode Online?", productResult.getProductID(), uri);
+    } else if (type.equals(ParsedResultType.TEL)) {
       TelParsedResult telResult = (TelParsedResult) result;
       showOpenURL("Dial Number?", telResult.getNumber(), telResult.getTelURI());
     } else {