vmcoreinfo: add "VMCOREINFO_" to all the call for vmcoreinfo_append_str()

[powerpc.git] / kernel / params.c

diff --git a/kernel/params.c b/kernel/params.c
index 97e0923..e28c706 100644 (file)
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -272,7 +272,7 @@ static int param_array(const char *name,
                       unsigned int min, unsigned int max,
                       void *elem, int elemsize,
                       int (*set)(const char *, struct kernel_param *kp),
-                      int *num)
+                      unsigned int *num)
 {
        int ret;
        struct kernel_param kp;
@@ -376,8 +376,6 @@ int param_get_string(char *buffer, struct kernel_param *kp)
 
 extern struct kernel_param __start___param[], __stop___param[];
 
-#define MAX_KBUILD_MODNAME KOBJ_NAME_LEN
-
 struct param_attribute
 {
        struct module_attribute mattr;
@@ -472,7 +470,7 @@ param_sysfs_setup(struct module_kobject *mk,
                        sizeof(mp->grp.attrs[0]));
        size[1] = (valid_attrs + 1) * sizeof(mp->grp.attrs[0]);
 
-       mp = kmalloc(size[0] + size[1], GFP_KERNEL);
+       mp = kzalloc(size[0] + size[1], GFP_KERNEL);
        if (!mp)
                return ERR_PTR(-ENOMEM);
 
@@ -561,11 +559,9 @@ static void __init kernel_param_sysfs_setup(const char *name,
 
        mk->mod = THIS_MODULE;
        mk->kobj.kset = module_kset;
-       mk->kobj.ktype = &module_ktype;
-       kobject_set_name(&mk->kobj, name);
-       kobject_init(&mk->kobj);
-       ret = kobject_add(&mk->kobj);
+       ret = kobject_init_and_add(&mk->kobj, &module_ktype, NULL, "%s", name);
        if (ret) {
+               kobject_put(&mk->kobj);
                printk(KERN_ERR "Module '%s' failed to be added to sysfs, "
                      "error number %d\n", name, ret);
                printk(KERN_ERR "The system will be unstable now.\n");
@@ -589,7 +585,7 @@ static void __init param_sysfs_builtin(void)
 {
        struct kernel_param *kp, *kp_begin = NULL;
        unsigned int i, name_len, count = 0;
-       char modname[MAX_KBUILD_MODNAME + 1] = "";
+       char modname[MODULE_NAME_LEN + 1] = "";
 
        for (i=0; i < __stop___param - __start___param; i++) {
                char *dot;
@@ -597,12 +593,12 @@ static void __init param_sysfs_builtin(void)
 
                kp = &__start___param[i];
                max_name_len =
-                       min_t(size_t, MAX_KBUILD_MODNAME, strlen(kp->name));
+                       min_t(size_t, MODULE_NAME_LEN, strlen(kp->name));
 
                dot = memchr(kp->name, '.', max_name_len);
                if (!dot) {
                        DEBUGP("couldn't find period in first %d characters "
-                              "of %s\n", MAX_KBUILD_MODNAME, kp->name);
+                              "of %s\n", MODULE_NAME_LEN, kp->name);
                        continue;
                }
                name_len = dot - kp->name;
@@ -696,18 +692,8 @@ static struct kset_uevent_ops module_uevent_ops = {
 struct kset *module_kset;
 int module_sysfs_initialized;
 
-static void module_release(struct kobject *kobj)
-{
-       /*
-        * Stupid empty release function to allow the memory for the kobject to
-        * be properly cleaned up.  This will not need to be present for 2.6.25
-        * with the upcoming kobject core rework.
-        */
-}
-
 struct kobj_type module_ktype = {
        .sysfs_ops =    &module_sysfs_ops,
-       .release =      module_release,
 };
 
 /*