report error without nmap output

[pxelator] / lib / PXElator / daemons.pm

diff --git a/lib/PXElator/daemons.pm b/lib/PXElator/daemons.pm
index d190679..ee17802 100644 (file)
--- a/lib/PXElator/daemons.pm
+++ b/lib/PXElator/daemons.pm
@@ -7,7 +7,7 @@ use File::Slurp;
 use Data::Dump qw/dump/;
 
 use x11;
-use CouchDB;
+use store;
 
 our $pids;
 $pids = {
@@ -29,19 +29,27 @@ $SIG{CHLD} = 'IGNORE';
 sub audit {
        my $msg = shift;
        my $daemon = shift;
-       CouchDB::audit( $msg, $daemon, { daemon => $daemon, message => $msg, @_ } );
+       store::audit( $msg, $daemon, { daemon => $daemon, message => $msg, @_ } );
 }
 
 mkdir "$server::conf/pid" unless -d "$server::conf/pid";
 
 sub start_stop {
-       my $daemon = shift;
+       my ($daemon,$param) = @_;
+
+       if ( defined $param->{nr} ) { # XXX nr for kvm
+               $daemon .= '.' . $param->{nr};
+       } else {
+               $param->{nr} = $1 if $daemon =~ /\.(\d+)/;
+       }
 
        my $pid = $pids->{$daemon};
        my $pid_path = $daemon;
        $pid_path =~ s{/}{-}g;
        $pid_path = "$server::conf/pid/$pid_path";
 
+       warn "# start_stop $daemon ",dump( $param );
+
        if ( ! $pid && -e $pid_path ) {
                my $p = read_file $pid_path;
                if ( kill 0, $p ) {
@@ -72,22 +80,30 @@ sub start_stop {
                audit 'stopped', $daemon, pid => $pid;
                return qq|$daemon pid $pid stopped|;
        } else {
+
+               $ENV{$_} = $param->{$_} foreach keys %$param;
+
                if ( $pid = fork ) {
                        # parent
                        $pids->{$daemon} = $pid;
                        write_file $pid_path, $pid;
                        audit 'forked', $daemon, pid => $pid;
+
+                       delete $ENV{$_} foreach keys %$param; # cleanup enviroment
+
                        return qq|$daemon pid $pid started|;
                } elsif ( defined $pid ) {
                        # child
                        my $invoke = 'start';
                        $invoke = $1 if $daemon =~ s{/(.+)}{};
+                       #warn "## ENV child ",dump( %ENV );
                        if ( $daemon =~ m{dhcpd|tftpd|dnsd|syslogd} ) {
                                my $exec = "perl -I$server::base_dir/lib -I$server::base_dir/lib/PXElator -M$daemon -e ${daemon}::${invoke}";
                                audit 'exec', $daemon, 'exec' => $exec;
                                x11::xterm( $daemon => $exec );
                        } else {
-                               my $eval = $daemon . '::' . $invoke . '(' . ( @_ ? dump(@_) : '' ) . ')';
+                               $daemon =~ s{\.\d+$}{} if defined $ENV{nr};
+                               my $eval = $daemon . '::' . $invoke . '(' . dump( $param ) . ')';
                                audit 'eval', $daemon, 'eval' => $eval;
                                eval $eval;
                                audit 'error', $daemon, error => $@  if $@;