* fix length of mifare classic block
[librfid] / src / rfid_asic_rc632.c
index 6f42208..8fc5cb9 100644 (file)
@@ -1,6 +1,6 @@
 /* Generic Philips CL RC632 Routines
  *
- * (C) Harald Welte <laforge@gnumonks.org>
+ * (C) 2005-2006 Harald Welte <laforge@gnumonks.org>
  *
  */
 
  *
  *  You should have received a copy of the GNU General Public License
  *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
  */
 
 #include <unistd.h>
 #include <stdlib.h>
 #include <string.h>
 #include <errno.h>
+#include <limits.h>
 #include <sys/types.h>
 
 #include <librfid/rfid.h>
 #include <librfid/rfid_asic_rc632.h>
 #include <librfid/rfid_reader_cm5121.h>
 #include <librfid/rfid_layer2_iso14443a.h>
+#include <librfid/rfid_layer2_iso15693.h>
 #include <librfid/rfid_protocol_mifare_classic.h>
 
 #include "rfid_iso14443_common.h"
 #include "rc632.h"
-//#include "rc632_14443a.h"
 
+#ifdef  __MINGW32__
+#include "usleep.h"
+#endif/*__MINGW32__*/
 
-#define RC632_TMO_AUTH1        14000
+#define RC632_TMO_AUTH1        140
 
 #define ENTER()                DEBUGP("entering\n")
-struct rfid_asic rc632;
+const struct rfid_asic rc632;
 
 /* Register and FIFO Access functions */
 static int 
@@ -135,18 +139,24 @@ rc632_clear_bits(struct rfid_asic_handle *handle,
        return rc632_reg_write(handle, reg, (tmp & ~val)&0xff);
 }
 
-static int 
-rc632_turn_on_rf(struct rfid_asic_handle *handle)
+static int
+rc632_clear_irqs(struct rfid_asic_handle *handle, u_int8_t bits)
 {
-       ENTER();
-       return rc632_set_bits(handle, RC632_REG_TX_CONTROL, 0x03);
+       return rc632_reg_write(handle, RC632_REG_INTERRUPT_RQ, (~RC632_INT_SET)&bits);
 }
 
 static int 
-rc632_turn_off_rf(struct rfid_asic_handle *handle)
+rc632_rf_power(struct rfid_asic_handle *handle, int on)
 {
        ENTER();
-       return rc632_clear_bits(handle, RC632_REG_TX_CONTROL, 0x03);
+       if (on)
+               return rc632_set_bits(handle, RC632_REG_TX_CONTROL,
+                                     RC632_TXCTRL_TX1_RF_EN|
+                                     RC632_TXCTRL_TX2_RF_EN);
+       else
+               return rc632_clear_bits(handle, RC632_REG_TX_CONTROL,
+                                       RC632_TXCTRL_TX1_RF_EN|
+                                       RC632_TXCTRL_TX2_RF_EN);
 }
 
 static int
@@ -164,7 +174,110 @@ rc632_power_down(struct rfid_asic_handle *handle)
                              RC632_CONTROL_POWERDOWN);
 }
 
-/* Stupid RC623 implementations don't evaluate interrupts but poll the
+/* calculate best 8bit prescaler and divisor for given usec timeout */
+static int best_prescaler(u_int64_t timeout, u_int8_t *prescaler,
+                         u_int8_t *divisor)
+{
+       u_int8_t best_prescaler, best_divisor, i;
+       int64_t smallest_diff;
+
+       smallest_diff = LLONG_MAX;
+       best_prescaler = 0;
+
+       for (i = 0; i < 21; i++) {
+               u_int64_t clk, tmp_div, res;
+               int64_t diff;
+               clk = 13560000 / (1 << i);
+               tmp_div = (clk * timeout) / 1000000;
+               tmp_div++;
+
+               if ((tmp_div > 0xff) || (tmp_div > clk))
+                       continue;
+
+               res = 1000000 / (clk / tmp_div);
+               diff = res - timeout;
+
+               if (diff < 0)
+                       continue;
+
+               if (diff < smallest_diff) {
+                       best_prescaler = i;
+                       best_divisor = tmp_div;
+                       smallest_diff = diff;
+               }
+       }
+
+       *prescaler = best_prescaler;
+       *divisor = best_divisor;
+
+       DEBUGP("timeout %u usec, prescaler = %u, divisor = %u\n",
+               timeout, best_prescaler, best_divisor);
+
+       return 0;
+}
+
+static int
+rc632_timer_set(struct rfid_asic_handle *handle,
+               u_int64_t timeout)
+{
+       int ret;
+       u_int8_t prescaler, divisor;
+
+       ret = best_prescaler(timeout, &prescaler, &divisor);
+
+       ret = rc632_reg_write(handle, RC632_REG_TIMER_CLOCK,
+                             prescaler & 0x1f);
+       if (ret < 0)
+               return ret;
+
+       ret = rc632_reg_write(handle, RC632_REG_TIMER_CONTROL,
+                             RC632_TMR_START_TX_END|RC632_TMR_STOP_RX_BEGIN);
+
+       /* clear timer irq bit */
+       ret = rc632_set_bits(handle, RC632_REG_INTERRUPT_RQ, RC632_IRQ_TIMER);
+
+       ret |= rc632_reg_write(handle, RC632_REG_TIMER_RELOAD, divisor);
+
+       return ret;
+}
+
+/* Wait until RC632 is idle or TIMER IRQ has happened */
+static int rc632_wait_idle_timer(struct rfid_asic_handle *handle)
+{
+       int ret;
+       u_int8_t irq, cmd;
+
+       while (1) {
+               rc632_reg_read(handle, RC632_REG_PRIMARY_STATUS, &irq);
+               rc632_reg_read(handle, RC632_REG_ERROR_FLAG, &irq);
+               ret = rc632_reg_read(handle, RC632_REG_INTERRUPT_RQ, &irq);
+               if (ret < 0)
+                       return ret;
+
+               /* FIXME: currently we're lazy:  If we actually received
+                * something even after the timer expired, we accept it */
+               if (irq & RC632_IRQ_TIMER && !(irq & RC632_IRQ_RX)) {
+                       u_int8_t foo;
+                       rc632_reg_read(handle, RC632_REG_PRIMARY_STATUS, &foo);
+                       if (foo & 0x04)
+                               rc632_reg_read(handle, RC632_REG_ERROR_FLAG, &foo);
+
+                       return -110;
+               }
+
+               ret = rc632_reg_read(handle, RC632_REG_COMMAND, &cmd);
+               if (ret < 0)
+                       return ret;
+
+               if (cmd == 0)
+                       return 0;
+
+               /* poll every millisecond */
+               usleep(1000);
+       }
+}
+
+/* Stupid RC632 implementations don't evaluate interrupts but poll the
  * command register for "status idle" */
 static int
 rc632_wait_idle(struct rfid_asic_handle *handle, u_int64_t timeout)
@@ -178,20 +291,32 @@ rc632_wait_idle(struct rfid_asic_handle *handle, u_int64_t timeout)
                if (ret < 0)
                        return ret;
 
-               if (cmd == 0) {
-                       /* FIXME: read second time ?? */
-                       return 0;
-               }
-
                {
                        u_int8_t foo;
                        rc632_reg_read(handle, RC632_REG_PRIMARY_STATUS, &foo);
-                       if (foo & 0x04)
+                       DEBUGP_STATUS_FLAG(foo);
+                       /* check if Error has occured (ERR flag set) */
+                       if (foo & RC632_STAT_ERR) {
                                rc632_reg_read(handle, RC632_REG_ERROR_FLAG, &foo);
+                               DEBUGP_ERROR_FLAG(foo);
+                       }
+                       /* check if IRQ has occurred (IRQ flag set)*/
+                       if (foo & RC632_STAT_IRQ) { 
+                               ret = rc632_reg_read(handle, RC632_REG_INTERRUPT_RQ, &foo);
+                               DEBUGP_INTERRUPT_FLAG(foo);
+                               /* clear all interrupts */
+                               rc632_clear_irqs(handle, 0xff);
+                       }
+               }
+               if (cmd == 0) {
+                       /* FIXME: read second time ?? */
+                       DEBUGP("cmd == 0 (IDLE)\n");
+                       return 0;
                }
 
                /* Abort after some timeout */
-               if (cycles > timeout*10/USLEEP_PER_CYCLE) {
+               if (cycles > timeout*100/USLEEP_PER_CYCLE) {
+                       DEBUGP("timeout...\n");
                        return -ETIMEDOUT;
                }
 
@@ -208,15 +333,36 @@ rc632_transmit(struct rfid_asic_handle *handle,
                u_int8_t len,
                u_int64_t timeout)
 {
-       int ret;
+       int ret, cur_len;
+       const u_int8_t *cur_buf = buf;
 
-       ret = rc632_fifo_write(handle, len, buf, 0x03);
-       if (ret < 0)
-               return ret;
+       if (len > 64)
+               cur_len = 64;
+       else
+               cur_len = len;
+       
+       do {
+               ret = rc632_fifo_write(handle, cur_len, cur_buf, 0x03);
+               if (ret < 0)
+                       return ret;
 
-       ret = rc632_reg_write(handle, RC632_REG_COMMAND, RC632_CMD_TRANSMIT);
-       if (ret < 0)
-               return ret;
+               if (cur_buf == buf)  {
+                       /* only start transmit first time */
+                       ret = rc632_reg_write(handle, RC632_REG_COMMAND,
+                                             RC632_CMD_TRANSMIT);
+                       if (ret < 0)
+                               return ret;
+               }
+
+               cur_buf += cur_len;
+               if (cur_buf < buf + len) {
+                       cur_len = buf - cur_buf;
+                       if (cur_len > 64)
+                               cur_len = 64;
+               } else
+                       cur_len = 0;
+
+       } while (cur_len);
 
        return rc632_wait_idle(handle, timeout);
 }
@@ -224,7 +370,7 @@ rc632_transmit(struct rfid_asic_handle *handle,
 static int
 tcl_toggle_pcb(struct rfid_asic_handle *handle)
 {
-       // FIXME: toggle something between 0x0a and 0x0b
+       /* FIXME: toggle something between 0x0a and 0x0b */
        return 0;
 }
 
@@ -234,42 +380,150 @@ rc632_transceive(struct rfid_asic_handle *handle,
                 u_int8_t tx_len,
                 u_int8_t *rx_buf,
                 u_int8_t *rx_len,
-                unsigned int timer,
+                u_int64_t timer,
                 unsigned int toggle)
 {
-       int ret;
+       int ret, cur_tx_len, i;
+       u_int8_t rx_avail;
+       const u_int8_t *cur_tx_buf = tx_buf;
 
-       ret = rc632_fifo_write(handle, tx_len, tx_buf, 0x03);
-       if (ret < 0)
-               return ret;
+       DEBUGP("timer=%u, rx_len=%u, tx_len=%u,", timer, rx_len, tx_len);
 
-       ret = rc632_reg_write(handle, RC632_REG_COMMAND, RC632_CMD_TRANSCEIVE);
+       if (tx_len > 64)
+               cur_tx_len = 64;
+       else
+               cur_tx_len = tx_len;
+
+       ret = rc632_timer_set(handle, timer);
        if (ret < 0)
                return ret;
+       
+       ret = rc632_reg_write(handle, RC632_REG_COMMAND, 0x00);
+       /* clear all interrupts */
+       ret = rc632_reg_write(handle, RC632_REG_INTERRUPT_RQ, 0x7f);
+       ret = rc632_reg_write(handle, RC632_REG_ERROR_FLAG, 0xff);
+
+       do {    
+               ret = rc632_fifo_write(handle, cur_tx_len, cur_tx_buf, 0x03);
+               if (ret < 0)
+                       return ret;
+
+               if (cur_tx_buf == tx_buf) {
+                       ret = rc632_reg_write(handle, RC632_REG_COMMAND,
+                                             RC632_CMD_TRANSCEIVE);
+                       if (ret < 0)
+                               return ret;
+               }
+
+               cur_tx_buf += cur_tx_len;
+               if (cur_tx_buf < tx_buf + tx_len) {
+                       u_int8_t fifo_fill;
+                       ret = rc632_reg_read(handle, RC632_REG_FIFO_LENGTH,
+                                            &fifo_fill);
+                       if (ret < 0)
+                               return ret;
+
+                       cur_tx_len = 64 - fifo_fill;
+               } else
+                       cur_tx_len = 0;
+
+       } while (cur_tx_len);
 
        if (toggle == 1)
                tcl_toggle_pcb(handle);
 
+       //ret = rc632_wait_idle_timer(handle);
        ret = rc632_wait_idle(handle, timer);
+
+       DEBUGP("rc632_wait_idle>>ret=%d %s\n",ret,(ret==-ETIMEDOUT)?"ETIMEDOUT":"");
        if (ret < 0)
                return ret;
 
-       ret = rc632_reg_read(handle, RC632_REG_FIFO_LENGTH, rx_len);
+       ret = rc632_reg_read(handle, RC632_REG_FIFO_LENGTH, &rx_avail);
        if (ret < 0)
                return ret;
 
-       if (*rx_len == 0) {
+       if (rx_avail > *rx_len)
+               DEBUGP("rx_avail(%d) > rx_len(%d), JFYI\n", rx_avail, *rx_len);
+       else if (*rx_len > rx_avail)
+               *rx_len = rx_avail;
+
+       DEBUGP("rx_len == %d\n",*rx_len);
+
+       if (rx_avail == 0) {
+               u_int8_t tmp;
+
+               for (i = 0; i < 1; i++){
+                       rc632_reg_read(handle, RC632_REG_PRIMARY_STATUS, &tmp);
+                       DEBUGP_STATUS_FLAG(tmp);
+                       rc632_reg_read(handle, RC632_REG_ERROR_FLAG, &tmp);
+                       DEBUGP_ERROR_FLAG(tmp);
+               }
+               rc632_reg_read(handle, RC632_REG_CHANNEL_REDUNDANCY, &tmp);
+
+               //return 0;
+               return -1;
+       }
+
+       return rc632_fifo_read(handle, *rx_len, rx_buf);
+       /* FIXME: discard addidional bytes in FIFO */
+}
+
+
+static int
+rc632_receive(struct rfid_asic_handle *handle,
+                u_int8_t *rx_buf,
+                u_int8_t *rx_len,
+                u_int64_t timer)
+{
+       int ret, cur_tx_len, i;
+       u_int8_t rx_avail;
+
+       /*
+       DEBUGP("timer = %u\n", timer);
+       ret = rc632_timer_set(handle, timer*10);
+       if (ret < 0)
+               return ret;
+       /*
+       ret = rc632_reg_write(handle, RC632_REG_COMMAND, 0x00); /* IDLE */
+       /* clear all interrupts */
+       ret = rc632_reg_write(handle, RC632_REG_INTERRUPT_RQ, 0x7f);
+
+       ret = rc632_reg_write(handle, RC632_REG_COMMAND,RC632_CMD_RECEIVE);
+       if (ret < 0)
+                       return ret;
+
+       ret = rc632_wait_idle(handle, timer);
+       if (ret < 0)
+               return ret;
+
+       ret = rc632_reg_read(handle, RC632_REG_FIFO_LENGTH, &rx_avail);
+       if (ret < 0)
+               return ret;
+
+       if (rx_avail > *rx_len) {
+               //printf("rx_avail(%d) > rx_len(%d), JFYI\n", rx_avail, *rx_len);
+       } else if (*rx_len > rx_avail)
+               *rx_len = rx_avail;
+
+       if (rx_avail == 0) {
                u_int8_t tmp;
 
                DEBUGP("rx_len == 0\n");
 
-               rc632_reg_read(handle, RC632_REG_ERROR_FLAG, &tmp);
-               rc632_reg_read(handle, RC632_REG_CHANNEL_REDUNDANCY, &tmp);
+               for (i = 0; i < 1; i++) {
+                       rc632_reg_read(handle, RC632_REG_PRIMARY_STATUS, &tmp);
+                       DEBUGP_STATUS_FLAG(tmp);
+                       rc632_reg_read(handle, RC632_REG_ERROR_FLAG, &tmp);
+                       DEBUGP_ERROR_FLAG(tmp);
+               }
 
+               rc632_reg_read(handle, RC632_REG_CHANNEL_REDUNDANCY, &tmp);
                return -1; 
        }
 
        return rc632_fifo_read(handle, *rx_len, rx_buf);
+       /* FIXME: discard additional bytes in FIFO */
 }
 
 static int
@@ -297,7 +551,7 @@ rc632_read_eeprom(struct rfid_asic_handle *handle)
        if (ret < 0)
                return ret;
 
-       // FIXME: do something with eeprom contents
+       /* FIXME: do something with eeprom contents */
        return ret;
 }
 
@@ -324,7 +578,7 @@ rc632_calc_crc16_from(struct rfid_asic_handle *handle)
        if (ret < 0)
                return ret;
        
-       usleep(10000);  // FIXME: no checking for cmd completion?
+       usleep(10000);  /* FIXME: no checking for cmd completion? *
 
        ret = rc632_reg_read(handle, RC632_REG_CRC_RESULT_LSB, &crc_lsb);
        if (ret < 0)
@@ -334,7 +588,7 @@ rc632_calc_crc16_from(struct rfid_asic_handle *handle)
        if (ret < 0)
                return ret;
 
-       // FIXME: what to do with crc result?
+       /* FIXME: what to do with crc result? */
        return ret;
 }
 
@@ -342,17 +596,14 @@ rc632_calc_crc16_from(struct rfid_asic_handle *handle)
 int
 rc632_register_dump(struct rfid_asic_handle *handle, u_int8_t *buf)
 {
-       int ret;
+       int ret = 0;
        u_int8_t i;
 
-       for (i = 0; i <= 0x3f; i++) {
-               ret = rc632_reg_read(handle, i, &buf[i]);
-               // do we want error checks?
-       }
-       return 0;
-}
-
+       for (i = 0; i <= 0x3f; i++)
+               ret |= rc632_reg_read(handle, i, &buf[i]);
 
+       return ret;
+}
 
 /* generic FIFO access functions (if no more efficient ones provided by
  * transport driver) */
@@ -360,14 +611,14 @@ rc632_register_dump(struct rfid_asic_handle *handle, u_int8_t *buf)
 static int 
 generic_fifo_write()
 {
-       // FIXME: implementation (not needed for CM 5121)
+       /* FIXME: implementation (not needed for CM 5121) */
        return -1;
 }
 
 static int
 generic_fifo_read()
 {
-       // FIXME: implementation (not neded for CM 5121)
+       /* FIXME: implementation (not neded for CM 5121) */
        return -1;
 }
 
@@ -398,8 +649,15 @@ rc632_init(struct rfid_asic_handle *ah)
        if (ret < 0)
                return ret;
 
+       /* switch off rf */
+       ret = rc632_rf_power(ah, 0);
+       if (ret < 0)
+               return ret;
+
+       usleep(100000);
+
        /* switch on rf */
-       ret = rc632_turn_on_rf(ah);
+       ret = rc632_rf_power(ah, 1);
        if (ret < 0)
                return ret;
 
@@ -412,7 +670,7 @@ rc632_fini(struct rfid_asic_handle *ah)
        int ret;
 
        /* switch off rf */
-       ret = rc632_turn_off_rf(ah);
+       ret = rc632_rf_power(ah, 0);
        if (ret < 0)
                return ret;
 
@@ -428,18 +686,20 @@ rc632_open(struct rfid_asic_transport_handle *th)
 {
        struct rfid_asic_handle *h;
 
-       h = malloc(sizeof(*h));
+       h = malloc_asic_handle(sizeof(*h));
        if (!h)
                return NULL;
        memset(h, 0, sizeof(*h));
 
-       h->asic = &rc632;
+       h->asic = (void*)&rc632;
        h->rath = th;
        h->fc = h->asic->fc;
-       h->mtu = h->mru = 40; /* FIXME */
+       /* FIXME: this is only cm5121 specific, since the latency
+        * down to the RC632 FIFO is too long to refill during TX/RX */
+       h->mtu = h->mru = 64;
 
        if (rc632_init(h) < 0) {
-               free(h);
+               free_asic_handle(h);
                return NULL;
        }
 
@@ -450,14 +710,14 @@ void
 rc632_close(struct rfid_asic_handle *h)
 {
        rc632_fini(h);
-       free(h);
+       free_asic_handle(h);
 }
 
 
 /* 
  * Philips CL RC632 primitives for ISO 14443-A compliant PICC's
  *
- * (C) 2005 by Harald Welte <laforge@gnumonks.org>
+ * (C) 2005-2006 by Harald Welte <laforge@gnumonks.org>
  *
  */
 
@@ -466,10 +726,11 @@ rc632_iso14443a_init(struct rfid_asic_handle *handle)
 {
        int ret;
 
-       // FIXME: some fifo work (drain fifo?)
+       /* FIXME: some fifo work (drain fifo?) */
        
        /* flush fifo (our way) */
-       ret = rc632_reg_write(handle, RC632_REG_CONTROL, 0x01);
+       ret = rc632_reg_write(handle, RC632_REG_CONTROL,
+                             RC632_CONTROL_FIFO_FLUSH);
 
        ret = rc632_reg_write(handle, RC632_REG_TX_CONTROL,
                        (RC632_TXCTRL_TX1_RF_EN |
@@ -569,7 +830,7 @@ rc632_iso14443a_fini(struct iso14443a_handle *handle_14443)
 {
 
 #if 0
-       ret = rc632_turn_off_rf(handle);
+       ret = rc632_rf_power(handle, 0);
        if (ret < 0)
                return ret;
 #endif
@@ -588,8 +849,9 @@ rc632_iso14443a_transceive_sf(struct rfid_asic_handle *handle,
        int ret;
        u_int8_t tx_buf[1];
        u_int8_t rx_len = 2;
+       u_int8_t error_flag;
 
-       memset(atqa, 0, sizeof(atqa));
+       memset(atqa, 0, sizeof(*atqa));
 
        tx_buf[0] = cmd;
 
@@ -616,7 +878,8 @@ rc632_iso14443a_transceive_sf(struct rfid_asic_handle *handle,
                return ret;
 
        ret = rc632_transceive(handle, tx_buf, sizeof(tx_buf),
-                               (u_int8_t *)atqa, &rx_len, 0x32, 0);
+                               (u_int8_t *)atqa, &rx_len,
+                               ISO14443A_FDT_ANTICOL_LAST1, 0);
        if (ret < 0) {
                DEBUGP("error during rc632_transceive()\n");
                return ret;
@@ -627,6 +890,21 @@ rc632_iso14443a_transceive_sf(struct rfid_asic_handle *handle,
        if (ret < 0)
                return ret;
 
+       /* determine whether there was a collission */
+       ret = rc632_reg_read(handle, RC632_REG_ERROR_FLAG, &error_flag);
+       if (ret < 0)
+               return ret;
+
+       if (error_flag & RC632_ERR_FLAG_COL_ERR) {
+               u_int8_t boc;
+               /* retrieve bit of collission */
+               ret = rc632_reg_read(handle, RC632_REG_COLL_POS, &boc);
+               if (ret < 0)
+                       return ret;
+               DEBUGP("collision detected in xcv_sf: bit_of_col=%u\n", boc);
+               /* FIXME: how to signal this up the stack */
+       }
+
        if (rx_len != 2) {
                DEBUGP("rx_len(%d) != 2\n", rx_len);
                return -1;
@@ -644,9 +922,14 @@ rc632_iso14443ab_transceive(struct rfid_asic_handle *handle,
                           u_int64_t timeout, unsigned int flags)
 {
        int ret;
-       u_int8_t rxl = *rx_len & 0xff;
+       u_int8_t rxl;
        u_int8_t channel_red;
 
+       if (*rx_len > 0xff)
+               rxl = 0xff;
+       else
+               rxl = *rx_len;
+
        memset(rx_buf, 0, *rx_len);
 
        switch (frametype) {
@@ -664,6 +947,12 @@ rc632_iso14443ab_transceive(struct rfid_asic_handle *handle,
                channel_red = RC632_CR_PARITY_ENABLE|RC632_CR_PARITY_ODD;
                break;
 #endif
+       case RFID_15693_FRAME:
+               channel_red = RC632_CR_CRC3309 | RC632_CR_RX_CRC_ENABLE
+                               | RC632_CR_TX_CRC_ENABLE;
+               break;
+       case RFID_15693_FRAME_ICODE1:
+               /* FIXME: implement */
        default:
                return -EINVAL;
                break;
@@ -672,8 +961,8 @@ rc632_iso14443ab_transceive(struct rfid_asic_handle *handle,
                              channel_red);
        if (ret < 0)
                return ret;
-
-       ret = rc632_transceive(handle, tx_buf, tx_len, rx_buf, &rxl, 0x32, 0);
+       DEBUGP("tx_len=%u\n",tx_len);
+       ret = rc632_transceive(handle, tx_buf, tx_len, rx_buf, &rxl, timeout, 0);
        *rx_len = rxl;
        if (ret < 0)
                return ret;
@@ -691,7 +980,7 @@ rc632_iso14443a_transceive_acf(struct rfid_asic_handle *handle,
        int ret;
        u_int8_t rx_buf[64];
        u_int8_t rx_len = sizeof(rx_buf);
-       u_int8_t rx_align = 0, tx_last_bits, tx_bytes;
+       u_int8_t rx_align = 0, tx_last_bits, tx_bytes, tx_bytes_total;
        u_int8_t boc;
        u_int8_t error_flag;
        *bit_of_col = ISO14443A_BITOFCOL_NONE;
@@ -715,14 +1004,14 @@ rc632_iso14443a_transceive_acf(struct rfid_asic_handle *handle,
        if (ret < 0)
                return ret;
 
-       tx_last_bits = acf->nvb & 0x0f; /* lower nibble indicates bits */
-       tx_bytes = acf->nvb >> 4;
+       tx_last_bits = acf->nvb & 0x07; /* lower nibble indicates bits */
+       tx_bytes = ( acf->nvb >> 4 ) & 0x07;
        if (tx_last_bits) {
-               tx_bytes++;
-               rx_align = (tx_last_bits+1) % 8;/* rx frame complements tx */
+               tx_bytes_total = tx_bytes+1;
+               rx_align = tx_last_bits & 0x07; /* rx frame complements tx */
        }
-
-       //rx_align = 8 - tx_last_bits;/* rx frame complements tx */
+       else
+               tx_bytes_total = tx_bytes;
 
        /* set RxAlign and TxLastBits*/
        ret = rc632_reg_write(handle, RC632_REG_BIT_FRAMING,
@@ -730,7 +1019,7 @@ rc632_iso14443a_transceive_acf(struct rfid_asic_handle *handle,
        if (ret < 0)
                return ret;
 
-       ret = rc632_transceive(handle, (u_int8_t *)acf, tx_bytes,
+       ret = rc632_transceive(handle, (u_int8_t *)acf, tx_bytes_total,
                                rx_buf, &rx_len, 0x32, 0);
        if (ret < 0)
                return ret;
@@ -739,8 +1028,10 @@ rc632_iso14443a_transceive_acf(struct rfid_asic_handle *handle,
        acf->uid_bits[tx_bytes-2] = (
                  (acf->uid_bits[tx_bytes-2] & (0xff >> (8-tx_last_bits)))
                | rx_buf[0]);
+       
        /* copy the rest */
-       memcpy(&acf->uid_bits[tx_bytes+1-2], &rx_buf[1], rx_len-1);
+       if (rx_len)
+               memcpy(&acf->uid_bits[tx_bytes-1], &rx_buf[1], rx_len-1);
 
        /* determine whether there was a collission */
        ret = rc632_reg_read(handle, RC632_REG_ERROR_FLAG, &error_flag);
@@ -761,6 +1052,138 @@ rc632_iso14443a_transceive_acf(struct rfid_asic_handle *handle,
        return 0;
 }
 
+static void uuid_reversecpy(unsigned char* out, unsigned char* in, int len)
+{
+       int i = 0;
+       while (len > 0) {
+               out[i] = in[len];
+               len--;
+               i++;
+       }
+}
+
+
+static int
+rc632_iso15693_transceive_ac(struct rfid_asic_handle *handle,
+                            struct iso15693_anticol_cmd *acf,
+                            unsigned char uuid[ISO15693_UID_LEN],
+                            char *bit_of_col)
+{
+       u_int8_t boc;
+       u_int8_t error_flag, tmp;
+       u_int8_t rx_len;
+
+       int ret, tx_len, mask_len_bytes;
+
+       struct iso15693_request_inventory {
+               struct iso15693_request head;
+               unsigned char mask_length;
+               /* mask_value[0] + (maybe crc[2]) */
+               unsigned char data[ISO15693_UID_LEN];
+       } req;
+
+       struct {
+               struct iso15693_response head;
+               unsigned char dsfid;
+               unsigned char uuid[ISO15693_UID_LEN];
+       } rx_buf;
+
+       memset(uuid, 0, ISO15693_UID_LEN);
+
+       *bit_of_col = 0;
+       rx_len = sizeof(rx_buf);
+       mask_len_bytes = (acf->mask_len % 8) ? acf->mask_len/8+1 : acf->mask_len/8;
+
+
+       if (acf->current_slot == 0) {
+               /* first call: transmit Inventory frame */
+               DEBUGP("first_frame\n");
+               req.head.command = ISO15693_CMD_INVENTORY;
+               req.head.flags = (acf->flags & 0xf0)
+                                | RFID_15693_F_INV_TABLE_5
+                                | RFID_15693_F_RATE_HIGH;
+                                //| RFID_15693_F_SUBC_TWO | RFID_15693_F_RATE_HIGH;
+               req.mask_length = acf->mask_len;
+               memset(req.data, 0, ISO15693_UID_LEN);
+               memcpy(req.data, acf->mask_bits, mask_len_bytes);
+
+               tx_len = sizeof(struct iso15693_request) + 1 + mask_len_bytes;
+
+               ret = rc632_transceive(handle, (u_int8_t *)&req, tx_len,
+                                       (u_int8_t *)&rx_buf, &rx_len, 10, 0);
+               acf->current_slot = 1;
+               DEBUGP("rc632_transceive ret: %d rx_len: %d\n",ret,rx_len);
+               /* if ((ret < 0)&&(ret != -ETIMEDOUT))
+                       return ret;     */
+
+       } else {
+               /* second++ call: end timeslot with EOFpulse and read */
+               DEBUGP("second++_frame\n");
+               if ((acf->current_slot > 16) ||
+                   ((acf->flags & RFID_15693_F5_NSLOTS_1 == 0)
+                                       && (acf->current_slot > 1))) {
+
+                       memset(uuid, 0, ISO15693_UID_LEN);
+                       return -1;
+               }
+
+               /* reset EOF-pulse-bit to 0 */
+               ret = rc632_clear_bits(handle, RC632_REG_CODER_CONTROL,
+                                      RC632_CDRCTRL_15693_EOF_PULSE);
+               usleep(50);
+               /* generate EOF pulse */
+               ret = rc632_set_bits(handle, RC632_REG_CODER_CONTROL,
+                                    RC632_CDRCTRL_15693_EOF_PULSE);
+               if (ret < 0)
+                       return ret;
+               // DEBUGP("waiting for EOF pulse\n");
+               // ret = rc632_wait_idle(handle, 10); //wait for idle
+
+               rx_len = sizeof(rx_buf);
+               ret = rc632_receive(handle, (u_int8_t*)&rx_buf, &rx_len, 50);
+               DEBUGP("rc632_receive ret: %d rx_len: %d\n", ret, rx_len);
+               acf->current_slot++;
+
+               /* if ((ret < 0)&&(ret != -ETIMEDOUT))
+                       return ret; */
+       }
+
+       rc632_reg_read(handle, RC632_REG_PRIMARY_STATUS, &tmp);
+       DEBUGP_STATUS_FLAG(tmp);
+
+       if (ret == -ETIMEDOUT) {
+               /* no VICC answer in this timeslot*/
+               memset(uuid, 0, ISO15693_UID_LEN);
+               return -ETIMEDOUT;
+       } else {
+               /* determine whether there was a collission */
+               ret = rc632_reg_read(handle, RC632_REG_ERROR_FLAG, &error_flag);
+               DEBUGP_ERROR_FLAG(error_flag);
+               if (ret < 0)
+                       return ret;
+
+               if (error_flag & RC632_ERR_FLAG_COL_ERR) {
+                       /* retrieve bit of collission */
+                       ret = rc632_reg_read(handle, RC632_REG_COLL_POS, &boc);
+                       if (ret < 0)
+                               return ret;
+                       *bit_of_col = boc;
+                       memcpy(uuid, rx_buf.uuid, ISO15693_UID_LEN);
+                       // uuid_reversecpy(uuid, rx_buf.uuid, ISO15693_UID_LEN);
+                       DEBUGP("Collision in slot %d bit %d\n",
+                               acf->current_slot,boc);
+                       return -ECOLLISION;
+               } else {
+                       /* no collision-> retrieve uuid */
+                       DEBUGP("no collision in slot %d\n", acf->current_slot);
+                       memcpy(uuid, rx_buf.uuid, ISO15693_UID_LEN);
+                       //uuid_reversecpy(uuid, rx_buf.uuid, ISO15693_UID_LEN);
+               }
+       } 
+
+       return 0;
+}
+
 enum rc632_rate {
        RC632_RATE_106  = 0x00,
        RC632_RATE_212  = 0x01,
@@ -827,8 +1250,7 @@ static struct tx_config tx_configs[] = {
 };
 
 static int rc632_iso14443a_set_speed(struct rfid_asic_handle *handle,
-                                    unsigned int tx,
-                                    u_int8_t rate)
+                                    unsigned int tx, unsigned int rate)
 {
        int rc;
        u_int8_t reg;
@@ -886,11 +1308,12 @@ static int rc632_iso14443a_set_speed(struct rfid_asic_handle *handle,
 static int rc632_iso14443b_init(struct rfid_asic_handle *handle)
 {
        int ret;
-
-       // FIXME: some FIFO work
+       ENTER();
+       /* FIXME: some FIFO work */
        
        /* flush fifo (our way) */
-       ret = rc632_reg_write(handle, RC632_REG_CONTROL, 0x01);
+       ret = rc632_reg_write(handle, RC632_REG_CONTROL,
+                             RC632_CONTROL_FIFO_FLUSH);
        if (ret < 0)
                return ret;
 
@@ -991,170 +1414,201 @@ static int rc632_iso14443b_init(struct rfid_asic_handle *handle)
        return 0;
 }
 
-static int
-rc632_iso15693_init(struct rfid_asic_handle *h)
-{
-       int ret;
-
-       ret = rc632_reg_write(h, RC632_REG_TX_CONTROL,
-                                               (RC632_TXCTRL_MOD_SRC_INT |
-                                                RC632_TXCTRL_TX2_INV |
-                                                RC632_TXCTRL_TX2_RF_EN |
-                                                RC632_TXCTRL_TX1_RF_EN));
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_CW_CONDUCTANCE, 0x3f);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_MOD_CONDUCTANCE, 0x03);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_CODER_CONTROL,
-                                               (RC632_CDRCTRL_RATE_15693 |
-                                                0x03)); /* FIXME */
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_MOD_WIDTH, 0x3f);
-       if (ret < 0)
-               return ret;
-       
-       ret = rc632_reg_write(h, RC632_REG_MOD_WIDTH_SOF, 0x3f);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_TYPE_B_FRAMING, 0x00);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_RX_CONTROL1, 
-                                               (RC632_RXCTRL1_SUBCP_16 |
-                                                RC632_RXCTRL1_ISO15693 |
-                                                RC632_RXCTRL1_GAIN_35DB));
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_DECODER_CONTROL,
-                                               (RC632_DECCTRL_RXFR_15693 |
-                                                RC632_DECCTRL_RX_INVERT));
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_BIT_PHASE, 0xe0);
-       if (ret < 0)
-               return ret;
+struct register_file {
+       u_int8_t reg;
+       u_int8_t val;
+};
 
-       ret = rc632_reg_write(h, RC632_REG_RX_THRESHOLD, 0xff);
-       if (ret < 0)
-               return ret;
+/* Register file for ISO15693 standard */
+static struct register_file iso15693_fast_script[] = {
+       {
+               .reg    = RC632_REG_TX_CONTROL,
+               .val    = RC632_TXCTRL_MOD_SRC_INT |
+                         RC632_TXCTRL_TX2_INV |
+                         RC632_TXCTRL_TX2_RF_EN |
+                         RC632_TXCTRL_TX1_RF_EN,
+       }, {
+               .reg    = RC632_REG_CW_CONDUCTANCE,
+               .val    = 0x3f,
+       }, {
+               .reg    = RC632_REG_MOD_CONDUCTANCE,
+               /* FIXME: nxp default for icode1/15693: 0x05 */
+               //.val  = 0x02,
+               .val    = 0x21, /* omnikey */
+       }, {
+               .reg    = RC632_REG_CODER_CONTROL,
+               .val    = RC632_CDRCTRL_TXCD_15693_FAST |
+                         RC632_CDRCTRL_RATE_15693,
+       }, {
+               .reg    = RC632_REG_MOD_WIDTH,
+               .val    = 0x3f,
+       }, {
+               .reg    = RC632_REG_MOD_WIDTH_SOF,
+               .val    = 0x3f,
+       }, {
+               .reg    = RC632_REG_TYPE_B_FRAMING,
+               .val    = 0x00,
+       }, {
+               .reg    = RC632_REG_RX_CONTROL1,
+               .val    = RC632_RXCTRL1_ISO15693 |
+                         RC632_RXCTRL1_SUBCP_16 |
+                         RC632_RXCTRL1_GAIN_35DB,
+       }, {
+               /* FIXME: this should always be the case */
+               .reg    = RC632_REG_RX_CONTROL2,
+               .val    = RC632_RXCTRL2_DECSRC_INT,
+       }, {
+               .reg    = RC632_REG_DECODER_CONTROL,
+               .val    = RC632_DECCTRL_MANCHESTER |
+                         RC632_DECCTRL_RX_INVERT |
+                         RC632_DECCTRL_ZEROAFTERCOL |
+                         RC632_DECCTRL_RXFR_15693,
+       }, {
+               .reg    = RC632_REG_BIT_PHASE,
+               /* FIXME: nxp default for icode1/15693: 0x54 */
+               //.val  = 0x52,
+               .val    = 0xd0, /* omnikey */
+       }, {
+               .reg    = RC632_REG_RX_THRESHOLD,
+               /* FIXME: nxp default for icode1/15693: 0x68 */
+               //.val  = 0x66,
+               .val    = 0xed,
+       }, {
+               .reg    = RC632_REG_BPSK_DEM_CONTROL,
+               .val    = 0x00,
+       }, {
+               .reg    = RC632_REG_CHANNEL_REDUNDANCY,
+               .val    = RC632_CR_RX_CRC_ENABLE |
+                         RC632_CR_TX_CRC_ENABLE |
+                         RC632_CR_CRC3309,
+       }, {
+               .reg    = RC632_REG_CRC_PRESET_LSB,
+               .val    = 0xff,
+       }, {
+               .reg    = RC632_REG_CRC_PRESET_MSB,
+               .val    = 0xff,
+       },
+};
 
-       ret = rc632_reg_write(h, RC632_REG_BPSK_DEM_CONTROL, 0x00);
-       if (ret < 0)
-               return ret;
+/* Register file for I*Code standard */
+static struct register_file icode1_std_script[] = {
+       {
+               .reg    = RC632_REG_TX_CONTROL,
+               .val    = RC632_TXCTRL_MOD_SRC_INT |
+                         RC632_TXCTRL_TX2_INV |
+                         RC632_TXCTRL_TX2_RF_EN |
+                         RC632_TXCTRL_TX1_RF_EN,
+       }, {
+               .reg    = RC632_REG_CW_CONDUCTANCE,
+               .val    = 0x3f,
+       }, {
+               .reg    = RC632_REG_MOD_CONDUCTANCE,
+               /* FIXME: nxp default for icode1/15693: 0x05 */
+               .val    = 0x02,
+       }, {
+               .reg    = RC632_REG_CODER_CONTROL,
+               .val    = RC632_CDRCTRL_TXCD_ICODE_STD |
+                         RC632_CDRCTRL_RATE_15693,
+       }, {
+               .reg    = RC632_REG_MOD_WIDTH,
+               .val    = 0x3f,
+       }, {
+               .reg    = RC632_REG_MOD_WIDTH_SOF,
+               .val    = 0x3f,
+       }, {
+               .reg    = RC632_REG_TYPE_B_FRAMING,
+               .val    = 0x00,
+       }, {
+               .reg    = RC632_REG_RX_CONTROL1,
+               .val    = RC632_RXCTRL1_ISO15693 |
+                         RC632_RXCTRL1_SUBCP_16 |
+                         RC632_RXCTRL1_GAIN_35DB,
+       }, {
+               /* FIXME: this should always be the case */
+               .reg    = RC632_REG_RX_CONTROL2,
+               .val    = RC632_RXCTRL2_DECSRC_INT,
+       }, {
+               .reg    = RC632_REG_DECODER_CONTROL,
+               .val    = RC632_DECCTRL_MANCHESTER |
+                         RC632_DECCTRL_RXFR_ICODE,
+       }, {
+               .reg    = RC632_REG_BIT_PHASE,
+               /* FIXME: nxp default for icode1/15693: 0x54 */
+               .val    = 0x52,
+       }, {
+               .reg    = RC632_REG_RX_THRESHOLD,
+               /* FIXME: nxp default for icode1/15693: 0x68 */
+               .val    = 0x66,
+       }, {
+               .reg    = RC632_REG_BPSK_DEM_CONTROL,
+               .val    = 0x00,
+       }, {
+               .reg    = RC632_REG_CHANNEL_REDUNDANCY,
+               /* 16bit CRC, no parity, not CRC3309 */
+               .val    = RC632_CR_RX_CRC_ENABLE |
+                         RC632_CR_TX_CRC_ENABLE,
+       }, {
+               .reg    = RC632_REG_CRC_PRESET_LSB,
+               .val    = 0xfe,
+       }, {
+               .reg    = RC632_REG_CRC_PRESET_MSB,
+               .val    = 0xff,
+       }
+};
 
-       ret = rc632_reg_write(h, RC632_REG_RX_CONTROL2,
-                                               (RC632_RXCTRL2_AUTO_PD |
-                                                RC632_RXCTRL2_DECSRC_INT));
-       if (ret < 0)
-               return ret;
+/* incremental changes on top of icode1_std_script */
+static struct register_file icode1_fast_patch[] = {
+       {
+               .reg    = RC632_REG_CODER_CONTROL,
+               .val    = RC632_CDRCTRL_TXCD_ICODE_FAST |
+                         RC632_CDRCTRL_RATE_ICODE_FAST,
+       }, {
+               .reg    = RC632_REG_MOD_WIDTH_SOF,
+               .val    = 0x73, /* 18.88uS */
+       },
+};
 
-       ret = rc632_reg_write(h, RC632_REG_CHANNEL_REDUNDANCY,
-                                               (RC632_CR_CRC3309 |
-                                                RC632_CR_RX_CRC_ENABLE |
-                                                RC632_CR_TX_CRC_ENABLE));
-       if (ret < 0)
-               return ret;
+static int
+rc632_iso15693_init(struct rfid_asic_handle *h)
+{
+       int ret, i;
+       ENTER();
 
-       ret = rc632_reg_write(h, RC632_REG_CRC_PRESET_LSB, 0xff);
-       if (ret < 0)
-               return ret;
+       /* flush fifo (our way) */
+       ret = rc632_reg_write(h, RC632_REG_CONTROL,
+                             RC632_CONTROL_FIFO_FLUSH);
 
-       ret = rc632_reg_write(h, RC632_REG_CRC_PRESET_MSB, 0xff);
-       if (ret < 0)
-               return ret;
+       for (i = 0; i < ARRAY_SIZE(iso15693_fast_script); i++) {
+               ret = rc632_reg_write(h, iso15693_fast_script[i].reg,
+                                     iso15693_fast_script[i].val);
+               if (ret < 0)
+                       return ret;
+       }
 
        return 0;
 }
 
 static int
-rc632_iso15693_icode_init(struct rfid_asic_handle *h)
+rc632_iso15693_icode1_init(struct rfid_asic_handle *h, int fast)
 {
        int ret;
+       int i;
 
-       ret = rc632_reg_write(h, RC632_REG_TX_CONTROL,
-                                               (RC632_TXCTRL_MOD_SRC_INT |
-                                                RC632_TXCTRL_TX2_INV |
-                                                RC632_TXCTRL_TX2_RF_EN |
-                                                RC632_TXCTRL_TX1_RF_EN));
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_CW_CONDUCTANCE, 0x3f);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_MOD_CONDUCTANCE, 0x02);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_CODER_CONTROL, 0x2c);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_MOD_WIDTH, 0x3f);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_MOD_WIDTH_SOF, 0x3f);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_MOD_WIDTH_SOF, 0x3f);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_TYPE_B_FRAMING, 0x00);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_RX_CONTROL1, 0x8b); /* FIXME */
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_DECODER_CONTROL, 0x00);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_BIT_PHASE, 0x52);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_RX_THRESHOLD, 0x66);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_BPSK_DEM_CONTROL, 0x00);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_RX_CONTROL2, 
-                                               RC632_RXCTRL2_DECSRC_INT);
-       if (ret < 0)
-               return ret;
-
-       ret = rc632_reg_write(h, RC632_REG_CHANNEL_REDUNDANCY,
-                                               (RC632_CR_RX_CRC_ENABLE |
-                                                RC632_CR_TX_CRC_ENABLE));
-       ret = rc632_reg_write(h, RC632_REG_CRC_PRESET_LSB, 0xfe);
-       if (ret < 0)
-               return ret;
+       for (i = 0; i < ARRAY_SIZE(icode1_std_script); i++) {
+               ret = rc632_reg_write(h, icode1_std_script[i].reg,
+                                     icode1_std_script[i].val);
+               if (ret < 0)
+                       return ret;
+       }
 
-       ret = rc632_reg_write(h, RC632_REG_CRC_PRESET_MSB, 0xff);
-       if (ret < 0)
-               return ret;
+       if (fast) {
+               for (i = 0; i < ARRAY_SIZE(icode1_fast_patch); i++) {
+                       ret = rc632_reg_write(h, icode1_fast_patch[i].reg,
+                                             icode1_fast_patch[i].val);
+                       if (ret < 0)
+                               return ret;
+               }
+       }
 
        return 0;
 }
@@ -1278,6 +1732,11 @@ rc632_mifare_set_key(struct rfid_asic_handle *h, const u_int8_t *key)
        if (ret < 0)
                return ret;
 
+       /* Terminate probably running command */
+       ret = rc632_reg_write(h, RC632_REG_COMMAND, RC632_CMD_IDLE);    
+       if (ret < 0)
+               return ret;
+
        ret = rc632_fifo_write(h, RFID_MIFARE_KEY_CODED_LEN, coded_key, 0x03);
        if (ret < 0)
                return ret;
@@ -1308,8 +1767,10 @@ rc632_mifare_auth(struct rfid_asic_handle *h, u_int8_t cmd, u_int32_t serno,
        struct mifare_authcmd acmd;
        u_int8_t reg;
 
-       if (cmd != RFID_CMD_MIFARE_AUTH1A && cmd != RFID_CMD_MIFARE_AUTH1B)
+       if (cmd != RFID_CMD_MIFARE_AUTH1A && cmd != RFID_CMD_MIFARE_AUTH1B) {
+               DEBUGP("invalid auth command\n");
                return -EINVAL;
+       }
 
        /* Initialize acmd */
        acmd.block_address = block & 0xff;
@@ -1317,9 +1778,16 @@ rc632_mifare_auth(struct rfid_asic_handle *h, u_int8_t cmd, u_int32_t serno,
        //acmd.serno = htonl(serno);
        acmd.serno = serno;
 
+#if 1
        /* Clear Rx CRC */
        ret = rc632_clear_bits(h, RC632_REG_CHANNEL_REDUNDANCY,
                                RC632_CR_RX_CRC_ENABLE);
+#else
+       /* Clear Rx CRC, Set Tx CRC and Odd Parity */
+       ret = rc632_reg_write(h, RC632_REG_CHANNEL_REDUNDANCY,
+                               RC632_CR_TX_CRC_ENABLE | RC632_CR_PARITY_ODD |
+                               RC632_CR_PARITY_ENABLE);
+#endif
        if (ret < 0)
                return ret;
 
@@ -1329,8 +1797,10 @@ rc632_mifare_auth(struct rfid_asic_handle *h, u_int8_t cmd, u_int32_t serno,
                return ret;
 
        ret = rc632_reg_write(h, RC632_REG_COMMAND, RC632_CMD_AUTHENT1);
-       if (ret < 0)
+       if (ret < 0) {
+               DEBUGP("error during AUTHENT1");
                return ret;
+       }
 
        /* Wait until transmitter is idle */
        ret = rc632_wait_idle(h, RC632_TMO_AUTH1);
@@ -1340,8 +1810,10 @@ rc632_mifare_auth(struct rfid_asic_handle *h, u_int8_t cmd, u_int32_t serno,
        ret = rc632_reg_read(h, RC632_REG_SECONDARY_STATUS, &reg);
        if (ret < 0)
                return ret;
-       if (reg & 0x07)
+       if (reg & 0x07) {
+               DEBUGP("bitframe?");
                return -EIO;
+       }
 
        /* Clear Tx CRC */
        ret = rc632_clear_bits(h, RC632_REG_CHANNEL_REDUNDANCY,
@@ -1364,11 +1836,12 @@ rc632_mifare_auth(struct rfid_asic_handle *h, u_int8_t cmd, u_int32_t serno,
        if (ret < 0)
                return ret;
 
-       if (!(reg & RC632_CONTROL_CRYPTO1_ON))
+       if (!(reg & RC632_CONTROL_CRYPTO1_ON)) {
+               DEBUGP("authentication not successful");
                return -EACCES;
+       }
 
        return 0;
-
 }
 
 /* transceive regular frame */
@@ -1406,15 +1879,14 @@ rc632_mifare_transceive(struct rfid_asic_handle *handle,
        return 0; 
 }
 
-struct rfid_asic rc632 = {
+const struct rfid_asic rc632 = {
        .name   = "Philips CL RC632",
        .fc     = ISO14443_FREQ_CARRIER,
        .priv.rc632 = {
                .fn = {
                        .power_up = &rc632_power_up,
                        .power_down = &rc632_power_down,
-                       .turn_on_rf = &rc632_turn_on_rf,
-                       .turn_off_rf = &rc632_turn_off_rf,
+                       .rf_power = &rc632_rf_power,
                        .transceive = &rc632_iso14443ab_transceive,
                        .iso14443a = {
                                .init = &rc632_iso14443a_init,
@@ -1427,6 +1899,7 @@ struct rfid_asic rc632 = {
                        },
                        .iso15693 = {
                                .init = &rc632_iso15693_init,
+                               .transceive_ac = &rc632_iso15693_transceive_ac,
                        },
                        .mifare_classic = {
                                .setkey = &rc632_mifare_set_key,