X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;ds=sidebyside;f=t%2FDates.t;h=148bb3e8f9d76c009aa752a1eab672575120c3c9;hb=d059079caf60e1c6796e7a49dc64a900f1238058;hp=21e285b484e1eafe5385240d211fcffba8c1928d;hpb=cd967a2db1f4aca990756ed549f42069189296ce;p=koha.git diff --git a/t/Dates.t b/t/Dates.t old mode 100755 new mode 100644 index 21e285b484..148bb3e8f9 --- a/t/Dates.t +++ b/t/Dates.t @@ -1,49 +1,113 @@ -#!/bin/perl +#!/usr/bin/perl + +use strict; +use warnings; + +use Test::More tests => 327; -use Test::More tests => 83; BEGIN { - use_ok('C4::Dates'); + use FindBin; + use lib $FindBin::Bin; + use_ok( 'C4::Dates', qw(format_date format_date_in_iso) ); +} + +sub describe ($$) { + my $front = sprintf( "%-25s", shift ); + my $tail = shift || 'FAILED'; + return "$front : $tail"; } -use_ok( CGI::Carp ); -CGI::Carp->fatalsToBrowser(0); +# Keep the number of test elements per [array] equal or the predicted number of tests +# needs to be different for different (fake) sysprefs. my %thash = ( - iso => ['2001-01-01','1989-09-21'], - metric => ["01-01-2001",'21-09-1989'], - us => ["01-01-2001",'09-21-1989'], - sql => ['20010101 010101', - '19890921 143907' ], + iso => [ '2001-1-1', '1989-9-21', '1952-1-0', '1989-9-21 13:46:02', '2001-01-01', '1989-09-21', '1952-01-00', '1989-09-21 13:46:02' ], + metric => [ "1-1-2001", '21-9-1989', '00-1-1952', '21-9-1989 13:46:02', "01-01-2001", '21-09-1989', '00-01-1952', '21-09-1989 13:46:02' ], + us => [ "01-01-2001", '09-21-1989', '01-00-1952', '09-21-1989 13:46:02' ], + sql => [ '20010101 010101', '19890921 143907', '19520100 000000', '19890921 134602' ], + rfc822 => [ 'Wed, 02 Oct 2002 15:00:00 +0200', 'Fri, 10 Sep 2010 08:00:00 +0500' ], ); -my @formats = sort keys %thash; -diag "\nNote: CGI::Carp may throw an initial error here. Ignore that.\n"; -diag "Testing " . scalar(@formats) . " formats.\nTesting no input:\n"; -my ($today, $today0, $val, $re); -ok($today0 = C4::Dates->today(), "(default) CLASS ->today : $today0" ); +my ( $date, $format, $today, $today0, $val, $re, $syspref ); +my @formats = sort keys %thash; +my $fake_syspref_default = 'us'; +my $fake_syspref = (@ARGV) ? shift : $ENV{KOHA_TEST_DATE_FORMAT}; +if ($fake_syspref) { + diag "You asked for date format '$fake_syspref'."; + unless ( scalar grep { /^$fake_syspref$/ } @formats ) { + diag "Warning: Unkown date format '$fake_syspref', reverting to default '$fake_syspref_default'."; + $fake_syspref = $fake_syspref_default; + } +} +$fake_syspref or $fake_syspref = $fake_syspref_default; +$C4::Dates::prefformat = $fake_syspref; # So Dates doesn't have to ask the DB anything. + +diag <new->format(), "Your system preference is: $syspref" ); +print "\n"; +foreach ( @{ $thash{'iso'} } ) { + ok( $val = format_date($_), "format_date('$_'): $val" ); +} +foreach ( @{ $thash{$syspref} } ) { + ok( $val = format_date_in_iso($_), "format_date_in_iso('$_'): $val" ); +} +ok( $today0 = C4::Dates->today(), "(default) CLASS ->today : $today0" ); +diag "\nTesting " . scalar(@formats) . " formats.\nTesting no input (defaults):\n"; +print "\n"; foreach (@formats) { - my $pre = sprintf '(%-6s)', $_; - ok($date = C4::Dates->new(), "$pre Date Creation : new()"); - ok($_ eq ($format = $date->format($_)), "$pre format($_) : $format" ); - ok($today = $date->output(), "$pre output() : $today" ); - ok($today = $date->today(), "$pre object->today : $today" ); - print "\n"; + my $pre = sprintf '(%-6s)', $_; + ok( $date = C4::Dates->new(), "$pre Date Creation : new()" ); + ok( $_ eq ( $format = $date->format($_) ), "$pre format($_) : " . ( $format || 'FAILED' ) ); + ok( $format = $date->visual(), "$pre visual() : " . ( $format || 'FAILED' ) ); + ok( $today = $date->output(), "$pre output() : " . ( $today || 'FAILED' ) ); + ok( $today = $date->today(), "$pre object->today : " . ( $today || 'FAILED' ) ); + print "\n"; } -foreach my $format (@formats) { - my $pre = sprintf '(%-6s)', $format; - foreach my $testval (@{$thash{ $format }}) { - ok($date = C4::Dates->new($testval,$format), "$pre Date Creation : new('$testval','$format')"); - ok($re = $date->regexp, "$pre has regexp()" ); - ok($val = $date->output(), "$pre output() : $val" ); - foreach (grep {!/$format/} @formats) { - ok($today = $date->output($_), "$pre output(" . sprintf("%8s","'$_'") . "): $today"); - } - ok($today = $date->today(), "$pre object->today : $today" ); - # ok($today == ($today = C4::Dates->today()), "$pre CLASS ->today : $today" ); - ok($val = $date->output(), "$pre output() : $val" ); - # ok($format eq ($format = $date->format()), "$pre format() : $format" ); - print "\n"; - } +diag "\nTesting with valid inputs:\n"; +foreach $format (@formats) { + my $pre = sprintf '(%-6s)', $format; + foreach my $testval ( @{ $thash{$format} } ) { + ok( $date = C4::Dates->new( $testval, $format ), "$pre Date Creation : new('$testval','$format')" ); + ok( $re = $date->regexp, "$pre has regexp()" ); + ok( $testval =~ /^$re$/, "$pre has regexp() match $testval" ); + ok( $val = $date->output(), describe( "$pre output()", $val ) ); + SKIP: { + skip( "special case with explicit regexp('syspref') because $format isn't $syspref", 1 ) unless ( $format eq $syspref ); + my $re_syspref = C4::Dates->regexp('syspref'); + ok( $testval =~ /^$re_syspref$/, "$pre has regexp('syspref') match $testval" ); + } + foreach ( grep { !/$format/ } @formats ) { + ok( $today = $date->output($_), describe( sprintf( "$pre output(%8s)", "'$_'" ), $today ) ); + } + ok( $today = $date->today(), describe( "$pre object->today", $today ) ); + + # ok($today == ($today = C4::Dates->today()), "$pre CLASS ->today : $today" ); + ok( $val = $date->output(), describe( "$pre output()", $val ) ); + + # ok($format eq ($format = $date->format()), "$pre format() : $format" ); + print "\n"; + } } +diag "\nTesting object independence from class\n"; +my $in1 = '12/25/1952'; # us +my $in2 = '13/01/2001'; # metric +my $d1 = C4::Dates->new( $in1, 'us' ); +my $d2 = C4::Dates->new( $in2, 'metric' ); +my $out1 = $d1->output('iso'); +my $out2 = $d2->output('iso'); +ok( $out1 ne $out2, "subsequent constructors get different dataspace ($out1 != $out2)" ); diag "done.\n";