X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;ds=sidebyside;f=tools%2Fpicture-upload.pl;h=bfb233e6e25c97b540d86459d655f04291fa118c;hb=c7c2e9efbde273f2b77786316b7502a8847072bd;hp=a28f259001035fc259f384ff4ef67d549fdbb7a8;hpb=8ad2c7d7acc3cb0033426bd78928214a22ad9dd1;p=koha.git

diff --git a/tools/picture-upload.pl b/tools/picture-upload.pl
index a28f259001..bfb233e6e2 100755
--- a/tools/picture-upload.pl
+++ b/tools/picture-upload.pl
@@ -19,6 +19,9 @@
 #
 #
 
+#use strict;
+#use warnings; FIXME - Bug 2505
+
 use File::Temp;
 use File::Copy;
 use CGI;
@@ -55,7 +58,7 @@ $debug and warn "Params are: filetype=$filetype, cardnumber=$cardnumber, borrowe
 
 =head1 NAME
 
-picture-upload.p. - Script for handling uploading of both single and bulk patronimages and importing them into the database.
+picture-upload.pl - Script for handling uploading of both single and bulk patronimages and importing them into the database.
 
 =head1 SYNOPSIS
 
@@ -75,7 +78,10 @@ my ( $total, $handled, @counts, $tempfile, $tfh );
 if ( ($op eq 'Upload') && $uploadfile ) {       # Case is important in these operational values as the template must use case to be visually pleasing!
     my $dirname = File::Temp::tempdir( CLEANUP => 1);
     $debug and warn "dirname = $dirname";
-    my $filesuffix = $1 if $uploadfilename =~ m/(\..+)$/i;
+    my $filesuffix;
+    if ( $uploadfilename =~ m/(\..+)$/i ) {
+        my $filesuffix = $1;
+    }
     ( $tfh, $tempfile ) = File::Temp::tempfile( SUFFIX => $filesuffix, UNLINK => 1 );
     $debug and warn "tempfile = $tempfile";
     my ( @directories, $errors );
@@ -92,7 +98,7 @@ if ( ($op eq 'Upload') && $uploadfile ) {       # Case is important in these ope
         }
         close $tfh;
         if ( $filetype eq 'zip' ) {
-            unless (system("unzip $tempfile -d $dirname") == 0) {
+            unless (system("unzip", $tempfile,  '-d', $dirname) == 0) {
                 $errors{'UZIPFAIL'} = $uploadfilename;
 	        $template->param( ERRORS => [ \%errors ] );
                 output_html_with_http_headers $input, $cookie, $template->output;   # This error is fatal to the import, so bail out here
@@ -210,7 +216,7 @@ sub handle_file {
         }
         $debug and warn "Source: $source";
         my $size = (stat($source))[7];
-            if ($size > 200000) {    # This check is necessary even with image resizing to avoid possible security/performance issues...
+            if ($size > 550000) {    # This check is necessary even with image resizing to avoid possible security/performance issues...
                 $filerrors{'OVRSIZ'} = 1;
                 push my @filerrors, \%filerrors;
                 push @{ $count{filenames} }, { filerrors => \@filerrors, source => $filename, cardnumber => $cardnumber };
@@ -251,8 +257,11 @@ sub handle_file {
 					undef $srcimage;    # This object can get big...
 				}
 				$debug and warn "Image is of mimetype $mimetype";
-				my $dberror = PutPatronImage($cardnumber,$mimetype, $imgfile) if $mimetype;
-				if ( !$dberror && $mimetype ) { # Errors from here on are fatal only to the import of a particular image, so don't bail, just note the error and keep going
+                my $dberror;
+                if ($mimetype) {
+                    $dberror = PutPatronImage( $cardnumber, $mimetype, $imgfile );
+                }
+                if ( !$dberror && $mimetype ) { # Errors from here on are fatal only to the import of a particular image, so don't bail, just note the error and keep going
 					$count{count}++;
 					push @{ $count{filenames} }, { source => $filename, cardnumber => $cardnumber };
 				} elsif ( $dberror ) {
@@ -293,8 +302,6 @@ sub handle_file {
     return (%count);
 }
 
-=back
-
 =head1 AUTHORS
 
 Original contributor(s) undocumented