X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=C4%2FAcquisition.pm;h=88f0c6dd36aa6d313865036d43f6b01d9c19b981;hb=aefcbc11c6e53276805130bf4eceace79551a952;hp=413d6a2ed2f5532c2f0ce8d91c6a43867aec42af;hpb=a4c279ac4e2f4a2dd724331b710b17474f44c22c;p=koha.git diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index 413d6a2ed2..88f0c6dd36 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -17,20 +17,31 @@ package C4::Acquisition; # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, # Suite 330, Boston, MA 02111-1307 USA -# $Id$ use strict; -require Exporter; use C4::Context; -use C4::Date; +use C4::Debug; +use C4::Dates qw(format_date); use MARC::Record; use C4::Suggestions; use Time::localtime; use vars qw($VERSION @ISA @EXPORT); -# set the version for version checking -$VERSION = do { my @v = '$Revision$' =~ /\d+/g; shift(@v) . "." . join( "_", map { sprintf "%03d", $_ } @v ); }; +BEGIN { + # set the version for version checking + $VERSION = 3.01; + require Exporter; + @ISA = qw(Exporter); + @EXPORT = qw( + &GetBasket &NewBasket &CloseBasket + &GetPendingOrders &GetOrder &GetOrders + &GetOrderNumber &GetLateOrders &NewOrder &DelOrder + &SearchOrder &GetHistory &GetRecentAcqui + &ModOrder &ModReceiveOrder &ModOrderBiblioNumber + &GetParcels &GetParcel + ); +} # used in receiveorder subroutine # to provide library specific handling @@ -51,28 +62,8 @@ orders, basket and parcels. =head1 FUNCTIONS -=over 2 - -=cut - -@ISA = qw(Exporter); -@EXPORT = qw( - &GetBasket &GetBasketContent &NewBasket &CloseBasket - &GetPendingOrders &GetAllOrders - &GetOrder &GetLateOrders &NewOrder &DelOrder - &SearchOrder &GetHistory - &ModOrder &GetSingleOrder &ModReceiveOrder - &GetParcels &GetParcel -); - =head2 FUNCTIONS ABOUT BASKETS -=over 2 - -=cut - -#------------------------------------------------------------# - =head3 GetBasket =over 4 @@ -86,8 +77,6 @@ informations for a given basket returned as a hashref. =back -=back - =cut sub GetBasket { @@ -95,68 +84,16 @@ sub GetBasket { my $dbh = C4::Context->dbh; my $query = " SELECT aqbasket.*, - borrowers.firstname+' '+borrowers.surname AS authorisedbyname, - borrowers.branchcode AS branch + concat( b.firstname,' ',b.surname) AS authorisedbyname, + b.branchcode AS branch FROM aqbasket - LEFT JOIN borrowers ON aqbasket.authorisedby=borrowers.borrowernumber + LEFT JOIN borrowers b ON aqbasket.authorisedby=b.borrowernumber WHERE basketno=? "; my $sth=$dbh->prepare($query); $sth->execute($basketno); - return ( $sth->fetchrow_hashref ); -} - -#------------------------------------------------------------# - -=head3 GetBasketContent - -=over 4 - -@orders = &GetBasketContent($basketnumber, $orderby); - -Looks up the pending (non-cancelled) orders with the given basket -number. If C<$booksellerID> is non-empty, only orders from that seller -are returned. - -return : -C<&basket> returns a two-element array. C<@orders> is an array of -references-to-hash, whose keys are the fields from the aqorders, -biblio, and biblioitems tables in the Koha database. - -=back - -=cut - -sub GetBasketContent { - my ( $basketno, $orderby ) = @_; - my $dbh = C4::Context->dbh; - my $query =" - SELECT aqorderbreakdown.*, - biblio.*,biblioitems.*, - aqorders.*, - biblio.title - FROM aqorders,biblio,biblioitems - LEFT JOIN aqorderbreakdown ON - aqorders.ordernumber=aqorderbreakdown.ordernumber - WHERE basketno=? - AND biblio.biblionumber=aqorders.biblionumber - AND biblioitems.biblioitemnumber=aqorders.biblioitemnumber - AND (datecancellationprinted IS NULL OR datecancellationprinted='0000-00-00') - "; - - $orderby = "biblioitems.publishercode" unless $orderby; - $query .= " ORDER BY $orderby"; - my $sth = $dbh->prepare($query); - $sth->execute($basketno); - my @results; - - my $i=0; - # print $query; - while ( my $data = $sth->fetchrow_hashref ) { - $results[$i++] = $data; - } - $sth->finish; - return @results; + my $basket = $sth->fetchrow_hashref; + return ( $basket ); } #------------------------------------------------------------# @@ -219,12 +156,8 @@ sub CloseBasket { #------------------------------------------------------------# -=back - =head2 FUNCTIONS ABOUT ORDERS -=over 2 - =cut #------------------------------------------------------------# @@ -233,13 +166,15 @@ sub CloseBasket { =over 4 -$orders = &GetPendingOrders($booksellerid); +$orders = &GetPendingOrders($booksellerid, $grouped); Finds pending orders from the bookseller with the given ID. Ignores completed and cancelled orders. C<$orders> is a reference-to-array; each element is a reference-to-hash with the following fields: +C<$grouped> is a boolean that, if set to 1 will group all order lines of the same basket +in a single result line =over 2 @@ -261,60 +196,120 @@ Results are ordered from most to least recent. =cut sub GetPendingOrders { - my $supplierid = @_; + my ($supplierid,$grouped, $closed) = @_; my $dbh = C4::Context->dbh; my $strsth = " - SELECT count(*),authorisedby,creationdate,aqbasket.basketno, - closedate,surname,firstname,aqorders.title + SELECT ".($grouped?"count(*),":"")."aqbasket.basketno, + surname,firstname,aqorders.*, + aqbasket.closedate, aqbasket.creationdate FROM aqorders LEFT JOIN aqbasket ON aqbasket.basketno=aqorders.basketno LEFT JOIN borrowers ON aqbasket.authorisedby=borrowers.borrowernumber WHERE booksellerid=? - AND (quantity > quantityreceived OR quantityreceived is NULL) - AND datecancellationprinted IS NULL - AND (to_days(now())-to_days(closedate) < 180 OR closedate IS NULL) + AND datecancellationprinted IS NULL "; + if($closed){ + $strsth .= " + AND (quantity > quantityreceived OR quantityreceived is NULL) + AND closedate IS NOT NULL "; + }else{ + $strsth .= "AND (to_days(now())-to_days(closedate) < 180 OR closedate IS NULL)"; + } + ## FIXME Why 180 days ??? + my @query_params = ( $supplierid ); if ( C4::Context->preference("IndependantBranches") ) { my $userenv = C4::Context->userenv; if ( ($userenv) && ( $userenv->{flags} != 1 ) ) { - $strsth .= - " and (borrowers.branchcode = '" - . $userenv->{branch} - . "' or borrowers.branchcode ='')"; + $strsth .= " and (borrowers.branchcode = ? + or borrowers.branchcode = '')"; + push @query_params, $userenv->{branch}; } } - $strsth .= " group by basketno order by aqbasket.basketno"; + $strsth .= " group by aqbasket.basketno" if $grouped; + $strsth .= " order by aqbasket.basketno"; + my $sth = $dbh->prepare($strsth); - $sth->execute($supplierid); - my @results = (); + $sth->execute( @query_params ); + my $results = $sth->fetchall_arrayref({}); + $sth->finish; + return $results; +} + +#------------------------------------------------------------# + +=head3 GetOrders + +=over 4 + +@orders = &GetOrders($basketnumber, $orderby); + +Looks up the pending (non-cancelled) orders with the given basket +number. If C<$booksellerID> is non-empty, only orders from that seller +are returned. + +return : +C<&basket> returns a two-element array. C<@orders> is an array of +references-to-hash, whose keys are the fields from the aqorders, +biblio, and biblioitems tables in the Koha database. + +=back + +=cut + +sub GetOrders { + my ( $basketno, $orderby ) = @_; + my $dbh = C4::Context->dbh; + my $query =" + SELECT aqorderbreakdown.*, + biblio.*,biblioitems.*, + aqorders.*, + aqbookfund.bookfundname, + biblio.title + FROM aqorders + LEFT JOIN aqorderbreakdown ON aqorders.ordernumber=aqorderbreakdown.ordernumber + LEFT JOIN aqbookfund ON aqbookfund.bookfundid=aqorderbreakdown.bookfundid + LEFT JOIN biblio ON biblio.biblionumber=aqorders.biblionumber + LEFT JOIN biblioitems ON biblioitems.biblionumber=biblio.biblionumber + WHERE basketno=? + AND (datecancellationprinted IS NULL OR datecancellationprinted='0000-00-00') + "; + + $orderby = "biblioitems.publishercode,biblio.title" unless $orderby; + $query .= " ORDER BY $orderby"; + my $sth = $dbh->prepare($query); + $sth->execute($basketno); + my @results; + while ( my $data = $sth->fetchrow_hashref ) { - push( @results, $data ); + push @results, $data; } $sth->finish; - return \@results; + return @results; } #------------------------------------------------------------# -=head3 GetOrder +=head3 GetOrderNumber =over 4 -($order, $ordernumber) = &GetOrder($biblioitemnumber, $biblionumber); +$ordernumber = &GetOrderNumber($biblioitemnumber, $biblionumber); -Looks up the order with the given biblionumber and biblioitemnumber. +=back + +Looks up the ordernumber with the given biblionumber and biblioitemnumber. + +Returns the number of this order. + +=over 4 -Returns a two-element array. C<$ordernumber> is the order number. -C<$order> is a reference-to-hash describing the order; its keys are -fields from the biblio, biblioitems, aqorders, and aqorderbreakdown -tables of the Koha database. +=item C<$ordernumber> is the order number. =back =cut -# @_ = biblioitemnumber, biblionumber. -sub GetOrder { - my ( $bi, $bib ) = @_; +sub GetOrderNumber { + my ( $biblionumber,$biblioitemnumber ) = @_; my $dbh = C4::Context->dbh; my $query = " SELECT ordernumber @@ -323,23 +318,18 @@ sub GetOrder { AND biblioitemnumber=? "; my $sth = $dbh->prepare($query); - $sth->execute( $bib, $bi ); + $sth->execute( $biblionumber, $biblioitemnumber ); - # FIXME - Use fetchrow_array(), since we're only interested in the one - # value. - my $ordnum = $sth->fetchrow_hashref; - $sth->finish; - my $order = GetSingleOrder( $ordnum->{'ordernumber'} ); - return ( $order, $ordnum->{'ordernumber'} ); + return $sth->fetchrow; } #------------------------------------------------------------# -=head3 GetSingleOrder +=head3 GetOrder =over 4 -$order = &GetSingleOrder($ordernumber); +$order = &GetOrder($ordernumber); Looks up an order by order number. @@ -351,16 +341,17 @@ aqorderbreakdown tables of the Koha database. =cut -sub GetSingleOrder { +sub GetOrder { my ($ordnum) = @_; my $dbh = C4::Context->dbh; my $query = " - SELECT * - FROM biblio,biblioitems,aqorders + SELECT biblioitems.*, biblio.*, aqorderbreakdown.*, aqorders.* + FROM aqorders LEFT JOIN aqorderbreakdown ON aqorders.ordernumber=aqorderbreakdown.ordernumber + LEFT JOIN biblio on biblio.biblionumber=aqorders.biblionumber + LEFT JOIN biblioitems on biblioitems.biblionumber=aqorders.biblionumber WHERE aqorders.ordernumber=? - AND biblio.biblionumber=aqorders.biblionumber - AND biblioitems.biblioitemnumber=aqorders.biblioitemnumber + "; my $sth= $dbh->prepare($query); $sth->execute($ordnum); @@ -371,62 +362,6 @@ sub GetSingleOrder { #------------------------------------------------------------# -=head3 GetAllOrders - -=over 4 - -@results = &GetAllOrders($booksellerid); - -Looks up all of the pending orders from the supplier with the given -bookseller ID. Ignores cancelled and completed orders. - -C<@results> is an array of references-to-hash. The keys of each element are fields from -the aqorders, biblio, and biblioitems tables of the Koha database. - -C<@results> is sorted alphabetically by book title. - -=back - -=cut - -sub GetAllOrders { - - #gets all orders from a certain supplier, orders them alphabetically - my ($supplierid) = @_; - my $dbh = C4::Context->dbh; - my @results = (); - my $strsth = " - SELECT count(*),authorisedby,creationdate,aqbasket.basketno, - closedate,surname,firstname,aqorders.biblionumber,aqorders.title, aqorders.ordernumber - FROM aqorders - LEFT JOIN aqbasket ON aqbasket.basketno=aqorders.basketno - LEFT JOIN borrowers ON aqbasket.authorisedby=borrowers.borrowernumber - WHERE booksellerid=? - AND (quantity > quantityreceived OR quantityreceived IS NULL) - AND datecancellationprinted IS NULL - "; - - if ( C4::Context->preference("IndependantBranches") ) { - my $userenv = C4::Context->userenv; - if ( ($userenv) && ( $userenv->{flags} != 1 ) ) { - $strsth .= - " and (borrowers.branchcode = '" - . $userenv->{branch} - . "' or borrowers.branchcode ='')"; - } - } - $strsth .= " group by basketno order by aqbasket.basketno"; - my $sth = $dbh->prepare($strsth); - $sth->execute($supplierid); - while ( my $data = $sth->fetchrow_hashref ) { - push( @results, $data ); - } - $sth->finish; - return @results; -} - -#------------------------------------------------------------# - =head3 NewOrder =over 4 @@ -434,7 +369,7 @@ sub GetAllOrders { &NewOrder($basket, $biblionumber, $title, $quantity, $listprice, $booksellerid, $who, $notes, $bookfund, $biblioitemnumber, $rrp, $ecost, $gst, $budget, $unitprice, $subscription, - $booksellerinvoicenumber); + $booksellerinvoicenumber, $purchaseorder, $branchcode); Adds a new order to the database. Any argument that isn't described below is the new value of the field with the same name in the aqorders @@ -447,6 +382,8 @@ entry to the aqorderbreakdown table, with the order number just found, and the book fund ID of the newly-added order. C<$budget> is effectively ignored. + If it's undef (anything false) or the string 'now', the current day is used. + Else, the upcoming July 1st is used. C<$subscription> may be either "yes", or anything else for "no". @@ -460,7 +397,8 @@ sub NewOrder { $listprice, $booksellerid, $authorisedby, $notes, $bookfund, $bibitemnum, $rrp, $ecost, $gst, $budget, $cost, $sub, - $invoice, $sort1, $sort2 + $invoice, $sort1, $sort2, $purchaseorder, + $branchcode ) = @_; @@ -468,18 +406,18 @@ sub NewOrder { my $month = localtime->mon() + 1; # months starts at 0, add 1 if ( !$budget || $budget eq 'now' ) { - $budget = "now()"; + $budget = undef; } # if month is july or more, budget start is 1 jul, next year. elsif ( $month >= '7' ) { ++$year; # add 1 to year , coz its next year - $budget = "'$year-07-01'"; + $budget = "$year-07-01"; } else { # START OF NEW BUDGET, 1ST OF JULY, THIS YEAR - $budget = "'$year-07-01'"; + $budget = "$year-07-01"; } if ( $sub eq 'yes' ) { @@ -497,27 +435,30 @@ sub NewOrder { my $dbh = C4::Context->dbh; my $query = " INSERT INTO aqorders - ( biblionumber,title,basketno,quantity,listprice,notes, - biblioitemnumber,rrp,ecost,gst,unitprice,subscription,sort1,sort2,budgetdate,entrydate) - VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,$budget,now() ) + ( biblionumber, title, basketno, quantity, listprice, + notes, biblioitemnumber, rrp, ecost, gst, + unitprice, subscription, sort1, sort2, budgetdate, + entrydate, purchaseordernumber) + VALUES ( ?,?,?,?,?,?,?,?,?,?,?,?,?,?,COALESCE(?,NOW()),NOW(),? ) "; my $sth = $dbh->prepare($query); $sth->execute( $bibnum, $title, $basketno, $quantity, $listprice, $notes, $bibitemnum, $rrp, $ecost, $gst, - $cost, $sub, $sort1, $sort2 + $cost, $sub, $sort1, $sort2, $budget, + $purchaseorder ); $sth->finish; #get ordnum MYSQL dependant, but $dbh->last_insert_id returns null my $ordnum = $dbh->{'mysql_insertid'}; - my $query = " - INSERT INTO aqorderbreakdown (ordernumber,bookfundid) - VALUES (?,?) + $query = " + INSERT INTO aqorderbreakdown (ordernumber,bookfundid, branchcode) + VALUES (?,?,?) "; $sth = $dbh->prepare($query); - $sth->execute( $ordnum, $bookfund ); + $sth->execute( $ordnum, $bookfund, $branchcode ); $sth->finish; return ( $basketno, $ordnum ); } @@ -531,7 +472,7 @@ sub NewOrder { &ModOrder($title, $ordernumber, $quantity, $listprice, $biblionumber, $basketno, $supplier, $who, $notes, $bookfundid, $bibitemnum, $rrp, $ecost, $gst, $budget, - $unitprice, $booksellerinvoicenumber); + $unitprice, $booksellerinvoicenumber, $branchcode); Modifies an existing order. Updates the order with order number C<$ordernumber> and biblionumber C<$biblionumber>. All other arguments @@ -539,7 +480,7 @@ update the fields with the same name in the aqorders table of the Koha database. Entries with order number C<$ordernumber> in the aqorderbreakdown -table are also updated to the new book fund ID. +table are also updated to the new book fund ID or branchcode. =back @@ -550,47 +491,76 @@ sub ModOrder { $title, $ordnum, $quantity, $listprice, $bibnum, $basketno, $supplier, $who, $notes, $bookfund, $bibitemnum, $rrp, $ecost, $gst, $budget, - $cost, $invoice, $sort1, $sort2 + $cost, $invoice, $sort1, $sort2, $purchaseorder, $branchcode ) = @_; + # FIXME : Refactor to pass a hashref instead of fifty params. my $dbh = C4::Context->dbh; my $query = " UPDATE aqorders SET title=?, quantity=?,listprice=?,basketno=?, rrp=?,ecost=?,unitprice=?,booksellerinvoicenumber=?, - notes=?,sort1=?, sort2=? + notes=?,sort1=?, sort2=?, purchaseordernumber=? WHERE ordernumber=? AND biblionumber=? "; my $sth = $dbh->prepare($query); $sth->execute( $title, $quantity, $listprice, $basketno, $rrp, $ecost, $cost, $invoice, $notes, $sort1, - $sort2, $ordnum, $bibnum + $sort2, $purchaseorder, + $ordnum, $bibnum ); $sth->finish; - my $query = " + $query = " UPDATE aqorderbreakdown - SET bookfundid=? + SET bookfundid=?,branchcode=? WHERE ordernumber=? "; $sth = $dbh->prepare($query); - unless ( $sth->execute( $bookfund, $ordnum ) ) - { # zero rows affected [Bug 734] + my $rv = $sth->execute( $bookfund,$branchcode, $ordnum ); + unless($rv && ( $rv ne '0E0' )) { # zero rows affected [Bug 734] my $query =" INSERT INTO aqorderbreakdown - (ordernumber,bookfundid) - VALUES (?,?) + (ordernumber,branchcode,bookfundid) + VALUES (?,?,?) "; $sth = $dbh->prepare($query); - $sth->execute( $ordnum, $bookfund ); + $sth->execute( $ordnum,$branchcode, $bookfund ); } $sth->finish; } #------------------------------------------------------------# +=head3 ModOrderBiblioNumber + +=over 4 + +&ModOrderBiblioNumber($biblioitemnumber,$ordnum, $biblionumber); + +Modifies the biblioitemnumber for an existing order. +Updates the order with order number C<$ordernum> and biblionumber C<$biblionumber>. + +=back + +=cut + +sub ModOrderBiblioNumber { + my ($biblioitemnumber,$ordnum, $biblionumber) = @_; + my $dbh = C4::Context->dbh; + my $query = " + UPDATE aqorders + SET biblioitemnumber = ? + WHERE ordernumber = ? + AND biblionumber = ?"; + my $sth = $dbh->prepare($query); + $sth->execute( $biblioitemnumber, $ordnum, $biblionumber ); +} + +#------------------------------------------------------------# + =head3 ModReceiveOrder =over 4 @@ -603,6 +573,9 @@ Updates an order, to reflect the fact that it was received, at least in part. All arguments not mentioned below update the fields with the same name in the aqorders table of the Koha database. +If a partial order is received, splits the order into two. The received +portion must have a booksellerinvoicenumber. + Updates the order with bibilionumber C<$biblionumber> and ordernumber C<$ordernumber>. @@ -615,29 +588,22 @@ Also updates the book fund ID in the aqorderbreakdown table. sub ModReceiveOrder { my ( - $biblio, $ordnum, $quantrec, $user, $cost, - $invoiceno, $freight, $rrp, $bookfund + $biblionumber, $ordnum, $quantrec, $user, $cost, + $invoiceno, $freight, $rrp, $bookfund, $datereceived ) = @_; my $dbh = C4::Context->dbh; - my $query = " - UPDATE aqorders - SET quantityreceived=?,datereceived=now(),booksellerinvoicenumber=?, - unitprice=?,freight=?,rrp=? - WHERE biblionumber=? AND ordernumber=? - "; - my $sth = $dbh->prepare($query); - my $suggestionid = GetSuggestionFromBiblionumber( $dbh, $biblio ); +# warn "DATE BEFORE : $daterecieved"; +# $daterecieved=POSIX::strftime("%Y-%m-%d",CORE::localtime) unless $daterecieved; +# warn "DATE REC : $daterecieved"; + $datereceived = C4::Dates->output('iso') unless $datereceived; + my $suggestionid = GetSuggestionFromBiblionumber( $dbh, $biblionumber ); if ($suggestionid) { - ModStatus( $suggestionid, 'AVAILABLE', '', $biblio ); + ModStatus( $suggestionid, 'AVAILABLE', '', $biblionumber ); } - $sth->execute( $quantrec, $invoiceno, $cost, $freight, $rrp, $biblio, - $ordnum ); - $sth->finish; - # Allows libraries to change their bookfund during receiving orders # allows them to adjust budgets - if ( C4::Context->preferene("LooseBudgets") ) { + if ( C4::Context->preference("LooseBudgets") && $bookfund ) { my $query = " UPDATE aqorderbreakdown SET bookfundid=? @@ -647,8 +613,35 @@ sub ModReceiveOrder { $sth->execute( $bookfund, $ordnum ); $sth->finish; } + + my $sth=$dbh->prepare("SELECT * FROM aqorders LEFT JOIN aqorderbreakdown ON aqorders.ordernumber=aqorderbreakdown.ordernumber + WHERE biblionumber=? AND aqorders.ordernumber=?"); + $sth->execute($biblionumber,$ordnum); + my $order = $sth->fetchrow_hashref(); + $sth->finish(); + + if ( $order->{quantity} > $quantrec ) { + $sth=$dbh->prepare("update aqorders + set quantityreceived=?,datereceived=?,booksellerinvoicenumber=?, + unitprice=?,freight=?,rrp=?,quantity=? + where biblionumber=? and ordernumber=?"); + $sth->execute($quantrec,$datereceived,$invoiceno,$cost,$freight,$rrp,$quantrec,$biblionumber,$ordnum); + $sth->finish; + # create a new order for the remaining items, and set its bookfund. + my $newOrder = NewOrder($order->{'basketno'},$order->{'biblionumber'},$order->{'title'}, $order->{'quantity'} - $quantrec, + $order->{'listprice'},$order->{'booksellerid'},$order->{'authorisedby'},$order->{'notes'}, + $order->{'bookfundid'},$order->{'biblioitemnumber'},$order->{'rrp'},$order->{'ecost'},$order->{'gst'}, + $order->{'budget'},$order->{'unitcost'},$order->{'sub'},'',$order->{'sort1'},$order->{'sort2'},$order->{'purchaseordernumber'}); + } else { + $sth=$dbh->prepare("update aqorders + set quantityreceived=?,datereceived=?,booksellerinvoicenumber=?, + unitprice=?,freight=?,rrp=? + where biblionumber=? and ordernumber=?"); + $sth->execute($quantrec,$datereceived,$invoiceno,$cost,$freight,$rrp,$biblionumber,$ordnum); + $sth->finish; + } + return $datereceived; } - #------------------------------------------------------------# =head3 SearchOrder @@ -668,8 +661,8 @@ words). If C<$complete> is C, the results will include only completed orders. In any case, C<&ordersearch> ignores cancelled orders. -C<&ordersearch> returns an array. C<@results> is an array of references-to-hash with the -following keys: +C<&ordersearch> returns an array. +C<@results> is an array of references-to-hash with the following keys: =over 4 @@ -686,23 +679,38 @@ following keys: =cut sub SearchOrder { - my ( $search, $id, $biblio, $catview ) = @_; + my ( $search, $id, $biblionumber ) = @_; my $dbh = C4::Context->dbh; my @data = split( ' ', $search ); my @searchterms; if ($id) { @searchterms = ($id); } - map { push( @searchterms, "$_%", "% $_%" ) } @data; - push( @searchterms, $search, $search, $biblio ); + map { push( @searchterms, "$_%", "%$_%" ) } @data; + push( @searchterms, $search, $search, $biblionumber ); my $query; - if ($id) { + ### FIXME THIS CAN raise a problem if more THAN ONE biblioitem is linked to one biblio + if(not $id and $biblionumber and $search){ + $query = "SELECT *,biblio.title + FROM aqorders + LEFT JOIN biblio ON aqorders.biblionumber=biblio.biblionumber + LEFT JOIN biblioitems ON biblioitems.biblionumber=biblio.biblionumber + LEFT JOIN aqbasket ON aqorders.basketno = aqbasket.basketno + WHERE ((datecancellationprinted is NULL) + OR (datecancellationprinted = '0000-00-00')) + AND aqorders.biblionumber = ? + AND aqorders.ordernumber = ? + "; + @searchterms = ($biblionumber, $search); + } + elsif($id) { $query = - "SELECT *,biblio.title FROM aqorders,biblioitems,biblio,aqbasket - WHERE aqorders.biblioitemnumber = biblioitems.biblioitemnumber AND - aqorders.basketno = aqbasket.basketno - AND aqbasket.booksellerid = ? - AND biblio.biblionumber=aqorders.biblionumber + "SELECT *,biblio.title + FROM aqorders + LEFT JOIN biblio ON aqorders.biblionumber=biblio.biblionumber + LEFT JOIN biblioitems ON biblioitems.biblionumber=biblio.biblionumber + LEFT JOIN aqbasket ON aqorders.basketno = aqbasket.basketno + WHERE aqbasket.booksellerid = ? AND ((datecancellationprinted is NULL) OR (datecancellationprinted = '0000-00-00')) AND ((" @@ -711,16 +719,15 @@ sub SearchOrder { map { "(biblio.title like ? or biblio.title like ?)" } @data ) ) . ") OR biblioitems.isbn=? OR (aqorders.ordernumber=? AND aqorders.biblionumber=?)) "; - } else { $query = " SELECT *,biblio.title - FROM aqorders,biblioitems,biblio,aqbasket - WHERE aqorders.biblioitemnumber = biblioitems.biblioitemnumber - AND aqorders.basketno = aqbasket.basketno - AND biblio.biblionumber=aqorders.biblionumber - AND ((datecancellationprinted is NULL) + FROM aqorders + LEFT JOIN biblio ON biblio.biblionumber=aqorders.biblionumber + LEFT JOIN aqbasket on aqorders.basketno=aqbasket.basketno + LEFT JOIN biblioitems ON biblioitems.biblionumber=biblio.biblionumber + WHERE ((datecancellationprinted is NULL) OR (datecancellationprinted = '0000-00-00')) AND (aqorders.quantityreceived < aqorders.quantity OR aqorders.quantityreceived is NULL) AND ((" @@ -730,7 +737,9 @@ sub SearchOrder { ) . ") or biblioitems.isbn=? OR (aqorders.ordernumber=? AND aqorders.biblionumber=?)) "; } + $query .= " GROUP BY aqorders.ordernumber"; + ### $query my $sth = $dbh->prepare($query); $sth->execute(@searchterms); my @results = (); @@ -758,6 +767,7 @@ sub SearchOrder { $data->{'bookfundid'} = $data3->{'bookfundid'}; push( @results, $data ); } + ### @results $sth->finish; $sth2->finish; $sth3->finish; @@ -793,15 +803,8 @@ sub DelOrder { $sth->finish; } - -=back - -=back - =head2 FUNCTIONS ABOUT PARCELS -=over 2 - =cut #------------------------------------------------------------# @@ -813,7 +816,7 @@ sub DelOrder { @results = &GetParcel($booksellerid, $code, $date); Looks up all of the received items from the supplier with the given -bookseller ID at the given date, for the given code. Ignores cancelled and completed orders. +bookseller ID at the given date, for the given code (bookseller Invoice number). Ignores cancelled and completed orders. C<@results> is an array of references-to-hash. The keys of each element are fields from the aqorders, biblio, and biblioitems tables of the Koha database. @@ -825,7 +828,6 @@ C<@results> is sorted alphabetically by book title. =cut sub GetParcel { - #gets all orders from a certain supplier, orders them alphabetically my ( $supplierid, $code, $datereceived ) = @_; my $dbh = C4::Context->dbh; @@ -847,30 +849,31 @@ sub GetParcel { aqorders.listprice, aqorders.rrp, aqorders.ecost - FROM aqorders,aqbasket + FROM aqorders + LEFT JOIN aqbasket ON aqbasket.basketno=aqorders.basketno LEFT JOIN borrowers ON aqbasket.authorisedby=borrowers.borrowernumber - WHERE aqbasket.basketno=aqorders.basketno - AND aqbasket.booksellerid=? - AND aqorders.booksellerinvoicenumber LIKE \"$code\" - AND aqorders.datereceived= \'$datereceived\'"; + WHERE + aqbasket.booksellerid = ? + AND aqorders.booksellerinvoicenumber LIKE ? + AND aqorders.datereceived = ? "; + my @query_params = ( $supplierid, $code, $datereceived ); if ( C4::Context->preference("IndependantBranches") ) { my $userenv = C4::Context->userenv; if ( ($userenv) && ( $userenv->{flags} != 1 ) ) { - $strsth .= - " and (borrowers.branchcode = '" - . $userenv->{branch} - . "' or borrowers.branchcode ='')"; + $strsth .= " and (borrowers.branchcode = ? + or borrowers.branchcode = '')"; + push @query_params, $userenv->{branch}; } } - $strsth .= " order by aqbasket.basketno"; + $strsth .= " ORDER BY aqbasket.basketno"; ### parcelinformation : $strsth my $sth = $dbh->prepare($strsth); - $sth->execute($supplierid); + $sth->execute( @query_params ); while ( my $data = $sth->fetchrow_hashref ) { push( @results, $data ); } - ### countparcelbiblio: $count + ### countparcelbiblio: scalar(@results) $sth->finish; return @results; @@ -882,14 +885,37 @@ sub GetParcel { =over 4 -$results = &GetParcels($bookseller, $order, $code, $datefrom, $dateto, $limit); +$results = &GetParcels($bookseller, $order, $code, $datefrom, $dateto); +get a lists of parcels. + +=back + +* Input arg : + +=over 4 + +=item $bookseller +is the bookseller this function has to get parcels. + +=item $order +To know on what criteria the results list has to be ordered. + +=item $code +is the booksellerinvoicenumber. + +=item $datefrom & $dateto +to know on what date this function has to filter its search. + +* return: +a pointer on a hash list containing parcel informations as such : + +=item Creation date -get a lists of parcels -Returns a pointer on a hash list containing parcel informations as such : - Creation date - Last operation - Number of biblio - Number of items +=item Last operation + +=item Number of biblio + +=item Number of items =back @@ -898,36 +924,45 @@ Returns a pointer on a hash list containing parcel informations as such : sub GetParcels { my ($bookseller,$order, $code, $datefrom, $dateto) = @_; my $dbh = C4::Context->dbh; + my @query_params = (); my $strsth =" SELECT aqorders.booksellerinvoicenumber, - datereceived, + datereceived,purchaseordernumber, count(DISTINCT biblionumber) AS biblio, sum(quantity) AS itemsexpected, sum(quantityreceived) AS itemsreceived - FROM aqorders, aqbasket - WHERE aqbasket.basketno = aqorders.basketno - AND aqbasket.booksellerid = $bookseller and datereceived IS NOT NULL + FROM aqorders LEFT JOIN aqbasket ON aqbasket.basketno = aqorders.basketno + WHERE aqbasket.booksellerid = $bookseller and datereceived IS NOT NULL "; - $strsth .= "and aqorders.booksellerinvoicenumber like \"$code%\" " if ($code); - - $strsth .= "and datereceived >=" . $dbh->quote($datefrom) . " " if ($datefrom); + if ( defined $code ) { + $strsth .= ' and aqorders.booksellerinvoicenumber like ? '; + # add a % to the end of the code to allow stemming. + push @query_params, "$code%"; + } + + if ( defined $datefrom ) { + $strsth .= ' and datereceived >= ? '; + push @query_params, $datefrom; + } - $strsth .= "and datereceived <=" . $dbh->quote($dateto) . " " if ($dateto); + if ( defined $dateto ) { + $strsth .= 'and datereceived <= ? '; + push @query_params, $dateto; + } $strsth .= "group by aqorders.booksellerinvoicenumber,datereceived "; - $strsth .= "order by $order " if ($order); - my $sth = $dbh->prepare($strsth); - $sth->execute; - my @results; + # can't use a placeholder to place this column name. + # but, we could probably be checking to make sure it is a column that will be fetched. + $strsth .= "order by $order " if ($order); - while ( my $data2 = $sth->fetchrow_hashref ) { - push @results, $data2; - } + my $sth = $dbh->prepare($strsth); + $sth->execute( @query_params ); + my $results = $sth->fetchall_arrayref({}); $sth->finish; - return @results; + return @$results; } #------------------------------------------------------------# @@ -938,7 +973,7 @@ sub GetParcels { @results = &GetLateOrders; -Searches for suppliers with late orders. +Searches for bookseller with late orders. return: the table of supplier with late issues. This table is full of hashref. @@ -955,96 +990,81 @@ sub GetLateOrders { my $dbh = C4::Context->dbh; #BEWARE, order of parenthesis and LEFT JOIN is important for speed - my $strsth; my $dbdriver = C4::Context->config("db_scheme") || "mysql"; - # warn " $dbdriver"; - if ( $dbdriver eq "mysql" ) { - $strsth = " - SELECT aqbasket.basketno, - DATE(aqbasket.closedate) AS orderdate, - aqorders.quantity - IFNULL(aqorders.quantityreceived,0) AS quantity, - aqorders.rrp AS unitpricesupplier, - aqorders.ecost AS unitpricelib, - (aqorders.quantity - IFNULL(aqorders.quantityreceived,0)) * aqorders.rrp AS subtotal, - aqbookfund.bookfundname AS budget, - borrowers.branchcode AS branch, - aqbooksellers.name AS supplier, - aqorders.title, - biblio.author, - biblioitems.publishercode AS publisher, - biblioitems.publicationyear, - DATEDIFF(CURDATE( ),closedate) AS latesince - FROM ((( - (aqorders LEFT JOIN biblio ON biblio.biblionumber = aqorders.biblionumber) - LEFT JOIN biblioitems ON biblioitems.biblionumber=biblio.biblionumber) - LEFT JOIN aqorderbreakdown ON aqorders.ordernumber = aqorderbreakdown.ordernumber) - LEFT JOIN aqbookfund ON aqorderbreakdown.bookfundid = aqbookfund.bookfundid), - (aqbasket LEFT JOIN borrowers ON aqbasket.authorisedby = borrowers.borrowernumber) - LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id - WHERE aqorders.basketno = aqbasket.basketno - AND (closedate < DATE_SUB(CURDATE( ),INTERVAL $delay DAY)) - AND ((datereceived = '' OR datereceived is null) - OR (aqorders.quantityreceived < aqorders.quantity) ) - "; - $strsth .= " AND aqbasket.booksellerid = $supplierid " if ($supplierid); - $strsth .= " AND borrowers.branchcode like \'" . $branch . "\'" - if ($branch); - $strsth .= - " AND borrowers.branchcode like \'" - . C4::Context->userenv->{branch} . "\'" - if ( C4::Context->preference("IndependantBranches") - && C4::Context->userenv - && C4::Context->userenv->{flags} != 1 ); - $strsth .=" HAVING quantity<>0 - AND unitpricesupplier<>0 - AND unitpricelib<>0 - ORDER BY latesince,basketno,borrowers.branchcode, supplier - "; + my @query_params = ($delay); # delay is the first argument regardless + my $select = " + SELECT aqbasket.basketno, + aqorders.ordernumber, + DATE(aqbasket.closedate) AS orderdate, + aqorders.rrp AS unitpricesupplier, + aqorders.ecost AS unitpricelib, + aqbookfund.bookfundname AS budget, + borrowers.branchcode AS branch, + aqbooksellers.name AS supplier, + aqorders.title, + biblio.author, + biblioitems.publishercode AS publisher, + biblioitems.publicationyear, + "; + my $from = " + FROM ((( + (aqorders LEFT JOIN biblio ON biblio.biblionumber = aqorders.biblionumber) + LEFT JOIN biblioitems ON biblioitems.biblionumber = biblio.biblionumber) + LEFT JOIN aqorderbreakdown ON aqorders.ordernumber = aqorderbreakdown.ordernumber) + LEFT JOIN aqbookfund ON aqorderbreakdown.bookfundid = aqbookfund.bookfundid), + (aqbasket LEFT JOIN borrowers ON aqbasket.authorisedby = borrowers.borrowernumber) + LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id + WHERE aqorders.basketno = aqbasket.basketno + AND ( (datereceived = '' OR datereceived IS NULL) + OR (aqorders.quantityreceived < aqorders.quantity) + ) + "; + my $having = ""; + if ($dbdriver eq "mysql") { + $select .= " + aqorders.quantity - IFNULL(aqorders.quantityreceived,0) AS quantity, + (aqorders.quantity - IFNULL(aqorders.quantityreceived,0)) * aqorders.rrp AS subtotal, + DATEDIFF(CURDATE( ),closedate) AS latesince + "; + $from .= " AND (closedate <= DATE_SUB(CURDATE( ),INTERVAL ? DAY)) "; + $having = " + HAVING quantity <> 0 + AND unitpricesupplier <> 0 + AND unitpricelib <> 0 + "; + } else { + # FIXME: account for IFNULL as above + $select .= " + aqorders.quantity AS quantity, + aqorders.quantity * aqorders.rrp AS subtotal, + (CURDATE - closedate) AS latesince + "; + $from .= " AND (closedate <= (CURDATE -(INTERVAL ? DAY)) "; } - else { - $strsth = " - SELECT aqbasket.basketno, - DATE(aqbasket.closedate) AS orderdate, - aqorders.quantity, aqorders.rrp AS unitpricesupplier, - aqorders.ecost as unitpricelib, - aqorders.quantity * aqorders.rrp AS subtotal - aqbookfund.bookfundname AS budget, - borrowers.branchcode AS branch, - aqbooksellers.name AS supplier, - biblio.title, - biblio.author, - biblioitems.publishercode AS publisher, - biblioitems.publicationyear, - (CURDATE - closedate) AS latesince - FROM(( ( - (aqorders LEFT JOIN biblio on biblio.biblionumber = aqorders.biblionumber) - LEFT JOIN biblioitems on biblioitems.biblionumber=biblio.biblionumber) - LEFT JOIN aqorderbreakdown on aqorders.ordernumber = aqorderbreakdown.ordernumber) - LEFT JOIN aqbookfund ON aqorderbreakdown.bookfundid = aqbookfund.bookfundid), - (aqbasket LEFT JOIN borrowers on aqbasket.authorisedby = borrowers.borrowernumber) LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id - WHERE aqorders.basketno = aqbasket.basketno - AND (closedate < (CURDATE -(INTERVAL $delay DAY)) - AND ((datereceived = '' OR datereceived is null) - OR (aqorders.quantityreceived < aqorders.quantity) ) "; - $strsth .= " AND aqbasket.booksellerid = $supplierid " if ($supplierid); - - $strsth .= " AND borrowers.branchcode like \'" . $branch . "\'" if ($branch); - $strsth .=" AND borrowers.branchcode like \'". C4::Context->userenv->{branch} . "\'" - if (C4::Context->preference("IndependantBranches") && C4::Context->userenv->{flags} != 1 ); - $strsth .=" ORDER BY latesince,basketno,borrowers.branchcode, supplier"; + if (defined $supplierid) { + $from .= ' AND aqbasket.booksellerid = ? '; + push @query_params, $supplierid; } - my $sth = $dbh->prepare($strsth); - $sth->execute; + if (defined $branch) { + $from .= ' AND borrowers.branchcode LIKE ? '; + push @query_params, $branch; + } + if (C4::Context->preference("IndependantBranches") + && C4::Context->userenv + && C4::Context->userenv->{flags} != 1 ) { + $from .= ' AND borrowers.branchcode LIKE ? '; + push @query_params, C4::Context->userenv->{branch}; + } + my $query = "$select $from $having\nORDER BY latesince, basketno, borrowers.branchcode, supplier"; + $debug and print STDERR "GetLateOrders query: $query\nGetLateOrders args: " . join(" ",@query_params); + my $sth = $dbh->prepare($query); + $sth->execute(@query_params); my @results; - my $hilighted = 1; - while ( my $data = $sth->fetchrow_hashref ) { - $data->{hilighted} = $hilighted if ( $hilighted > 0 ); - $data->{orderdate} = format_date( $data->{orderdate} ); + while (my $data = $sth->fetchrow_hashref) { + $data->{orderdate} = format_date($data->{orderdate}); push @results, $data; - $hilighted = -$hilighted; } - $sth->finish; return @results; } @@ -1054,9 +1074,31 @@ sub GetLateOrders { =over 4 -(\@order_loop, $total_qty, $total_price, $total_qtyreceived)=&GetHistory( $title, $author, $name, $from_placed_on, $to_placed_on ) - -this function get the search history. +(\@order_loop, $total_qty, $total_price, $total_qtyreceived) = GetHistory( $title, $author, $name, $from_placed_on, $to_placed_on ); + + Retreives some acquisition history information + + returns: + $order_loop is a list of hashrefs that each look like this: + { + 'author' => 'Twain, Mark', + 'basketno' => '1', + 'biblionumber' => '215', + 'count' => 1, + 'creationdate' => 'MM/DD/YYYY', + 'datereceived' => undef, + 'ecost' => '1.00', + 'id' => '1', + 'invoicenumber' => undef, + 'name' => '', + 'ordernumber' => '1', + 'quantity' => 1, + 'quantityreceived' => undef, + 'title' => 'The Adventures of Huckleberry Finn' + } + $total_qty is the sum of all of the quantities in $order_loop + $total_price is the cost of each in $order_loop times the quantity + $total_qtyreceived is the sum of all of the quantityreceived entries in $order_loop =back @@ -1082,47 +1124,58 @@ sub GetHistory { aqorders.quantity, aqorders.quantityreceived, aqorders.ecost, - aqorders.ordernumber - FROM aqorders,aqbasket,aqbooksellers,biblio"; - - $query .= ",borrowers " - if ( C4::Context->preference("IndependantBranches") ); - - $query .=" - WHERE aqorders.basketno=aqbasket.basketno - AND aqbasket.booksellerid=aqbooksellers.id - AND biblio.biblionumber=aqorders.biblionumber "; - - $query .= " AND aqbasket.authorisedby=borrowers.borrowernumber" + aqorders.ordernumber, + aqorders.booksellerinvoicenumber as invoicenumber, + aqbooksellers.id as id, + aqorders.biblionumber + FROM aqorders + LEFT JOIN aqbasket ON aqorders.basketno=aqbasket.basketno + LEFT JOIN aqbooksellers ON aqbasket.booksellerid=aqbooksellers.id + LEFT JOIN biblio ON biblio.biblionumber=aqorders.biblionumber"; + + $query .= " LEFT JOIN borrowers ON aqbasket.authorisedby=borrowers.borrowernumber" if ( C4::Context->preference("IndependantBranches") ); - $query .= " AND biblio.title LIKE " . $dbh->quote( "%" . $title . "%" ) - if $title; + $query .= " WHERE (datecancellationprinted is NULL or datecancellationprinted='0000-00-00') "; + + my @query_params = (); + + if ( defined $title ) { + $query .= " AND biblio.title LIKE ? "; + $title =~ s/\s+/%/g; + push @query_params, "%$title%"; + } - $query .= - " AND biblio.author LIKE " . $dbh->quote( "%" . $author . "%" ) - if $author; + if ( defined $author ) { + $query .= " AND biblio.author LIKE ? "; + push @query_params, "%$author%"; + } - $query .= " AND name LIKE " . $dbh->quote( "%" . $name . "%" ) if $name; + if ( defined $name ) { + $query .= " AND name LIKE ? "; + push @query_params, "%$name%"; + } - $query .= " AND creationdate >" . $dbh->quote($from_placed_on) - if $from_placed_on; + if ( defined $from_placed_on ) { + $query .= " AND creationdate >= ? "; + push @query_params, $from_placed_on; + } - $query .= " AND creationdate<" . $dbh->quote($to_placed_on) - if $to_placed_on; + if ( defined $to_placed_on ) { + $query .= " AND creationdate <= ? "; + push @query_params, $to_placed_on; + } if ( C4::Context->preference("IndependantBranches") ) { my $userenv = C4::Context->userenv; if ( ($userenv) && ( $userenv->{flags} != 1 ) ) { - $query .= - " AND (borrowers.branchcode = '" - . $userenv->{branch} - . "' OR borrowers.branchcode ='')"; + $query .= " AND (borrowers.branchcode = ? OR borrowers.branchcode ='' ) "; + push @query_params, $userenv->{branch}; } } $query .= " ORDER BY booksellerid"; my $sth = $dbh->prepare($query); - $sth->execute; + $sth->execute( @query_params ); my $cnt = 1; while ( my $line = $sth->fetchrow_hashref ) { $line->{count} = $cnt++; @@ -1138,13 +1191,34 @@ sub GetHistory { return \@order_loop, $total_qty, $total_price, $total_qtyreceived; } -END { } # module clean-up code here (global destructor) +=head2 GetRecentAcqui -1; + $results = GetRecentAcqui($days); -__END__ + C<$results> is a ref to a table which containts hashref -=back +=cut + +sub GetRecentAcqui { + my $limit = shift; + my $dbh = C4::Context->dbh; + my $query = " + SELECT * + FROM biblio + ORDER BY timestamp DESC + LIMIT 0,".$limit; + + my $sth = $dbh->prepare($query); + $sth->execute; + my @results; + while(my $data = $sth->fetchrow_hashref){ + push @results,$data; + } + return \@results; +} + +1; +__END__ =head1 AUTHOR