X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=admin%2Fbranches.pl;h=12c49e28ba3dbd80b4e3a0d6ed9bc27241495992;hb=a7f7aeb138b8275448937102cb7a46cf49530aef;hp=fa999439247a56c381f82eeaece5baa515de66b4;hpb=0dd1c929711dacfb979290f02f9403169a5cf38b;p=koha.git

diff --git a/admin/branches.pl b/admin/branches.pl
index fa99943924..12c49e28ba 100755
--- a/admin/branches.pl
+++ b/admin/branches.pl
@@ -1,26 +1,4 @@
 #!/usr/bin/perl
-# NOTE: Use standard 8-space tabs for this file (indents are 4 spaces)
-
-#require '/u/acli/lib/cvs.pl';#DEBUG
-#open(DEBUG,'>/tmp/koha.debug');
-
-# FIXME: individual fields in branch address need to be exported to templates,
-#        in order to fix bug 180; need to notify translators
-# FIXME: looped html (e.g., list of checkboxes) need to be properly
-#        TMPL_LOOP'ized; doing this properly will fix bug 130; need to
-#        notify translators
-# FIXME: need to implement the branch categories stuff
-# FIXME: heading() need to be moved to templates, need to notify translators
-# FIXME: there are too many TMPL_IF's; the proper way to do it is to have
-#        separate templates for each individual action; need to notify
-#        translators
-# FIXME: there are lots of error messages exported to the template; a lot
-#        of these should be converted into exported booleans / counters etc
-#        so that the error messages can be localized; need to notify translators
-
-# Finlay working on this file from 26-03-2002
-# Reorganising this branches admin page.....
-
 
 # Copyright 2000-2002 Katipo Communications
 #
@@ -35,490 +13,402 @@
 # WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
 # A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
+# You should have received a copy of the GNU General Public License along
+# with Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+=head1 branches.pl
+
+ FIXME: individual fields in branch address need to be exported to templates,
+        in order to fix bug 180; need to notify translators
+ FIXME: looped html (e.g., list of checkboxes) need to be properly
+        TMPL_LOOP'ized; doing this properly will fix bug 130; need to
+        notify translators
+ FIXME: need to implement the branch categories stuff
+ FIXME: there are too many TMPL_IF's; the proper way to do it is to have
+        separate templates for each individual action; need to notify
+        translators
+ FIXME: there are lots of error messages exported to the template; a lot
+        of these should be converted into exported booleans / counters etc
+        so that the error messages can be localized; need to notify translators
+
+ Finlay working on this file from 26-03-2002
+ Reorganising this branches admin page.....
+
+=cut
 
 use strict;
+use warnings;
 use CGI;
 use C4::Auth;
 use C4::Context;
 use C4::Output;
-use C4::Interface::CGI::Output;
-use HTML::Template;
+use C4::Koha;
+use C4::Branch;
 
 # Fixed variables
-my $linecolor1='#ffffcc';
-my $linecolor2='white';
-my $backgroundimage="/images/background-mem.gif";
-my $script_name="/cgi-bin/koha/admin/branches.pl";
-my $pagesize=20;
-
+my $script_name = "/cgi-bin/koha/admin/branches.pl";
 
-#######################################################################################
+################################################################################
 # Main loop....
-my $input = new CGI;
-my $branchcode=$input->param('branchcode');
+my $input        = new CGI;
+my $branchcode   = $input->param('branchcode');
+my $branchname   = $input->param('branchname');
 my $categorycode = $input->param('categorycode');
-my $op = $input->param('op');
-
-my ($template, $borrowernumber, $cookie)
-    = get_template_and_user({template_name => "parameters/branches.tmpl",
-			     query => $input,
-			     type => "intranet",
-			     authnotrequired => 0,
-			     flagsrequired => {parameters => 1},
-			     debug => 1,
-			     });
-if ($op) {
-	$template->param(script_name => $script_name,
-				$op         => 1); # we show only the TMPL_VAR names $op
-} else {
-	$template->param(script_name => $script_name,
-				else        => 1); # we show only the TMPL_VAR names $op
-}
-$template->param(action => $script_name);
-
-if ($op eq 'add') {
-	# If the user has pressed the "add new branch" button.
-	heading("Branches: Add Branch");
-	editbranchform();
-
-} elsif ($op eq 'edit') {
-	# if the user has pressed the "edit branch settings" button.
-	heading("Branches: Edit Branch");
-	$template->param(add => 1);
-	editbranchform($branchcode);
-} elsif ($op eq 'add_validate') {
-	# confirm settings change...
-	my $params = $input->Vars;
-	unless ($params->{'branchcode'} && $params->{'branchname'}) {
-		default ("Cannot change branch record: You must specify a Branchname and a Branchcode");
-	} else {
-		setbranchinfo($params);
-		$template->param(else => 1);
-		default ("Branch record changed for branch: $params->{'branchname'}");
-	}
-} elsif ($op eq 'delete') {
-	# if the user has pressed the "delete branch" button.
-	my $message = checkdatabasefor($branchcode);
-	if ($message) {
-		$template->param(else => 1);
-		default($message);
-	} else {
-		$template->param(delete_confirm => 1);
-		$template->param(branchcode => $branchcode);
-	}
-} elsif ($op eq 'delete_confirmed') {
-	# actually delete branch and return to the main screen....
-	deletebranch($branchcode);
-	$template->param(else => 1);
-	default("The branch with code $branchcode has been deleted.");
-} elsif ($op eq 'editcategory') {
-	# If the user has pressed the "add new category" button.
-	heading("Branches: Edit Category");
-	editcatform($categorycode);
-} elsif ($op eq 'addcategory_validate') {
-	# confirm settings change...
-	my $params = $input->Vars;
-	unless ($params->{'categorycode'} && $params->{'categoryname'}) {
-		default ("Cannot change branch record: You must specify a Branchname and a Branchcode");
-	} else {
-		setcategoryinfo($params);
-		$template->param(else => 1);
-		default ("Category record changed for category $params->{'categoryname'}");
-	}
-} elsif ($op eq 'delete_category') {
-	# if the user has pressed the "delete branch" button.
-	my $message = checkcategorycode($categorycode);
-	if ($message) {
-		$template->param(else => 1);
-		default($message);
-	} else {
-		$template->param(delete_category => 1);
-		$template->param(categorycode => $categorycode);
-	}
-} elsif ($op eq 'categorydelete_confirmed') {
-	# actually delete branch and return to the main screen....
-	deletecategory($categorycode);
-	$template->param(else => 1);
-	default("The category with code $categorycode has been deleted.");
-
-} else {
-	# if no operation has been set...
-	default();
-}
-
+my $op           = $input->param('op') || '';
+
+my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
+    {
+        template_name   => "admin/branches.tmpl",
+        query           => $input,
+        type            => "intranet",
+        authnotrequired => 0,
+        flagsrequired   => { parameters => 1},
+        debug           => 1,
+    }
+);
+$template->param(
+     script_name => $script_name,
+     action      => $script_name,
+);
+$template->param( ($op || 'else') => 1 );
 
+if ( $op eq 'add' ) {
 
-######################################################################################################
-#
-# html output functions....
+    # If the user has pressed the "add new branch" button.
+    $template->param( 'heading_branches_add_branch_p' => 1 );
+    editbranchform($branchcode,$template);
 
-sub default {
-	my ($message) = @_;
-	heading("Branches");
-	$template->param(message => $message);
-	$template->param(action => $script_name);
-	branchinfotable();
 }
+elsif ( $op eq 'edit' ) {
 
-# FIXME: this function should not exist; otherwise headings are untranslatable
-sub heading {
-	my ($head) = @_;
-	$template->param(head => $head);
+    # if the user has pressed the "edit branch settings" button.
+    $template->param( 'heading_branches_add_branch_p' => 0,
+                        'add' => 1, );
+    editbranchform($branchcode,$template);
 }
+elsif ( $op eq 'add_validate' ) {
 
-sub editbranchform {
-	# prepares the edit form...
-	my ($branchcode) = @_;
-	my $data;
-	if ($branchcode) {
-		$data = getbranchinfo($branchcode);
-		$data = $data->[0];
-		$template->param(branchcode => $data->{'branchcode'});
-		$template->param(branchname => $data->{'branchname'});
-		$template->param(branchaddress1 => $data->{'branchaddress1'});
-		$template->param(branchaddress2 => $data->{'branchaddress2'});
-		$template->param(branchaddress3 => $data->{'branchaddress3'});
-		$template->param(branchphone => $data->{'branchphone'});
-		$template->param(branchfax => $data->{'branchfax'});
-		$template->param(branchemail => $data->{'branchemail'});
+    # confirm settings change...
+    my $params = $input->Vars;
+    unless ( $params->{'branchcode'} && $params->{'branchname'} ) {
+        $template->param( else => 1 );
+        default("MESSAGE1",$template);
+    }
+    else {
+        my $mod_branch = 1;
+        if ($params->{add}) {
+            my ($existing) =
+                C4::Context->dbh->selectrow_array("SELECT count(*) FROM branches WHERE branchcode = ?", {}, $branchcode);
+            if ($existing > 0) {
+                $mod_branch = 0;
+                _branch_to_template($params, $template); # preserve most (FIXME) of user's input
+                $template->param( 'heading_branches_add_branch_p' => 1, 'add' => 1, 'ERROR1' => 1 );
+            }
+        }
+        if ($mod_branch) {
+            my $error = ModBranch($params); # FIXME: causes warnings to log on duplicate branchcode
+            # if error saving, stay on edit and rise error
+            if ($error) {
+                # copy input parameters back to form
+                # FIXME - doing this doesn't preserve any branch group selections, but good enough for now
+                editbranchform($branchcode,$template);
+                $template->param( 'heading_branches_add_branch_p' => 1, 'add' => 1, "ERROR$error" => 1 );
+            } else {
+                $template->param( else => 1);
+                default("MESSAGE2",$template);
+            }
+        }
     }
-
-    # make the checkboxs.....
-    #
-    # We export a "categoryloop" array to the template, each element of which
-    # contains separate 'categoryname', 'categorycode', 'codedescription', and
-    # 'checked' fields. The $checked field is either '' or 'checked'
-    # (see bug 130)
-    #
-    my $catinfo = getcategoryinfo();
-    my $catcheckbox;
-#    print DEBUG "catinfo=".cvs($catinfo)."\n";
-    my @categoryloop = ();
-    foreach my $cat (@$catinfo) {
-	my $checked = "";
-	my $tmp = quotemeta($cat->{'categorycode'});
-	if (grep {/^$tmp$/} @{$data->{'categories'}}) {
-		$checked = "CHECKED";
-	}
-	push @categoryloop, {
-		categoryname    => $cat->{'categoryname'},
-		categorycode    => $cat->{'categorycode'},
-		codedescription => $cat->{'codedescription'},
-		checked         => $checked,
-	    };
-	}
-	$template->param(categoryloop => \@categoryloop);
-
-    # {{{ Leave this here until bug 130 is completely resolved in the templates
-	for my $obsolete ('categoryname', 'categorycode', 'codedescription') {
-		$template->param($obsolete => 'Your template is out of date (bug 130)');
-	}
-    # }}}
 }
-
-sub editcatform {
-	# prepares the edit form...
-	my ($categorycode) = @_;
-	warn "cat : $categorycode";
-	my $data;
-	if ($categorycode) {
-		$data = getcategoryinfo($categorycode);
-		$data = $data->[0];
-		$template->param(categorycode => $data->{'categorycode'});
-		$template->param(categoryname => $data->{'categoryname'});
-		$template->param(codedescription => $data->{'codedescription'});
+elsif ( $op eq 'delete' ) {
+    # if the user has pressed the "delete branch" button.
+    
+    # check to see if the branchcode is being used in the database somewhere....
+    my $dbh = C4::Context->dbh;
+    my $sthitems     = $dbh->prepare("select count(*) from items where holdingbranch=? or homebranch=?");
+    my $sthborrowers = $dbh->prepare("select count(*) from borrowers where branchcode=?");
+    $sthitems->execute( $branchcode, $branchcode );
+    $sthborrowers->execute( $branchcode );
+    my ($totalitems)     = $sthitems->fetchrow_array;
+    my ($totalborrowers) = $sthborrowers->fetchrow_array;
+    if ($totalitems && !$totalborrowers) {
+        $template->param( else => 1 );
+        default("MESSAGE10", $template);
+    }
+    elsif (!$totalitems && $totalborrowers){
+        $template->param( else => 1 );
+        default("MESSAGE11", $template);
+    }
+    elsif ($totalitems && $totalborrowers){
+        $template->param( else => 1 );
+        default("MESSAGE7", $template);
+    }
+    else {
+        $template->param( delete_confirm => 1 );
+        $template->param( branchname     => $branchname );
+        $template->param( branchcode     => $branchcode );
     }
 }
+elsif ( $op eq 'delete_confirmed' ) {
 
-sub deleteconfirm {
-# message to print if the
-    my ($branchcode) = @_;
+    # actually delete branch and return to the main screen....
+    DelBranch($branchcode);
+    $template->param( else => 1 );
+    default("MESSAGE3",$template);
 }
+elsif ( $op eq 'editcategory' ) {
 
+    # If the user has pressed the "add new category" or "modify" buttons.
+    $template->param( 'heading_branches_edit_category_p' => 1 );
+    editcatform($categorycode,$template);
+}
+elsif ( $op eq 'addcategory_validate' ) {
 
-sub branchinfotable {
-# makes the html for a table of branch info from reference to an array of hashs.
-
-	my ($branchcode) = @_;
-	my $branchinfo;
-	if ($branchcode) {
-		$branchinfo = getbranchinfo($branchcode);
-	} else {
-		$branchinfo = getbranchinfo();
-	}
-	my $color;
-	my @loop_data =();
-	foreach my $branch (@$branchinfo) {
-		($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
-		#
-		# We export the following fields to the template. These are not
-		# pre-composed as a single "address" field because the template
-		# might (and should) escape what is exported here. (See bug 180)
-		#
-		# - color
-		# - branch_name     (Note: not "branchname")
-		# - branch_code     (Note: not "branchcode")
-		# - address         (containing a static error message)
-		# - branchaddress1 \
-		# - branchaddress2  |
-		# - branchaddress3  | comprising the old "address" field
-		# - branchphone     |
-		# - branchfax       |
-		# - branchemail    /
-		# - address-empty-p (1 if no address information, 0 otherwise)
-		# - categories      (containing a static error message)
-		# - category_list   (loop containing "categoryname")
-		# - no-categories-p (1 if no categories set, 0 otherwise)
-		# - value
-		# - action
-		#
-		my %row = ();
-
-		# Handle address fields separately
-		my $address_empty_p = 1;
-		for my $field ('branchaddress1', 'branchaddress2', 'branchaddress3',
-			'branchphone', 'branchfax', 'branchemail') {
-			$row{$field} = $branch->{$field};
-			if ( $branch->{$field} ) {
-				$address_empty_p = 0;
-			}
-		}
-		$row{'address-empty-p'} = $address_empty_p;
-		# {{{ Leave this here until bug 180 is completely resolved in templates
-		$row{'address'} = 'Your template is out of date (see bug 180)';
-		# }}}
-
-		# Handle categories
-		my $no_categories_p = 1;
-		my @categories = '';
-		foreach my $cat (@{$branch->{'categories'}}) {
-			my ($catinfo) = @{getcategoryinfo($cat)};
-			push @categories, {'categoryname' => $catinfo->{'categoryname'}};
-			$no_categories_p = 0;
-		}
-		# {{{ Leave this here until bug 180 is completely resolved in templates
-		$row{'categories'} = 'Your template is out of date (see bug 180)';
-		# }}}
-		$row{'category_list'} = \@categories;
-		$row{'no-categories-p'} = $no_categories_p;
-
-		# Handle all other fields
-		$row{'branch_name'} = $branch->{'branchname'};
-		$row{'branch_code'} = $branch->{'branchcode'};
-		$row{'color'} = $color;
-		$row{'value'} = $branch->{'branchcode'};
-		$row{'action'} = '/cgi-bin/koha/admin/branches.pl';
-
-		push @loop_data, { %row };
+    $template->param( else => 1 );
+    # confirm settings change...
+    my $params = $input->Vars;
+    unless ( $params->{'categorycode'} && $params->{'categoryname'} ) {
+        default("MESSAGE4",$template);
+    }
+    elsif ($input->param('add')){
+	# doing an add must check the code is unique
+	if (CheckCategoryUnique($input->param('categorycode'))){
+	    ModBranchCategoryInfo($params);
+        default("MESSAGE5",$template);
 	}
-	my @branchcategories =();
-	my $catinfo = getcategoryinfo();
-	foreach my $cat (@$catinfo) {
-		push @branchcategories, {
-			categoryname    => $cat->{'categoryname'},
-			categorycode    => $cat->{'categorycode'},
-			codedescription => $cat->{'codedescription'},
-		};
+	else {
+	    default("MESSAGE9",$template);
 	}
-
-	$template->param(branches => \@loop_data,
-							branchcategories => \@branchcategories);
-
+    }
+    else {
+        ModBranchCategoryInfo($params);
+        default("MESSAGE5",$template);
+    }
 }
+elsif ( $op eq 'delete_category' ) {
 
-# FIXME logic seems wrong
-sub branchcategoriestable {
-#Needs to be implemented...
-
-    my $categoryinfo = getcategoryinfo();
-    my $color;
-    foreach my $cat (@$categoryinfo) {
-	($color eq $linecolor1) ? ($color=$linecolor2) : ($color=$linecolor1);
-	$template->param(color => $color);
-	$template->param(categoryname => $cat->{'categoryname'});
-	$template->param(categorycode => $cat->{'categorycode'});
-	$template->param(codedescription => $cat->{'codedescription'});
+    # if the user has pressed the "delete branch" button.
+    if ( CheckBranchCategorycode($categorycode) ) {
+        $template->param( else => 1 );
+        default( 'MESSAGE8', $template );
+    } else {
+        $template->param( delete_category => 1 );
+        $template->param( categorycode    => $categorycode );
     }
 }
+elsif ( $op eq 'categorydelete_confirmed' ) {
 
-######################################################################################################
+    # actually delete branch and return to the main screen....
+    DelBranchCategory($categorycode);
+    $template->param( else => 1 );
+    default("MESSAGE6",$template);
+
+}
+else {
+    # if no operation has been set...
+    default("",$template);
+}
+
+################################################################################
 #
-# Database functions....
+# html output functions....
+
+sub default {
+    my $message       = shift || '';
+    my $innertemplate = shift or return;
+    $innertemplate->param($message => 1) if $message;
+    $innertemplate->param(
+        'heading_branches_p' => 1,
+    );
+    branchinfotable("",$innertemplate);
+}
 
-sub getbranchinfo {
-# returns a reference to an array of hashes containing branches,
+sub editbranchform {
+    my ($branchcode,$innertemplate) = @_;
+    # initiate the scrolling-list to select the printers
+    my $printers = GetPrinters();
+    my @printerloop;
+    my $data;
+    my $oldprinter = "";
 
-    my ($branchcode) = @_;
-    my $dbh = C4::Context->dbh;
-    my ($query, @query_args);
     if ($branchcode) {
-	$query = "Select * from branches where branchcode = ?";
-	@query_args = ($branchcode);
-    } else {
-	$query = "Select * from branches";
+        $data = GetBranchInfo($branchcode);
+        $data = $data->[0];
+
+        # get the old printer of the branch
+        $oldprinter = $data->{'branchprinter'} || '';
+        _branch_to_template($data, $innertemplate);
     }
-    $query.=" order by branchcode";
-    my $sth = $dbh->prepare($query);
-    $sth->execute(@query_args);
-    my @results;
-    while (my $data = $sth->fetchrow_hashref) {
-	$query = "select categorycode from branchrelations where branchcode = ?";
-	my $nsth = $dbh->prepare($query);
-	$nsth->execute($data->{'branchcode'});;
-	my @cats = ();
-	while (my ($cat) = $nsth->fetchrow_array) {
-	    push(@cats, $cat);
-	}
-	$nsth->finish;
-	$data->{'categories'} = \@cats;
-	push(@results, $data);
+
+    foreach my $thisprinter ( keys %$printers ) {
+        push @printerloop, {
+            value         => $thisprinter,
+            selected      => ( $oldprinter eq $printers->{$thisprinter} ),
+            branchprinter => $printers->{$thisprinter}->{'printqueue'},
+        };
     }
-    $sth->finish;
-    return \@results;
-}
 
-# FIXME This doesn't belong here; it should be moved into a module
-sub getcategoryinfo {
-# returns a reference to an array of hashes containing branches,
-	my ($catcode) = @_;
-	my $dbh = C4::Context->dbh;
-	my ($query, @query_args);
-	#    print DEBUG "getcategoryinfo: entry: catcode=".cvs($catcode)."\n";
-	if ($catcode) {
-		$query = "select * from branchcategories where categorycode = ?";
-		@query_args = ($catcode);
-	} else {
-		$query = "Select * from branchcategories";
-	}
-	#    print DEBUG "getcategoryinfo: query=".cvs($query)."\n";
-	my $sth = $dbh->prepare($query);
-	$sth->execute(@query_args);
-	my @results;
-	while (my $data = $sth->fetchrow_hashref) {
-		push(@results, $data);
-	}
-	$sth->finish;
-	#    print DEBUG "getcategoryinfo: exit: returning ".cvs(\@results)."\n";
-	return \@results;
-}
+    $innertemplate->param( printerloop => \@printerloop );
+    # make the checkboxes.....
+    #
+    # We export a "categoryloop" array to the template, each element of which
+    # contains separate 'categoryname', 'categorycode', 'codedescription', and
+    # 'checked' fields. The $checked field is either empty or 1'
 
-# FIXME This doesn't belong here; it should be moved into a module
-sub setbranchinfo {
-# sets the data from the editbranch form, and writes to the database...
-	my ($data) = @_;
-	my $dbh = C4::Context->dbh;
-	my $query = "replace branches (branchcode,branchname,branchaddress1,branchaddress2,branchaddress3,branchphone,branchfax,branchemail) values (?,?,?,?,?,?,?,?)";
-	my $sth=$dbh->prepare($query);
-	$sth->execute(uc($data->{'branchcode'}), $data->{'branchname'},
-		$data->{'branchaddress1'}, $data->{'branchaddress2'},
-		$data->{'branchaddress3'}, $data->{'branchphone'},
-		$data->{'branchfax'}, $data->{'branchemail'});
-
-	$sth->finish;
-	# sort out the categories....
-	my @checkedcats;
-	my $cats = getcategoryinfo();
-	foreach my $cat (@$cats) {
-		my $code = $cat->{'categorycode'};
-		if ($data->{$code}) {
-			push(@checkedcats, $code);
-		}
-	}
-	my $branchcode =uc($data->{'branchcode'});
-	my $branch = getbranchinfo($branchcode);
-	$branch = $branch->[0];
-	my $branchcats = $branch->{'categories'};
-	my @addcats;
-	my @removecats;
-	foreach my $bcat (@$branchcats) {
-		unless (grep {/^$bcat$/} @checkedcats) {
-			push(@removecats, $bcat);
-		}
-	}
-	foreach my $ccat (@checkedcats){
-		unless (grep {/^$ccat$/} @$branchcats) {
-			push(@addcats, $ccat);
-		}
-	}
-	# FIXME - There's already a $dbh in this scope.
-	my $dbh = C4::Context->dbh;
-	foreach my $cat (@addcats) {
-		my $query = "insert into branchrelations (branchcode, categorycode) values(?, ?)";
-		my $sth = $dbh->prepare($query);
-		$sth->execute($branchcode, $cat);
-		$sth->finish;
-	}
-	foreach my $cat (@removecats) {
-		my $query = "delete from branchrelations where branchcode=? and categorycode=?";
-		my $sth = $dbh->prepare($query);
-		$sth->execute($branchcode, $cat);
-		$sth->finish;
-	}
-}
+    my $catinfo = GetBranchCategory();
+    my @categoryloop = ();
+    foreach my $cat (@$catinfo) {
+        my $checked;
+        my $tmp     = quotemeta( $cat->{'categorycode'} );
+        if ( grep { /^$tmp$/ } @{ $data->{'categories'} } ) {
+            $checked = 1;
+        }
+        push @categoryloop, {
+            categoryname    => $cat->{'categoryname'},
+            categorycode    => $cat->{'categorycode'},
+            categorytype    => $cat->{'categorytype'},
+            codedescription => $cat->{'codedescription'},
+            checked         => $checked,
+        };
+    }
+    $innertemplate->param( categoryloop => \@categoryloop );
 
-sub deletebranch {
-# delete branch...
-    my ($branchcode) = @_;
-    my $query = "delete from branches where branchcode = ?";
-    my $dbh = C4::Context->dbh;
-    my $sth=$dbh->prepare($query);
-    $sth->execute($branchcode);
-    $sth->finish;
+    for my $obsolete ( 'categoryname', 'categorycode', 'codedescription' ) {
+        $innertemplate->param(
+            $obsolete => 'Your template is out of date (bug 130)' );
+    }
 }
 
-sub setcategoryinfo {
-# sets the data from the editbranch form, and writes to the database...
-	my ($data) = @_;
-	my $dbh = C4::Context->dbh;
-	my $query = "replace branchcategories (categorycode,categoryname,codedescription) values (?,?,?)";
-	my $sth=$dbh->prepare($query);
-	$sth->execute(uc($data->{'categorycode'}), $data->{'categoryname'},$data->{'codedescription'});
+sub editcatform {
 
-	$sth->finish;
-}
-sub deletecategory {
-# delete branch...
-    my ($categorycode) = @_;
-    my $query = "delete from branchcategories where categorycode = ?";
-    my $dbh = C4::Context->dbh;
-    my $sth=$dbh->prepare($query);
-    $sth->execute($categorycode);
-    $sth->finish;
+    # prepares the edit form...
+    my ($categorycode,$innertemplate) = @_;
+    # warn "cat : $categorycode";
+	my @cats;
+    my $data;
+	if ($categorycode) {
+        my $data = GetBranchCategory($categorycode);
+        $data = $data->[0];
+        $innertemplate->param(
+            categorycode    => $data->{'categorycode'},
+            categoryname    => $data->{'categoryname'},
+            codedescription => $data->{'codedescription'},
+		);
+    }
+	for my $ctype (GetCategoryTypes()) {
+		push @cats , { type => $ctype , selected => ($data->{'categorytype'} and $data->{'categorytype'} eq $ctype) };
+	}
+    $innertemplate->param(categorytype => \@cats);
 }
 
-sub checkdatabasefor {
-# check to see if the branchcode is being used in the database somewhere....
-    my ($branchcode) = @_;
-    my $dbh = C4::Context->dbh;
-    my $sth=$dbh->prepare("select count(*) from items where holdingbranch=? or homebranch=?");
-    $sth->execute($branchcode, $branchcode);
-    my ($total) = $sth->fetchrow_array;
-    $sth->finish;
-    my $message;
-    if ($total) {
-	# FIXME: need to be replaced by an exported boolean parameter
-	$message = "Branch cannot be deleted because there are $total items using that branch.";
+sub branchinfotable {
+
+# makes the html for a table of branch info from reference to an array of hashs.
+
+    my ($branchcode,$innertemplate) = @_;
+    my $branchinfo = $branchcode ? GetBranchInfo($branchcode) : GetBranchInfo();
+    my @loop_data = ();
+    foreach my $branch (@$branchinfo) {
+        #
+        # We export the following fields to the template. These are not
+        # pre-composed as a single "address" field because the template
+        # might (and should) escape what is exported here. (See bug 180)
+        #
+        # - branch_name     (Note: not "branchname")
+        # - branch_code     (Note: not "branchcode")
+        # - address         (containing a static error message)
+        # - branchaddress1 \
+        # - branchaddress2  |
+        # - branchaddress3  | comprising the old "address" field
+        # - branchzip       |
+        # - branchcity      |
+        # - branchcountry   |
+        # - branchphone     |
+        # - branchfax       |
+        # - branchemail    /
+        # - branchurl      /
+        # - address-empty-p (1 if no address information, 0 otherwise)
+        # - categories      (containing a static error message)
+        # - category_list   (loop containing "categoryname")
+        # - no-categories-p (1 if no categories set, 0 otherwise)
+        # - value
+        #
+        my %row = ();
+
+        # Handle address fields separately
+        my $address_empty_p = 1;
+        for my $field (
+            'branchaddress1', 'branchaddress2',
+            'branchaddress3', 'branchzip',
+            'branchcity', 'branchstate', 'branchcountry',
+            'branchphone', 'branchfax',
+            'branchemail', 'branchurl',
+            'branchip',       'branchprinter', 'branchnotes'
+          )
+        {
+            $row{$field} = $branch->{$field};
+            $address_empty_p = 0 if ( $branch->{$field} );
+        }
+        $row{'address-empty-p'} = $address_empty_p;
+
+        # Handle categories
+        my $no_categories_p = 1;
+        my @categories;
+        foreach my $cat ( @{ $branch->{'categories'} } ) {
+            my ($catinfo) = @{ GetBranchCategory($cat) };
+            push @categories, { 'categoryname' => $catinfo->{'categoryname'} };
+            $no_categories_p = 0;
+        }
+
+        $row{'category_list'}   = \@categories;
+        $row{'no-categories-p'} = $no_categories_p;
+        $row{'branch_name'} = $branch->{'branchname'};
+        $row{'branch_code'} = $branch->{'branchcode'};
+        $row{'value'}       = $branch->{'branchcode'};
+
+        push @loop_data, \%row;
     }
-    return $message;
+    my @branchcategories = ();
+	for my $ctype ( GetCategoryTypes() ) {
+    	my $catinfo = GetBranchCategories(undef,$ctype);
+    	my @categories;
+		foreach my $cat (@$catinfo) {
+            push @categories, {
+                categoryname    => $cat->{'categoryname'},
+                categorycode    => $cat->{'categorycode'},
+                codedescription => $cat->{'codedescription'},
+                categorytype    => $cat->{'categorytype'},
+            };
+    	}
+        push @branchcategories, { categorytype => $ctype , $ctype => 1 , catloop => ( @categories ? \@categories : undef) };
+	}
+    $innertemplate->param(
+        branches         => \@loop_data,
+        branchcategories => \@branchcategories
+    );
+
 }
 
-sub checkcategorycode {
-# check to see if the branchcode is being used in the database somewhere....
-    my ($categorycode) = @_;
-    my $dbh = C4::Context->dbh;
-    my $sth=$dbh->prepare("select count(*) from branchrelations where categorycode=?");
-    $sth->execute($categorycode);
-    my ($total) = $sth->fetchrow_array;
-    $sth->finish;
-    my $message;
-    if ($total) {
-	# FIXME: need to be replaced by an exported boolean parameter
-	$message = "Category cannot be deleted because there are $total branches using that category.";
-    }
-    return $message;
+sub _branch_to_template {
+    my ($data, $template) = @_;
+    $template->param( 
+         branchcode     => $data->{'branchcode'},
+         branch_name    => $data->{'branchname'},
+         branchaddress1 => $data->{'branchaddress1'},
+         branchaddress2 => $data->{'branchaddress2'},
+         branchaddress3 => $data->{'branchaddress3'},
+         branchzip      => $data->{'branchzip'},
+         branchcity     => $data->{'branchcity'},
+         branchstate    => $data->{'branchstate'},
+         branchcountry  => $data->{'branchcountry'},
+         branchphone    => $data->{'branchphone'},
+         branchfax      => $data->{'branchfax'},
+         branchemail    => $data->{'branchemail'},
+         branchurl      => $data->{'branchurl'},
+         branchip       => $data->{'branchip'},
+         branchnotes    => $data->{'branchnotes'}, 
+    );
 }
 
 output_html_with_http_headers $input, $cookie, $template->output;