X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=admin%2Fbranches.pl;h=12c49e28ba3dbd80b4e3a0d6ed9bc27241495992;hb=e012957186426b9577bfc8498c5971990b258024;hp=f4bcf661ad3e631c4f52c62d7c971424b07bd65c;hpb=f9f35b69849dca8705df98ff0a21d2b2b1171cc8;p=koha.git diff --git a/admin/branches.pl b/admin/branches.pl index f4bcf661ad..12c49e28ba 100755 --- a/admin/branches.pl +++ b/admin/branches.pl @@ -189,12 +189,10 @@ elsif ( $op eq 'addcategory_validate' ) { elsif ( $op eq 'delete_category' ) { # if the user has pressed the "delete branch" button. - my $message = "MESSAGE8" if CheckBranchCategorycode($categorycode); - if ($message) { + if ( CheckBranchCategorycode($categorycode) ) { $template->param( else => 1 ); - default($message,$template); - } - else { + default( 'MESSAGE8', $template ); + } else { $template->param( delete_category => 1 ); $template->param( categorycode => $categorycode ); } @@ -256,15 +254,15 @@ sub editbranchform { # # We export a "categoryloop" array to the template, each element of which # contains separate 'categoryname', 'categorycode', 'codedescription', and - # 'checked' fields. The $checked field is either '' or 'checked="checked"' + # 'checked' fields. The $checked field is either empty or 1' my $catinfo = GetBranchCategory(); my @categoryloop = (); foreach my $cat (@$catinfo) { - my $checked = ""; + my $checked; my $tmp = quotemeta( $cat->{'categorycode'} ); if ( grep { /^$tmp$/ } @{ $data->{'categories'} } ) { - $checked = "checked=\"checked\""; + $checked = 1; } push @categoryloop, { categoryname => $cat->{'categoryname'}, @@ -343,7 +341,7 @@ sub branchinfotable { for my $field ( 'branchaddress1', 'branchaddress2', 'branchaddress3', 'branchzip', - 'branchcity', 'branchcountry', + 'branchcity', 'branchstate', 'branchcountry', 'branchphone', 'branchfax', 'branchemail', 'branchurl', 'branchip', 'branchprinter', 'branchnotes' @@ -383,7 +381,7 @@ sub branchinfotable { categorytype => $cat->{'categorytype'}, }; } - push @branchcategories, { categorytype => $ctype , $ctype => 1 , catloop => \@categories}; + push @branchcategories, { categorytype => $ctype , $ctype => 1 , catloop => ( @categories ? \@categories : undef) }; } $innertemplate->param( branches => \@loop_data, @@ -402,6 +400,7 @@ sub _branch_to_template { branchaddress3 => $data->{'branchaddress3'}, branchzip => $data->{'branchzip'}, branchcity => $data->{'branchcity'}, + branchstate => $data->{'branchstate'}, branchcountry => $data->{'branchcountry'}, branchphone => $data->{'branchphone'}, branchfax => $data->{'branchfax'},