X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=admin%2Fbranches.pl;h=ab1021cdf67ba3c58561d93b001367fee3667a08;hb=56c50a66169f956584050a8630a71cfa7d5984cb;hp=12c49e28ba3dbd80b4e3a0d6ed9bc27241495992;hpb=68de42d59d7070bc58f25cb13ad159d8c70aafc6;p=koha.git diff --git a/admin/branches.pl b/admin/branches.pl index 12c49e28ba..ab1021cdf6 100755 --- a/admin/branches.pl +++ b/admin/branches.pl @@ -1,418 +1,159 @@ #!/usr/bin/perl # Copyright 2000-2002 Katipo Communications +# Copyright 2015 Koha Development Team # # This file is part of Koha. # -# Koha is free software; you can redistribute it and/or modify it under the -# terms of the GNU General Public License as published by the Free Software -# Foundation; either version 2 of the License, or (at your option) any later -# version. +# Koha is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. # -# Koha is distributed in the hope that it will be useful, but WITHOUT ANY -# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR -# A PARTICULAR PURPOSE. See the GNU General Public License for more details. +# Koha is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. # -# You should have received a copy of the GNU General Public License along -# with Koha; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +# You should have received a copy of the GNU General Public License +# along with Koha; if not, see . -=head1 branches.pl - - FIXME: individual fields in branch address need to be exported to templates, - in order to fix bug 180; need to notify translators - FIXME: looped html (e.g., list of checkboxes) need to be properly - TMPL_LOOP'ized; doing this properly will fix bug 130; need to - notify translators - FIXME: need to implement the branch categories stuff - FIXME: there are too many TMPL_IF's; the proper way to do it is to have - separate templates for each individual action; need to notify - translators - FIXME: there are lots of error messages exported to the template; a lot - of these should be converted into exported booleans / counters etc - so that the error messages can be localized; need to notify translators - - Finlay working on this file from 26-03-2002 - Reorganising this branches admin page..... - -=cut - -use strict; -use warnings; -use CGI; +use Modern::Perl; +use CGI qw ( -utf8 ); use C4::Auth; use C4::Context; use C4::Output; use C4::Koha; -use C4::Branch; - -# Fixed variables -my $script_name = "/cgi-bin/koha/admin/branches.pl"; +use Koha::Patrons; +use Koha::Items; +use Koha::Libraries; -################################################################################ -# Main loop.... my $input = new CGI; my $branchcode = $input->param('branchcode'); -my $branchname = $input->param('branchname'); my $categorycode = $input->param('categorycode'); -my $op = $input->param('op') || ''; +my $op = $input->param('op') || 'list'; +my @messages; my ( $template, $borrowernumber, $cookie ) = get_template_and_user( - { - template_name => "admin/branches.tmpl", + { template_name => "admin/branches.tt", query => $input, type => "intranet", authnotrequired => 0, - flagsrequired => { parameters => 1}, + flagsrequired => { parameters => 'parameters_remaining_permissions' }, debug => 1, } ); -$template->param( - script_name => $script_name, - action => $script_name, -); -$template->param( ($op || 'else') => 1 ); - -if ( $op eq 'add' ) { - # If the user has pressed the "add new branch" button. - $template->param( 'heading_branches_add_branch_p' => 1 ); - editbranchform($branchcode,$template); - -} -elsif ( $op eq 'edit' ) { +if ( $op eq 'add_form' ) { + my $library; + if ($branchcode) { + $library = Koha::Libraries->find($branchcode); + } - # if the user has pressed the "edit branch settings" button. - $template->param( 'heading_branches_add_branch_p' => 0, - 'add' => 1, ); - editbranchform($branchcode,$template); -} -elsif ( $op eq 'add_validate' ) { + $template->param( + library => $library, + ); +} elsif ( $op eq 'add_validate' ) { + my @fields = qw( + branchname + branchaddress1 + branchaddress2 + branchaddress3 + branchzip + branchcity + branchstate + branchcountry + branchphone + branchfax + branchemail + branchreplyto + branchreturnpath + branchurl + issuing + branchip + branchnotes + opac_info + marcorgcode + ); + my $is_a_modif = $input->param('is_a_modif'); - # confirm settings change... - my $params = $input->Vars; - unless ( $params->{'branchcode'} && $params->{'branchname'} ) { - $template->param( else => 1 ); - default("MESSAGE1",$template); - } - else { - my $mod_branch = 1; - if ($params->{add}) { - my ($existing) = - C4::Context->dbh->selectrow_array("SELECT count(*) FROM branches WHERE branchcode = ?", {}, $branchcode); - if ($existing > 0) { - $mod_branch = 0; - _branch_to_template($params, $template); # preserve most (FIXME) of user's input - $template->param( 'heading_branches_add_branch_p' => 1, 'add' => 1, 'ERROR1' => 1 ); - } + if ($is_a_modif) { + my $library = Koha::Libraries->find($branchcode); + for my $field (@fields) { + $library->$field( scalar $input->param($field) ); } - if ($mod_branch) { - my $error = ModBranch($params); # FIXME: causes warnings to log on duplicate branchcode - # if error saving, stay on edit and rise error - if ($error) { - # copy input parameters back to form - # FIXME - doing this doesn't preserve any branch group selections, but good enough for now - editbranchform($branchcode,$template); - $template->param( 'heading_branches_add_branch_p' => 1, 'add' => 1, "ERROR$error" => 1 ); - } else { - $template->param( else => 1); - default("MESSAGE2",$template); - } + eval { $library->store; }; + if ($@) { + push @messages, { type => 'alert', code => 'error_on_update' }; + } else { + push @messages, { type => 'message', code => 'success_on_update' }; } - } -} -elsif ( $op eq 'delete' ) { - # if the user has pressed the "delete branch" button. - - # check to see if the branchcode is being used in the database somewhere.... - my $dbh = C4::Context->dbh; - my $sthitems = $dbh->prepare("select count(*) from items where holdingbranch=? or homebranch=?"); - my $sthborrowers = $dbh->prepare("select count(*) from borrowers where branchcode=?"); - $sthitems->execute( $branchcode, $branchcode ); - $sthborrowers->execute( $branchcode ); - my ($totalitems) = $sthitems->fetchrow_array; - my ($totalborrowers) = $sthborrowers->fetchrow_array; - if ($totalitems && !$totalborrowers) { - $template->param( else => 1 ); - default("MESSAGE10", $template); - } - elsif (!$totalitems && $totalborrowers){ - $template->param( else => 1 ); - default("MESSAGE11", $template); - } - elsif ($totalitems && $totalborrowers){ - $template->param( else => 1 ); - default("MESSAGE7", $template); - } - else { - $template->param( delete_confirm => 1 ); - $template->param( branchname => $branchname ); - $template->param( branchcode => $branchcode ); - } -} -elsif ( $op eq 'delete_confirmed' ) { - - # actually delete branch and return to the main screen.... - DelBranch($branchcode); - $template->param( else => 1 ); - default("MESSAGE3",$template); -} -elsif ( $op eq 'editcategory' ) { - - # If the user has pressed the "add new category" or "modify" buttons. - $template->param( 'heading_branches_edit_category_p' => 1 ); - editcatform($categorycode,$template); -} -elsif ( $op eq 'addcategory_validate' ) { - - $template->param( else => 1 ); - # confirm settings change... - my $params = $input->Vars; - unless ( $params->{'categorycode'} && $params->{'categoryname'} ) { - default("MESSAGE4",$template); - } - elsif ($input->param('add')){ - # doing an add must check the code is unique - if (CheckCategoryUnique($input->param('categorycode'))){ - ModBranchCategoryInfo($params); - default("MESSAGE5",$template); - } - else { - default("MESSAGE9",$template); - } - } - else { - ModBranchCategoryInfo($params); - default("MESSAGE5",$template); - } -} -elsif ( $op eq 'delete_category' ) { - - # if the user has pressed the "delete branch" button. - if ( CheckBranchCategorycode($categorycode) ) { - $template->param( else => 1 ); - default( 'MESSAGE8', $template ); } else { - $template->param( delete_category => 1 ); - $template->param( categorycode => $categorycode ); - } -} -elsif ( $op eq 'categorydelete_confirmed' ) { - - # actually delete branch and return to the main screen.... - DelBranchCategory($categorycode); - $template->param( else => 1 ); - default("MESSAGE6",$template); - -} -else { - # if no operation has been set... - default("",$template); -} - -################################################################################ -# -# html output functions.... - -sub default { - my $message = shift || ''; - my $innertemplate = shift or return; - $innertemplate->param($message => 1) if $message; - $innertemplate->param( - 'heading_branches_p' => 1, - ); - branchinfotable("",$innertemplate); -} - -sub editbranchform { - my ($branchcode,$innertemplate) = @_; - # initiate the scrolling-list to select the printers - my $printers = GetPrinters(); - my @printerloop; - my $data; - my $oldprinter = ""; - - if ($branchcode) { - $data = GetBranchInfo($branchcode); - $data = $data->[0]; - - # get the old printer of the branch - $oldprinter = $data->{'branchprinter'} || ''; - _branch_to_template($data, $innertemplate); - } - - foreach my $thisprinter ( keys %$printers ) { - push @printerloop, { - value => $thisprinter, - selected => ( $oldprinter eq $printers->{$thisprinter} ), - branchprinter => $printers->{$thisprinter}->{'printqueue'}, - }; - } - - $innertemplate->param( printerloop => \@printerloop ); - # make the checkboxes..... - # - # We export a "categoryloop" array to the template, each element of which - # contains separate 'categoryname', 'categorycode', 'codedescription', and - # 'checked' fields. The $checked field is either empty or 1' - - my $catinfo = GetBranchCategory(); - my @categoryloop = (); - foreach my $cat (@$catinfo) { - my $checked; - my $tmp = quotemeta( $cat->{'categorycode'} ); - if ( grep { /^$tmp$/ } @{ $data->{'categories'} } ) { - $checked = 1; + $branchcode =~ s|\s||g; + my $library = Koha::Library->new( + { branchcode => $branchcode, + ( map { $_ => scalar $input->param($_) || undef } @fields ) + } + ); + eval { $library->store; }; + if ($@) { + push @messages, { type => 'alert', code => 'error_on_insert' }; + } else { + push @messages, { type => 'message', code => 'success_on_insert' }; } - push @categoryloop, { - categoryname => $cat->{'categoryname'}, - categorycode => $cat->{'categorycode'}, - categorytype => $cat->{'categorytype'}, - codedescription => $cat->{'codedescription'}, - checked => $checked, - }; } - $innertemplate->param( categoryloop => \@categoryloop ); - - for my $obsolete ( 'categoryname', 'categorycode', 'codedescription' ) { - $innertemplate->param( - $obsolete => 'Your template is out of date (bug 130)' ); + $op = 'list'; +} elsif ( $op eq 'delete_confirm' ) { + my $library = Koha::Libraries->find($branchcode); + my $items_count = Koha::Items->search( + { -or => { + holdingbranch => $branchcode, + homebranch => $branchcode + }, + } + )->count; + my $patrons_count = Koha::Patrons->search( { branchcode => $branchcode, } )->count; + + if ( $items_count or $patrons_count ) { + push @messages, + { type => 'alert', + code => 'cannot_delete_library', + data => { + items_count => $items_count, + patrons_count => $patrons_count, + }, + }; + $op = 'list'; + } else { + $template->param( + library => $library, + items_count => $items_count, + patrons_count => $patrons_count, + ); } -} +} elsif ( $op eq 'delete_confirmed' ) { + my $library = Koha::Libraries->find($branchcode); -sub editcatform { + my $deleted = eval { $library->delete; }; - # prepares the edit form... - my ($categorycode,$innertemplate) = @_; - # warn "cat : $categorycode"; - my @cats; - my $data; - if ($categorycode) { - my $data = GetBranchCategory($categorycode); - $data = $data->[0]; - $innertemplate->param( - categorycode => $data->{'categorycode'}, - categoryname => $data->{'categoryname'}, - codedescription => $data->{'codedescription'}, - ); + if ( $@ or not $deleted ) { + push @messages, { type => 'alert', code => 'error_on_delete' }; + } else { + push @messages, { type => 'message', code => 'success_on_delete' }; } - for my $ctype (GetCategoryTypes()) { - push @cats , { type => $ctype , selected => ($data->{'categorytype'} and $data->{'categorytype'} eq $ctype) }; - } - $innertemplate->param(categorytype => \@cats); + $op = 'list'; +} else { + $op = 'list'; } -sub branchinfotable { - -# makes the html for a table of branch info from reference to an array of hashs. - - my ($branchcode,$innertemplate) = @_; - my $branchinfo = $branchcode ? GetBranchInfo($branchcode) : GetBranchInfo(); - my @loop_data = (); - foreach my $branch (@$branchinfo) { - # - # We export the following fields to the template. These are not - # pre-composed as a single "address" field because the template - # might (and should) escape what is exported here. (See bug 180) - # - # - branch_name (Note: not "branchname") - # - branch_code (Note: not "branchcode") - # - address (containing a static error message) - # - branchaddress1 \ - # - branchaddress2 | - # - branchaddress3 | comprising the old "address" field - # - branchzip | - # - branchcity | - # - branchcountry | - # - branchphone | - # - branchfax | - # - branchemail / - # - branchurl / - # - address-empty-p (1 if no address information, 0 otherwise) - # - categories (containing a static error message) - # - category_list (loop containing "categoryname") - # - no-categories-p (1 if no categories set, 0 otherwise) - # - value - # - my %row = (); - - # Handle address fields separately - my $address_empty_p = 1; - for my $field ( - 'branchaddress1', 'branchaddress2', - 'branchaddress3', 'branchzip', - 'branchcity', 'branchstate', 'branchcountry', - 'branchphone', 'branchfax', - 'branchemail', 'branchurl', - 'branchip', 'branchprinter', 'branchnotes' - ) - { - $row{$field} = $branch->{$field}; - $address_empty_p = 0 if ( $branch->{$field} ); - } - $row{'address-empty-p'} = $address_empty_p; - - # Handle categories - my $no_categories_p = 1; - my @categories; - foreach my $cat ( @{ $branch->{'categories'} } ) { - my ($catinfo) = @{ GetBranchCategory($cat) }; - push @categories, { 'categoryname' => $catinfo->{'categoryname'} }; - $no_categories_p = 0; - } - - $row{'category_list'} = \@categories; - $row{'no-categories-p'} = $no_categories_p; - $row{'branch_name'} = $branch->{'branchname'}; - $row{'branch_code'} = $branch->{'branchcode'}; - $row{'value'} = $branch->{'branchcode'}; - - push @loop_data, \%row; - } - my @branchcategories = (); - for my $ctype ( GetCategoryTypes() ) { - my $catinfo = GetBranchCategories(undef,$ctype); - my @categories; - foreach my $cat (@$catinfo) { - push @categories, { - categoryname => $cat->{'categoryname'}, - categorycode => $cat->{'categorycode'}, - codedescription => $cat->{'codedescription'}, - categorytype => $cat->{'categorytype'}, - }; - } - push @branchcategories, { categorytype => $ctype , $ctype => 1 , catloop => ( @categories ? \@categories : undef) }; - } - $innertemplate->param( - branches => \@loop_data, - branchcategories => \@branchcategories - ); - +if ( $op eq 'list' ) { + my $libraries = Koha::Libraries->search( {}, { order_by => ['branchcode'] }, ); + $template->param( libraries => $libraries, ); } -sub _branch_to_template { - my ($data, $template) = @_; - $template->param( - branchcode => $data->{'branchcode'}, - branch_name => $data->{'branchname'}, - branchaddress1 => $data->{'branchaddress1'}, - branchaddress2 => $data->{'branchaddress2'}, - branchaddress3 => $data->{'branchaddress3'}, - branchzip => $data->{'branchzip'}, - branchcity => $data->{'branchcity'}, - branchstate => $data->{'branchstate'}, - branchcountry => $data->{'branchcountry'}, - branchphone => $data->{'branchphone'}, - branchfax => $data->{'branchfax'}, - branchemail => $data->{'branchemail'}, - branchurl => $data->{'branchurl'}, - branchip => $data->{'branchip'}, - branchnotes => $data->{'branchnotes'}, - ); -} +$template->param( + messages => \@messages, + op => $op, +); output_html_with_http_headers $input, $cookie, $template->output; - -# Local Variables: -# tab-width: 8 -# End: