X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=circ%2Freturns.pl;h=63cf75b10b610924d619544eb8b70d1602c4fdc0;hb=ff7bf419872a9ef394600f46348622244963324f;hp=e849a46e1a76dd26e89d17f29f222ca12265fa79;hpb=f3322257d5a2fe003656a25ce3f519c9c5690f70;p=koha.git diff --git a/circ/returns.pl b/circ/returns.pl index e849a46e1a..63cf75b10b 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -27,11 +27,9 @@ script to execute returns of books =cut -use strict; -use warnings; +use Modern::Perl; -use Carp 'verbose'; -$SIG{ __DIE__ } = sub { Carp::confess( @_ ) }; +# FIXME There are weird things going on with $patron and $borrowernumber in this script use CGI qw ( -utf8 ); use DateTime; @@ -47,13 +45,18 @@ use C4::Members; use C4::Members::Messaging; use C4::Koha; # FIXME : is it still useful ? use C4::RotatingCollections; +use Koha::AuthorisedValues; use Koha::DateUtils; use Koha::Calendar; +use Koha::BiblioFrameworks; +use Koha::Holds; +use Koha::Items; +use Koha::Patrons; my $query = new CGI; #getting the template -my ( $template, $librarian, $cookie ) = get_template_and_user( +my ( $template, $librarian, $cookie, $flags ) = get_template_and_user( { template_name => "circ/returns.tt", query => $query, @@ -75,8 +78,9 @@ if ($session->param('branch') eq 'NO_LIBRARY_SET'){ if ( $query->param('print_slip') ) { $template->param( print_slip => 1, - borrowernumber => scalar $query->param('borrowernumber'), + borrowernumber => scalar $query->param('borrowernumber'), # FIXME We should send a Koha::Patron and raise an error if not exist. biblionumber => scalar $query->param('biblionumber'), + itemnumber => scalar $query->param('itemnumber'), ); } @@ -89,7 +93,7 @@ my $printer = $userenv->{'branchprinter'} // ''; my $forgivemanualholdsexpire = $query->param('forgivemanualholdsexpire'); my $overduecharges = (C4::Context->preference('finesMode') && C4::Context->preference('finesMode') ne 'off'); -# + # # Some code to handle the error if there is no branch or printer setting..... # @@ -142,40 +146,39 @@ if ($query->param('WT-itemNumber')){ } if ( $query->param('reserve_id') ) { - my $item = $query->param('itemnumber'); + my $itemnumber = $query->param('itemnumber'); my $borrowernumber = $query->param('borrowernumber'); my $reserve_id = $query->param('reserve_id'); my $diffBranchReturned = $query->param('diffBranch'); - my $iteminfo = GetBiblioFromItemNumber($item); my $cancel_reserve = $query->param('cancel_reserve'); # fix up item type for display - $iteminfo->{'itemtype'} = C4::Context->preference('item-level_itypes') ? $iteminfo->{'itype'} : $iteminfo->{'itemtype'}; + my $item = Koha::Items->find( $itemnumber ); + my $biblio = $item->biblio; if ( $cancel_reserve ) { - CancelReserve({ reserve_id => $reserve_id, charge_cancel_fee => !$forgivemanualholdsexpire }); + my $hold = Koha::Holds->find( $reserve_id ); + if ( $hold ) { + $hold->cancel( { charge_cancel_fee => !$forgivemanualholdsexpire } ); + } # FIXME else? } else { my $diffBranchSend = ($userenv_branch ne $diffBranchReturned) ? $diffBranchReturned : undef; # diffBranchSend tells ModReserveAffect whether document is expected in this library or not, # i.e., whether to apply waiting status - ModReserveAffect( $item, $borrowernumber, $diffBranchSend, $reserve_id ); + ModReserveAffect( $itemnumber, $borrowernumber, $diffBranchSend, $reserve_id ); } # check if we have other reserves for this document, if we have a return send the message of transfer - my ( $messages, $nextreservinfo ) = GetOtherReserves($item); + my ( $messages, $nextreservinfo ) = GetOtherReserves($itemnumber); - my $borr = GetMember( borrowernumber => $nextreservinfo ); - my $name = $borr->{'surname'} . ", " . $borr->{'title'} . " " . $borr->{'firstname'}; + my $patron = Koha::Patrons->find( $nextreservinfo ); + my $name = $patron ? $patron->surname . ", " . $patron->title . " " . $patron->firstname : ''; if ( $messages->{'transfert'} ) { $template->param( - itemtitle => $iteminfo->{'title'}, - itemnumber => $iteminfo->{'itemnumber'}, - itembiblionumber => $iteminfo->{'biblionumber'}, - iteminfo => $iteminfo->{'author'}, + itemtitle => $biblio->title, + itemnumber => $item->itemnumber, + itembiblionumber => $biblio->biblionumber, + iteminfo => $biblio->author, name => $name, - borrowernumber => $borrowernumber, - borcnum => $borr->{'cardnumber'}, - borfirstname => $borr->{'firstname'}, - borsurname => $borr->{'surname'}, - borcategory => $borr->{'description'}, + patron => $patron, diffbranch => 1, ); } @@ -184,7 +187,7 @@ if ( $query->param('reserve_id') ) { my $borrower; my $returned = 0; my $messages; -my $issueinformation; +my $issue; my $itemnumber; my $barcode = $query->param('barcode'); my $exemptfine = $query->param('exemptfine'); @@ -252,51 +255,45 @@ my $returnbranch; if ($barcode) { $barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace $barcode = barcodedecode($barcode) if C4::Context->preference('itemBarcodeInputFilter'); - $itemnumber = GetItemnumberFromBarcode($barcode); + my $item = Koha::Items->find({ barcode => $barcode }); + + if ( $item ) { + $itemnumber = $item->itemnumber; + # Check if we should display a checkin message, based on the the item + # type of the checked in item + my $itemtype = Koha::ItemTypes->find( $item->effective_itemtype ); + if ( $itemtype && $itemtype->checkinmsg ) { + $template->param( + checkinmsg => $itemtype->checkinmsg, + checkinmsgtype => $itemtype->checkinmsgtype, + ); + } -# -# save the return -# + # make sure return branch respects home branch circulation rules, default to homebranch + my $hbr = GetBranchItemRule($item->homebranch, $itemtype ? $itemtype->itemtype : undef )->{'returnbranch'} || "homebranch"; + $returnbranch = $hbr ne 'noreturn' ? $item->$hbr : $userenv_branch; # can be noreturn, homebranch or holdingbranch - # get biblio description - my $biblio = GetBiblioFromItemNumber($itemnumber); - # fix up item type for display - $biblio->{'itemtype'} = C4::Context->preference('item-level_itypes') ? $biblio->{'itype'} : $biblio->{'itemtype'}; + my $materials = $item->materials; + my $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => '', kohafield =>'items.materials', authorised_value => $materials }); + $materials = $descriptions->{lib} // $materials; - # Check if we should display a checkin message, based on the the item - # type of the checked in item - my $itemtype = Koha::ItemTypes->find( $biblio->{'itemtype'} ); - if ( $itemtype && $itemtype->checkinmsg ) { + my $checkout = $item->checkout; + my $biblio = $item->biblio; $template->param( - checkinmsg => $itemtype->checkinmsg, - checkinmsgtype => $itemtype->checkinmsgtype, + title => $biblio->title, + homebranch => $item->homebranch, + holdingbranch => $item->holdingbranch, + returnbranch => $returnbranch, + author => $biblio->author, + itembarcode => $item->barcode, + itemtype => $item->effective_itemtype, + ccode => $item->ccode, + itembiblionumber => $biblio->biblionumber, + biblionumber => $biblio->biblionumber, + additional_materials => $materials, + issue => $checkout, ); - } - - # make sure return branch respects home branch circulation rules, default to homebranch - my $hbr = GetBranchItemRule($biblio->{'homebranch'}, $itemtype ? $itemtype->itemtype : undef )->{'returnbranch'} || "homebranch"; - $returnbranch = $biblio->{$hbr}; - - my $materials = $biblio->{'materials'}; - my $avcode = GetAuthValCode('items.materials'); - if ($avcode) { - $materials = GetKohaAuthorisedValueLib($avcode, $materials); - } - - $template->param( - title => $biblio->{'title'}, - homebranch => $biblio->{'homebranch'}, - holdingbranch => $biblio->{'holdingbranch'}, - returnbranch => $returnbranch, - author => $biblio->{'author'}, - itembarcode => $biblio->{'barcode'}, - itemtype => $biblio->{'itemtype'}, - ccode => $biblio->{'ccode'}, - itembiblionumber => $biblio->{'biblionumber'}, - biblionumber => $biblio->{'biblionumber'}, - borrower => $borrower, - additional_materials => $materials, - ); + } # FIXME else we should not call AddReturn but set BadBarcode directly instead my %input = ( counter => 0, @@ -304,42 +301,41 @@ if ($barcode) { barcode => $barcode, ); + # do the return - ( $returned, $messages, $issueinformation, $borrower ) = + ( $returned, $messages, $issue, $borrower ) = AddReturn( $barcode, $userenv_branch, $exemptfine, $dropboxmode, $return_date_override, $dropboxdate ); if ($returned) { my $time_now = DateTime->now( time_zone => C4::Context->tz )->truncate( to => 'minute'); - my $duedate = $issueinformation->{date_due}->strftime('%Y-%m-%d %H:%M'); + my $date_due_dt = dt_from_string( $issue->date_due, 'sql' ); + my $duedate = $date_due_dt->strftime('%Y-%m-%d %H:%M'); $returneditems{0} = $barcode; $riborrowernumber{0} = $borrower->{'borrowernumber'}; $riduedate{0} = $duedate; $input{borrowernumber} = $borrower->{'borrowernumber'}; $input{duedate} = $duedate; unless ( $dropboxmode ) { - $input{return_overdue} = 1 if (DateTime->compare($issueinformation->{date_due}, DateTime->now()) == -1); + $input{return_overdue} = 1 if (DateTime->compare($date_due_dt, DateTime->now()) == -1); } else { - $input{return_overdue} = 1 if (DateTime->compare($issueinformation->{date_due}, $dropboxdate) == -1); + $input{return_overdue} = 1 if (DateTime->compare($date_due_dt, $dropboxdate) == -1); } push( @inputloop, \%input ); if ( C4::Context->preference("FineNotifyAtCheckin") ) { - my ( $od, $issue, $fines ) = GetMemberIssuesAndFines( $borrower->{'borrowernumber'} ); - if ($fines && $fines > 0) { - $template->param( fines => sprintf("%.2f",$fines) ); + my $patron = Koha::Patrons->find( $borrower->{borrowernumber} ); + my $balance = $patron->account->balance; + + if ($balance > 0) { + $template->param( fines => sprintf("%.2f", $balance) ); $template->param( fineborrowernumber => $borrower->{'borrowernumber'} ); } } if (C4::Context->preference("WaitingNotifyAtCheckin") ) { #Check for waiting holds - my @reserves = GetReservesFromBorrowernumber($borrower->{'borrowernumber'}); - my $waiting_holds = 0; - foreach my $num_res (@reserves) { - if ( $num_res->{'found'} eq 'W' && $num_res->{'branchcode'} eq $userenv_branch) { - $waiting_holds++; - } - } + my $patron = Koha::Patrons->find( $borrower->{borrowernumber} ); + my $waiting_holds = $patron->holds->search({ found => 'W', branchcode => $userenv_branch })->count; if ($waiting_holds > 0) { $template->param( waiting_holds => $waiting_holds, @@ -364,7 +360,7 @@ my $waiting = 0; my $reserved = 0; # new op dev : we check if the document must be returned to his homebranch directly, -# if the document is transfered, we have warning message . +# if the document is transferred, we have warning message . if ( $messages->{'WasTransfered'} ) { $template->param( @@ -389,7 +385,7 @@ if ( $messages->{'Wrongbranch'} ){ ); } -# case of wrong transfert, if the document wasn't transfered to the right library (according to branchtransfer (tobranch) BDD) +# case of wrong transfert, if the document wasn't transferred to the right library (according to branchtransfer (tobranch) BDD) if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'}) { $template->param( @@ -400,24 +396,15 @@ if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'}) { ); my $reserve = $messages->{'ResFound'}; - my $borr = C4::Members::GetMember( borrowernumber => $reserve->{'borrowernumber'} ); - my $name = $borr->{'surname'} . ", " . $borr->{'title'} . " " . $borr->{'firstname'}; + if ( $reserve ) { + my $patron = Koha::Patrons->find( $reserve->{'borrowernumber'} ); + my $name = $patron->surname . ", " . $patron->title . " " . $patron->firstname; + $template->param( + patron => $patron, + ); + } $template->param( - wname => $name, - wborfirstname => $borr->{'firstname'}, - wborsurname => $borr->{'surname'}, - wborcategory => $borr->{'description'}, - wbortitle => $borr->{'title'}, - wborphone => $borr->{'phone'}, - wboremail => $borr->{'email'}, - wborstnum => $borr->{streetnumber}, - wboraddress => $borr->{'address'}, - wboraddress2 => $borr->{'address2'}, - wborcity => $borr->{'city'}, - wborzip => $borr->{'zipcode'}, - wborrowernumber => $reserve->{'borrowernumber'}, - wborcnum => $borr->{'cardnumber'}, - wtransfertFrom => $userenv_branch, + wtransfertFrom => $userenv_branch, ); } @@ -426,9 +413,38 @@ if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'}) { # if ( $messages->{'ResFound'}) { my $reserve = $messages->{'ResFound'}; - my $borr = C4::Members::GetMember( borrowernumber => $reserve->{'borrowernumber'} ); + my $patron = Koha::Patrons->find( $reserve->{borrowernumber} ); my $holdmsgpreferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $reserve->{'borrowernumber'}, message_name => 'Hold_Filled' } ); - if ( $reserve->{'ResFound'} eq "Waiting" or $reserve->{'ResFound'} eq "Reserved" ) { + + if ( $reserve->{'ResFound'} eq "Reserved" && C4::Context->preference('HoldsAutoFill') ) { + my $item = Koha::Items->find( $itemnumber ); + my $biblio = $item->biblio; + + my $diffBranchSend = ($userenv_branch ne $reserve->{branchcode}) ? $reserve->{branchcode} : undef; + ModReserveAffect( $reserve->{itemnumber}, $reserve->{borrowernumber}, $diffBranchSend, $reserve->{reserve_id} ); + my ( $messages, $nextreservinfo ) = GetOtherReserves($reserve->{itemnumber}); + + my $patron = Koha::Patrons->find( $nextreservinfo ); + + $template->param( + hold_auto_filled => 1, + print_slip => C4::Context->preference('HoldsAutoFillPrintSlip'), + patron => $patron, + borrowernumber => $patron->id, + biblionumber => $biblio->id, + ); + + if ( $messages->{'transfert'} ) { + $template->param( + itemtitle => $biblio->title, + itemnumber => $item->itemnumber, + itembiblionumber => $biblio->biblionumber, + iteminfo => $biblio->author, + diffbranch => 1, + ); + } + } + elsif ( $reserve->{'ResFound'} eq "Waiting" or $reserve->{'ResFound'} eq "Reserved" ) { if ( $reserve->{'ResFound'} eq "Waiting" ) { $template->param( waiting => ($userenv_branch eq $reserve->{'branchcode'} ? 1 : 0 ), @@ -442,32 +458,19 @@ if ( $messages->{'ResFound'}) { ); } - # same params for Waiting or Reserved - $template->param( - found => 1, - name => $borr->{'surname'} . ", " . $borr->{'title'} . " " . $borr->{'firstname'}, - borfirstname => $borr->{'firstname'}, - borsurname => $borr->{'surname'}, - borcategory => $borr->{'description'}, - bortitle => $borr->{'title'}, - borphone => $borr->{'phone'}, - boremail => $borr->{'email'}, - boraddress => $borr->{'address'}, - boraddress2 => $borr->{'address2'}, - borstnum => $borr->{streetnumber}, - borcity => $borr->{'city'}, - borzip => $borr->{'zipcode'}, - borcnum => $borr->{'cardnumber'}, - debarred => $borr->{'debarred'}, - gonenoaddress => $borr->{'gonenoaddress'}, - barcode => $barcode, - destbranch => $reserve->{'branchcode'}, - borrowernumber => $reserve->{'borrowernumber'}, - itemnumber => $reserve->{'itemnumber'}, - reservenotes => $reserve->{'reservenotes'}, - bormessagepref => $holdmsgpreferences->{'transports'}, - ); } # else { ; } # error? + + # same params for Waiting or Reserved + $template->param( + found => 1, + patron => $patron, + barcode => $barcode, + destbranch => $reserve->{'branchcode'}, + itemnumber => $reserve->{'itemnumber'}, + reservenotes => $reserve->{'reservenotes'}, + reserve_id => $reserve->{reserve_id}, + bormessagepref => $holdmsgpreferences->{'transports'}, + ); } # Error Messages @@ -482,13 +485,13 @@ foreach my $code ( keys %$messages ) { elsif ( $code eq 'NotIssued' ) { $err{notissued} = 1; $err{msg} = ''; - $err{msg} = $messages->{'IsPermanent'} if $messages->{'IsPermanent'}; } elsif ( $code eq 'LocalUse' ) { $err{localuse} = 1; } elsif ( $code eq 'WasLost' ) { $err{waslost} = 1; + $exit_required_p = 1 if C4::Context->preference("BlockReturnOfLostItems"); } elsif ( $code eq 'LostItemFeeRefunded' ) { $template->param( LostItemFeeRefunded => 1 ); @@ -506,12 +509,6 @@ foreach my $code ( keys %$messages ) { $err{withdrawn} = 1; $exit_required_p = 1 if C4::Context->preference("BlockReturnOfWithdrawnItems"); } - elsif ( ( $code eq 'IsPermanent' ) && ( not $messages->{'ResFound'} ) ) { - if ( $messages->{'IsPermanent'} ne $userenv_branch ) { - $err{ispermanent} = 1; - $err{msg} = $messages->{'IsPermanent'}; - } - } elsif ( $code eq 'WrongTransfer' ) { ; # FIXME... anything to do here? } @@ -537,6 +534,9 @@ foreach my $code ( keys %$messages ) { elsif ( $code eq 'NotForLoanStatusUpdated' ) { $err{NotForLoanStatusUpdated} = $messages->{NotForLoanStatusUpdated}; } + elsif ( $code eq 'DataCorrupted' ) { + $err{data_corrupted} = 1; + } else { die "Unknown error code $code"; # note we need all the (empty) elsif's above, or we die. # This forces the issue of staying in sync w/ Circulation.pm @@ -552,7 +552,8 @@ $template->param( errmsgloop => \@errmsgloop ); my $returned_counter = ( C4::Context->preference('numReturnedItemsToShow') ) ? C4::Context->preference('numReturnedItemsToShow') : 8; my $count = 0; my @riloop; -my $shelflocations = GetKohaAuthorisedValues('items.location',''); +my $shelflocations = + { map { $_->{authorised_value} => $_->{lib} } Koha::AuthorisedValues->get_descriptions_by_koha_field( { frameworkcode => '', kohafield => 'items.location' } ) }; foreach ( sort { $a <=> $b } keys %returneditems ) { my %ri; if ( $count++ < $returned_counter ) { @@ -565,45 +566,40 @@ foreach ( sort { $a <=> $b } keys %returneditems ) { $ri{hour} = $duedate->hour(); $ri{minute} = $duedate->minute(); $ri{duedate} = output_pref($duedate); - my $b = C4::Members::GetMember( borrowernumber => $riborrowernumber{$_} ); + my $patron = Koha::Patrons->find( $riborrowernumber{$_} ); unless ( $dropboxmode ) { $ri{return_overdue} = 1 if (DateTime->compare($duedate, DateTime->now()) == -1); } else { $ri{return_overdue} = 1 if (DateTime->compare($duedate, $dropboxdate) == -1); } - $ri{borrowernumber} = $b->{'borrowernumber'}; - $ri{borcnum} = $b->{'cardnumber'}; - $ri{borfirstname} = $b->{'firstname'}; - $ri{borsurname} = $b->{'surname'}; - $ri{bortitle} = $b->{'title'}; - $ri{bornote} = $b->{'borrowernotes'}; - $ri{borcategorycode}= $b->{'categorycode'}; + $ri{patron} = $patron, + $ri{borissuescount} = $patron->checkouts->count; } else { $ri{borrowernumber} = $riborrowernumber{$_}; } - # my %ri; - my $biblio = GetBiblioFromItemNumber(GetItemnumberFromBarcode($bar_code)); - my $item = GetItem( GetItemnumberFromBarcode($bar_code) ); - # fix up item type for display - $biblio->{'itemtype'} = C4::Context->preference('item-level_itypes') ? $biblio->{'itype'} : $biblio->{'itemtype'}; - $ri{itembiblionumber} = $biblio->{'biblionumber'}; - $ri{itemtitle} = $biblio->{'title'}; - $ri{itemauthor} = $biblio->{'author'}; - $ri{itemcallnumber} = $biblio->{'itemcallnumber'}; - $ri{dateaccessioned} = $item->{dateaccessioned}; - $ri{itemtype} = $biblio->{'itemtype'}; - $ri{itemnote} = $biblio->{'itemnotes'}; - $ri{itemnotes_nonpublic} = $item->{'itemnotes_nonpublic'}; - $ri{ccode} = $biblio->{'ccode'}; - $ri{enumchron} = $biblio->{'enumchron'}; - $ri{itemnumber} = $biblio->{'itemnumber'}; + my $item = Koha::Items->find({ barcode => $bar_code }); + next unless $item; # FIXME The item has been deleted in the meantime, + # we could handle that better displaying a message in the template + my $biblio = $item->biblio; + # FIXME pass $item to the template and we are done here... + $ri{itembiblionumber} = $biblio->biblionumber; + $ri{itemtitle} = $biblio->title; + $ri{itemauthor} = $biblio->author; + $ri{itemcallnumber} = $item->itemcallnumber; + $ri{dateaccessioned} = $item->dateaccessioned; + $ri{itemtype} = $item->effective_itemtype; + $ri{itemnote} = $item->itemnotes; + $ri{itemnotes_nonpublic} = $item->itemnotes_nonpublic; + $ri{ccode} = $item->ccode; + $ri{enumchron} = $item->enumchron; + $ri{itemnumber} = $item->itemnumber; $ri{barcode} = $bar_code; - $ri{homebranch} = $item->{'homebranch'}; - $ri{holdingbranch} = $item->{'holdingbranch'}; + $ri{homebranch} = $item->homebranch; + $ri{holdingbranch} = $item->holdingbranch; - $ri{location} = $biblio->{'location'}; + $ri{location} = $item->location; my $shelfcode = $ri{'location'}; $ri{'location'} = $shelflocations->{$shelfcode} if ( defined( $shelfcode ) && defined($shelflocations) && exists( $shelflocations->{$shelfcode} ) ); @@ -624,11 +620,11 @@ $template->param( forgivemanualholdsexpire => $forgivemanualholdsexpire, overduecharges => $overduecharges, AudioAlerts => C4::Context->preference("AudioAlerts"), - BlockReturnOfWithdrawnItems => C4::Context->preference("BlockReturnOfWithdrawnItems"), ); -$itemnumber = GetItemnumberFromBarcode( $barcode ); -if ( $itemnumber ) { +my $item_from_barcode = Koha::Items->find({barcode => $barcode }); # How many times do we fetch this item?!? +if ( $item_from_barcode ) { + $itemnumber = $item_from_barcode->itemnumber; my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber ); if ( $holdingBranch and $collectionBranch ) { $holdingBranch //= ''; @@ -643,5 +639,8 @@ if ( $itemnumber ) { } } +# Checking if there is a Fast Cataloging Framework +$template->param( fast_cataloging => 1 ) if Koha::BiblioFrameworks->find( 'FA' ); + # actually print the page! output_html_with_http_headers $query, $cookie, $template->output;