X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=fs%2Fsysfs%2Fbin.c;h=d3b9f5f07db149a38ecb03d0a44370d365ffb5d5;hb=31f6e1bd3b58c9a67e5ea0c2d372fbf5fc9e326d;hp=e8f540d38d486df31f5ce6482950bcd552b2ebc3;hpb=cd39301a68f9604854f3543117b01dc73cbe193f;p=powerpc.git diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c index e8f540d38d..d3b9f5f07d 100644 --- a/fs/sysfs/bin.c +++ b/fs/sysfs/bin.c @@ -16,6 +16,7 @@ #include #include +#include #include "sysfs.h" @@ -146,7 +147,7 @@ static int open(struct inode * inode, struct file * file) Error: module_put(attr->attr.owner); Done: - if (error && kobj) + if (error) kobject_put(kobj); return error; } @@ -157,8 +158,7 @@ static int release(struct inode * inode, struct file * file) struct bin_attribute * attr = to_bin_attr(file->f_path.dentry); u8 * buffer = file->private_data; - if (kobj) - kobject_put(kobj); + kobject_put(kobj); module_put(attr->attr.owner); kfree(buffer); return 0;