X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=members%2Frouting-lists.pl;h=51c6645430df69a7f11cddea628edbc7f94c5313;hb=refs%2Fheads%2Fkoha_ffzg;hp=ec9102f427fead5b67d6e177a535b317a6c12640;hpb=a6c9bd0eb55c32d5632625144775271f20aa15f7;p=koha.git diff --git a/members/routing-lists.pl b/members/routing-lists.pl index ec9102f427..51c6645430 100755 --- a/members/routing-lists.pl +++ b/members/routing-lists.pl @@ -17,33 +17,19 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -#use warnings; FIXME - Bug 2505 +use Modern::Perl; use CGI qw ( -utf8 ); use C4::Output; -use C4::Auth qw/:DEFAULT get_session/; -use C4::Branch; # GetBranches +use C4::Auth qw/:DEFAULT/; use C4::Members; use C4::Members::Attributes qw(GetBorrowerAttributes); use C4::Context; use C4::Serials; +use Koha::Patrons; use CGI::Session; my $query = new CGI; -my $sessionID = $query->cookie("CGISESSID") ; -my $session = get_session($sessionID); - -# branch are now defined by the userenv -# but first we have to check if someone has tried to change them - -my $branch = $query->param('branch'); -if ($branch){ - # update our session so the userenv is updated - $session->param('branch', $branch); - $session->param('branchname', GetBranchName($branch)); -} - my ( $template, $loggedinuser, $cookie ) = get_template_and_user ( { template_name => 'members/routing-lists.tt', @@ -54,85 +40,22 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user ( } ); -my $branches = GetBranches(); - my $findborrower = $query->param('findborrower'); $findborrower =~ s|,| |g; my $borrowernumber = $query->param('borrowernumber'); -$branch = C4::Context->userenv->{'branch'}; +my $branch = C4::Context->userenv->{'branch'}; -# get the borrower information..... -my $borrower; -if ($borrowernumber) { - $borrower = GetMemberDetails( $borrowernumber, 0 ); -} - - -################################################################################## -# BUILD HTML -# I'm trying to show the title of subscriptions where the borrowernumber is attached via a routing list - -if ($borrowernumber) { -# new op dev - my $count; - my @borrowerSubscriptions; - ($count, @borrowerSubscriptions) = GetSubscriptionsFromBorrower($borrowernumber ); - my @subscripLoop; - - foreach my $num_res (@borrowerSubscriptions) { - my %getSubscrip; - $getSubscrip{subscriptionid} = $num_res->{'subscriptionid'}; - $getSubscrip{title} = $num_res->{'title'}; - $getSubscrip{borrowernumber} = $num_res->{'borrowernumber'}; - push( @subscripLoop, \%getSubscrip ); - } - - $template->param( - countSubscrip => scalar @subscripLoop, - subscripLoop => \@subscripLoop, - routinglistview => 1 - ); - - $template->param( adultborrower => 1 ) if ( $borrower->{'category_type'} eq 'A' ); -} - -################################################################################## - - -# Computes full borrower address -my $roadtype = C4::Koha::GetAuthorisedValueByCode( 'ROADTYPE', $borrower->{streettype} ); -my $address = $borrower->{'streetnumber'} . " $roadtype " . $borrower->{'address'}; +my $logged_in_user = Koha::Patrons->find( $loggedinuser ) or die "Not logged in"; +my $patron = Koha::Patrons->find( $borrowernumber ); +output_and_exit_if_error( $query, $cookie, $template, { module => 'members', logged_in_user => $logged_in_user, current_patron => $patron } ); $template->param( - + patron => $patron, findborrower => $findborrower, - borrower => $borrower, - borrowernumber => $borrowernumber, - branch => $branch, - branchname => GetBranchName($borrower->{'branchcode'}), - title => $borrower->{'title'}, - initials => $borrower->{'initials'}, - firstname => $borrower->{'firstname'}, - surname => $borrower->{'surname'}, - othernames => $borrower->{'othernames'}, - categorycode => $borrower->{'categorycode'}, - categoryname => $borrower->{description}, - address => $address, - address2 => $borrower->{'address2'}, - phone => $borrower->{'phone'}, - phonepro => $borrower->{'phonepro'}, - mobile => $borrower->{'mobile'}, - email => $borrower->{'email'}, - emailpro => $borrower->{'emailpro'}, - borrowernotes => $borrower->{'borrowernotes'}, - city => $borrower->{'city'}, - state => $borrower->{'state'}, - zipcode => $borrower->{'zipcode'}, - country => $borrower->{'country'}, - cardnumber => $borrower->{'cardnumber'}, - RoutingSerials => C4::Context->preference('RoutingSerials'), + branch => $branch, # FIXME This is confusing + routinglistview => 1, ); if (C4::Context->preference('ExtendedPatronAttributes')) { @@ -143,7 +66,4 @@ if (C4::Context->preference('ExtendedPatronAttributes')) { ); } -my ($picture, $dberror) = GetPatronImage($borrower->{'borrowernumber'}); -$template->param( picture => 1 ) if $picture; - output_html_with_http_headers $query, $cookie, $template->output;