X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=opac%2Fopac-reserve.pl;h=aeb88ca0360e9c9754523b55f905db33d9e837a4;hb=ddc4c5b8aa75cfe8994ff150a0cae4cc51656852;hp=c1b5387faba704674eceb8d072e35b8e96222574;hpb=a6c9bd0eb55c32d5632625144775271f20aa15f7;p=koha.git diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl index c1b5387fab..aeb88ca036 100755 --- a/opac/opac-reserve.pl +++ b/opac/opac-reserve.pl @@ -18,8 +18,8 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; +use Modern::Perl; + use CGI qw ( -utf8 ); use C4::Auth; # checkauth, getborrowernumber. use C4::Koha; @@ -28,27 +28,39 @@ use C4::Reserves; use C4::Biblio; use C4::Items; use C4::Output; -use C4::Dates qw/format_date/; use C4::Context; use C4::Members; -use C4::Branch; # GetBranches use C4::Overdues; use C4::Debug; + +use Koha::AuthorisedValues; +use Koha::Biblios; use Koha::DateUtils; -use Koha::Borrower::Debarments qw(IsDebarred); +use Koha::IssuingRules; +use Koha::Items; +use Koha::ItemTypes; +use Koha::Checkouts; +use Koha::Libraries; +use Koha::Patrons; use Date::Calc qw/Today Date_to_Days/; -# use Data::Dumper; +use List::MoreUtils qw/uniq/; my $maxreserves = C4::Context->preference("maxreserves"); my $query = new CGI; + +# if RequestOnOpac (for placing holds) is disabled, leave immediately +if ( ! C4::Context->preference('RequestOnOpac') ) { + print $query->redirect("/cgi-bin/koha/errors/404.pl"); + exit; +} + my ( $template, $borrowernumber, $cookie ) = get_template_and_user( { template_name => "opac-reserve.tt", query => $query, type => "opac", authnotrequired => 0, - flagsrequired => { borrow => 1 }, debug => 1, } ); @@ -64,13 +76,21 @@ sub get_out { exit; } -# get borrower information .... -my ( $borr ) = GetMemberDetails( $borrowernumber ); +my $patron = Koha::Patrons->find( $borrowernumber ); + +my $can_place_hold_if_available_at_pickup = C4::Context->preference('OPACHoldsIfAvailableAtPickup'); +unless ( $can_place_hold_if_available_at_pickup ) { + my @patron_categories = split '\|', C4::Context->preference('OPACHoldsIfAvailableAtPickupExceptions'); + if ( @patron_categories ) { + my $categorycode = $patron->categorycode; + $can_place_hold_if_available_at_pickup = grep /^$categorycode$/, @patron_categories; + } +} # check if this user can place a reserve, -1 means use sys pref, 0 means dont block, 1 means block -if ( $borr->{'BlockExpiredPatronOpacActions'} ) { +if ( $patron->category->effective_BlockExpiredPatronOpacActions ) { - if ( $borr->{'is_expired'} ) { + if ( $patron->is_expired ) { # cannot reserve, their card has expired and the rules set mean this is not allowed $template->param( message => 1, expired_patron => 1 ); @@ -79,12 +99,12 @@ if ( $borr->{'BlockExpiredPatronOpacActions'} ) { } # Pass through any reserve charge -if ($borr->{reservefee} > 0){ - $template->param( RESERVE_CHARGE => sprintf("%.2f",$borr->{reservefee})); +my $reservefee = $patron->category->reservefee; +if ( $reservefee > 0){ + $template->param( RESERVE_CHARGE => $reservefee); } -# get branches and itemtypes -my $branches = GetBranches(); -my $itemTypes = GetItemTypes(); + +my $itemtypes = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search_with_localization->unblessed } }; # There are two ways of calling this script, with a single biblio num # or multiple biblio nums. @@ -117,18 +137,9 @@ if (($#biblionumbers < 0) && (! $query->param('place_reserve'))) { # pass the pickup branch along.... -my $branch = $query->param('branch') || $borr->{'branchcode'} || C4::Context->userenv->{branch} || '' ; -($branches->{$branch}) or $branch = ""; # Confirm branch is real +my $branch = $query->param('branch') || $patron->branchcode || C4::Context->userenv->{branch} || '' ; $template->param( branch => $branch ); -# make branch selection options... -my $branchloop = GetBranchesLoop($branch); - -# Is the person allowed to choose their branch -my $OPACChooseBranch = (C4::Context->preference("OPACAllowUserToChooseBranch")) ? 1 : 0; - -$template->param( choose_branch => $OPACChooseBranch); - # # # Build hashes of the requested biblio(item)s and items. @@ -144,7 +155,7 @@ foreach my $biblioNumber (@biblionumbers) { my @itemInfos = GetItemsInfo($biblioNumber); - my $marcrecord= GetMarcBiblio($biblioNumber); + my $marcrecord= GetMarcBiblio({ biblionumber => $biblioNumber }); # flag indicating existence of at least one item linked via a host record my $hostitemsflag; @@ -161,12 +172,13 @@ foreach my $biblioNumber (@biblionumbers) { } # Compute the priority rank. - my $reserves = GetReservesFromBiblionumber({ biblionumber => $biblioNumber, all_dates => 1 }); - my $rank = scalar( @$reserves ); + my $biblio = Koha::Biblios->find( $biblioNumber ); + $biblioData->{object} = $biblio; + my $holds = $biblio->holds; + my $rank = $holds->count; $biblioData->{reservecount} = 1; # new reserve - foreach my $res (@{$reserves}) { - my $found = $res->{found}; - if ( $found && $found eq 'W' ) { + while ( my $hold = $holds->next ) { + if ( $hold->is_waiting ) { $rank--; } else { @@ -186,7 +198,7 @@ foreach my $biblioNumber (@biblionumbers) { if ( $query->param('place_reserve') ) { my $reserve_cnt = 0; if ($maxreserves) { - $reserve_cnt = GetReservesFromBorrowernumber( $borrowernumber ); + $reserve_cnt = $patron->holds->count; } # List is composed of alternating biblio/item/branch @@ -215,6 +227,7 @@ if ( $query->param('place_reserve') ) { &get_out($query, $cookie, $template->output); } + my $failed_holds = 0; while (@selectedItems) { my $biblioNum = shift(@selectedItems); my $itemNum = shift(@selectedItems); @@ -222,15 +235,16 @@ if ( $query->param('place_reserve') ) { my $canreserve = 0; - my $singleBranchMode = C4::Context->preference("singleBranchMode"); - if ( $singleBranchMode || !$OPACChooseBranch ) + my $singleBranchMode = Koha::Libraries->search->count == 1; + if ( $singleBranchMode || ! C4::Context->preference("OPACAllowUserToChooseBranch") ) { # single branch mode or disabled user choosing - $branch = $borr->{'branchcode'}; + $branch = $patron->branchcode; } #item may belong to a host biblio, if yes change biblioNum to hosts bilbionumber if ( $itemNum ne '' ) { - my $hostbiblioNum = GetBiblionumberFromItemnumber($itemNum); + my $item = Koha::Items->find( $itemNum ); + my $hostbiblioNum = $item->biblio->biblionumber; if ( $hostbiblioNum ne $biblioNum ) { $biblioNum = $hostbiblioNum; } @@ -249,20 +263,12 @@ if ( $query->param('place_reserve') ) { my $expiration_date = $query->param("expiration_date_$biblioNum"); - # If a specific item was selected and the pickup branch is the same as the - # holdingbranch, force the value $rank and $found. my $rank = $biblioData->{rank}; if ( $itemNum ne '' ) { - $canreserve = 1 if CanItemBeReserved( $borrowernumber, $itemNum ) eq 'OK'; - $rank = '0' unless C4::Context->preference('ReservesNeedReturns'); - my $item = GetItem($itemNum); - if ( $item->{'holdingbranch'} eq $branch ) { - $found = 'W' - unless C4::Context->preference('ReservesNeedReturns'); - } + $canreserve = 1 if CanItemBeReserved( $borrowernumber, $itemNum )->{status} eq 'OK'; } else { - $canreserve = 1 if CanBookBeReserved( $borrowernumber, $biblioNum ) eq 'OK'; + $canreserve = 1 if CanBookBeReserved( $borrowernumber, $biblioNum )->{status} eq 'OK'; # Inserts a null into the 'itemnumber' field of 'reserves' table. $itemNum = undef; @@ -275,21 +281,32 @@ if ( $query->param('place_reserve') ) { $canreserve = 0; } + unless ( $can_place_hold_if_available_at_pickup ) { + my $items_in_this_library = Koha::Items->search({ biblionumber => $biblioNum, holdingbranch => $branch }); + my $nb_of_items_issued = $items_in_this_library->search({ 'issue.itemnumber' => { not => undef }}, { join => 'issue' })->count; + my $nb_of_items_unavailable = $items_in_this_library->search({ -or => { lost => { '!=' => 0 }, damaged => { '!=' => 0 }, } }); + if ( $items_in_this_library->count > $nb_of_items_issued + $nb_of_items_unavailable ) { + $canreserve = 0 + } + } + + my $itemtype = $query->param('itemtype') || undef; + $itemtype = undef if $itemNum; + # Here we actually do the reserveration. Stage 3. if ($canreserve) { - AddReserve( - $branch, $borrowernumber, - $biblioNum, 'a', - [$biblioNum], $rank, - $startdate, $expiration_date, - $notes, $biblioData->{title}, - $itemNum, $found + my $reserve_id = AddReserve( + $branch, $borrowernumber, $biblioNum, + [$biblioNum], $rank, $startdate, + $expiration_date, $notes, $biblioData->{title}, + $itemNum, $found, $itemtype, ); + $failed_holds++ unless $reserve_id; ++$reserve_cnt; } } - print $query->redirect("/cgi-bin/koha/opac-user.pl#opac-user-holds"); + print $query->redirect("/cgi-bin/koha/opac-user.pl?" . ( $failed_holds ? "failed_holds=$failed_holds" : q|| ) . "#opac-user-holds"); exit; } @@ -301,41 +318,47 @@ if ( $query->param('place_reserve') ) { my $noreserves = 0; my $maxoutstanding = C4::Context->preference("maxoutstanding"); $template->param( noreserve => 1 ) unless $maxoutstanding; -if ( $borr->{'amountoutstanding'} && ($borr->{'amountoutstanding'} > $maxoutstanding) ) { - my $amount = sprintf "%.02f", $borr->{'amountoutstanding'}; +my $amountoutstanding = $patron->account->balance; +if ( $amountoutstanding && ($amountoutstanding > $maxoutstanding) ) { + my $amount = sprintf "%.02f", $amountoutstanding; $template->param( message => 1 ); $noreserves = 1; $template->param( too_much_oweing => $amount ); } -if ( $borr->{gonenoaddress} && ($borr->{gonenoaddress} == 1) ) { + +if ( $patron->gonenoaddress && ($patron->gonenoaddress == 1) ) { $noreserves = 1; $template->param( message => 1, GNA => 1 ); } -if ( $borr->{lost} && ($borr->{lost} == 1) ) { + +if ( $patron->lost && ($patron->lost == 1) ) { $noreserves = 1; $template->param( message => 1, lost => 1 ); } -if ( IsDebarred($borrowernumber) ) { + +if ( $patron->is_debarred ) { $noreserves = 1; $template->param( - message => 1, - debarred => 1 + message => 1, + debarred => 1, + debarred_comment => $patron->debarredcomment, + debarred_date => $patron->debarred, ); } -my @reserves = GetReservesFromBorrowernumber( $borrowernumber ); -my $reserves_count = scalar(@reserves); -$template->param( RESERVES => \@reserves ); +my $holds = $patron->holds; +my $reserves_count = $holds->count; +$template->param( RESERVES => $holds->unblessed ); if ( $maxreserves && ( $reserves_count >= $maxreserves ) ) { $template->param( message => 1 ); $noreserves = 1; - $template->param( too_many_reserves => scalar(@reserves)); + $template->param( too_many_reserves => $holds->count ); } unless ( $noreserves ) { @@ -345,17 +368,6 @@ unless ( $noreserves ) { } } -foreach my $res (@reserves) { - foreach my $biblionumber (@biblionumbers) { - if ( $res->{'biblionumber'} == $biblionumber && $res->{'borrowernumber'} == $borrowernumber) { -# $template->param( message => 1 ); -# $noreserves = 1; -# $template->param( already_reserved => 1 ); - $biblioDataHash{$biblionumber}->{already_reserved} = 1; - } - } -} - unless ($noreserves) { $template->param( select_item_types => 1 ); } @@ -367,20 +379,21 @@ unless ($noreserves) { # and items for each biblionumber. # # -my $notforloan_label_of = get_notforloan_label_of(); my $biblioLoop = []; my $numBibsAvailable = 0; my $itemdata_enumchron = 0; +my $itemdata_ccode = 0; my $anyholdable = 0; my $itemLevelTypes = C4::Context->preference('item-level_itypes'); +my $pickup_locations = Koha::Libraries->search({ pickup_location => 1 }); $template->param('item_level_itypes' => $itemLevelTypes); foreach my $biblioNum (@biblionumbers) { - my $record = GetMarcBiblio($biblioNum); + my $record = GetMarcBiblio({ biblionumber => $biblioNum }); # Init the bib item with the choices for branch pickup - my %biblioLoopIter = ( branchloop => $branchloop ); + my %biblioLoopIter; # Get relevant biblio data. my $biblioData = $biblioDataHash{$biblioNum}; @@ -389,31 +402,31 @@ foreach my $biblioNum (@biblionumbers) { &get_out($query, $cookie, $template->output); } + my @not_available_at = (); + my $biblio = $biblioData->{object}; + foreach my $library ( $pickup_locations->as_list ) { + push( @not_available_at, $library->branchcode ) unless $biblio->can_be_transferred({ to => $library }); + } + + my $frameworkcode = GetFrameworkCode( $biblioData->{biblionumber} ); $biblioLoopIter{biblionumber} = $biblioData->{biblionumber}; $biblioLoopIter{title} = $biblioData->{title}; - $biblioLoopIter{subtitle} = GetRecordValue('subtitle', $record, GetFrameworkCode($biblioData->{biblionumber})); + $biblioLoopIter{subtitle} = GetRecordValue('subtitle', $record, $frameworkcode); $biblioLoopIter{author} = $biblioData->{author}; $biblioLoopIter{rank} = $biblioData->{rank}; $biblioLoopIter{reservecount} = $biblioData->{reservecount}; $biblioLoopIter{already_reserved} = $biblioData->{already_reserved}; - $biblioLoopIter{mandatorynotes}=0; #FIXME: For future use + $biblioLoopIter{reqholdnotes}=0; #TODO: For future use if (!$itemLevelTypes && $biblioData->{itemtype}) { - $biblioLoopIter{description} = $itemTypes->{$biblioData->{itemtype}}{description}; - $biblioLoopIter{imageurl} = getitemtypeimagesrc() . "/". $itemTypes->{$biblioData->{itemtype}}{imageurl}; + $biblioLoopIter{translated_description} = $itemtypes->{$biblioData->{itemtype}}{translated_description}; + $biblioLoopIter{imageurl} = getitemtypeimagesrc() . "/". $itemtypes->{$biblioData->{itemtype}}{imageurl}; } foreach my $itemInfo (@{$biblioData->{itemInfos}}) { - $debug and warn $itemInfo->{'notforloan'}; - - # Get reserve fee. - my $fee = GetReserveFee(undef, $borrowernumber, $itemInfo->{'biblionumber'}, 'a', - ( $itemInfo->{'biblioitemnumber'} ) ); - $itemInfo->{'reservefee'} = sprintf "%.02f", ($fee ? $fee : 0.0); - if ($itemLevelTypes && $itemInfo->{itype}) { - $itemInfo->{description} = $itemTypes->{$itemInfo->{itype}}{description}; - $itemInfo->{imageurl} = getitemtypeimagesrc() . "/". $itemTypes->{$itemInfo->{itype}}{imageurl}; + $itemInfo->{translated_description} = $itemtypes->{$itemInfo->{itype}}{translated_description}; + $itemInfo->{imageurl} = getitemtypeimagesrc() . "/". $itemtypes->{$itemInfo->{itype}}{imageurl}; } if (!$itemInfo->{'notforloan'} && !($itemInfo->{'itemnotforloan'} > 0)) { @@ -421,57 +434,52 @@ foreach my $biblioNum (@biblionumbers) { } } + my @notforloan_avs = Koha::AuthorisedValues->search_by_koha_field({ kohafield => 'items.notforloan', frameworkcode => $frameworkcode }); + my $notforloan_label_of = { map { $_->authorised_value => $_->opac_description } @notforloan_avs }; + $biblioLoopIter{itemLoop} = []; my $numCopiesAvailable = 0; my $numCopiesOPACAvailable = 0; foreach my $itemInfo (@{$biblioData->{itemInfos}}) { my $itemNum = $itemInfo->{itemnumber}; + my $item = Koha::Items->find( $itemNum ); my $itemLoopIter = {}; $itemLoopIter->{itemnumber} = $itemNum; $itemLoopIter->{barcode} = $itemInfo->{barcode}; - $itemLoopIter->{homeBranchName} = $branches->{$itemInfo->{homebranch}}{branchname}; + $itemLoopIter->{homeBranchName} = $itemInfo->{homebranch}; $itemLoopIter->{callNumber} = $itemInfo->{itemcallnumber}; $itemLoopIter->{enumchron} = $itemInfo->{enumchron}; + $itemLoopIter->{ccode} = $itemInfo->{ccode}; $itemLoopIter->{copynumber} = $itemInfo->{copynumber}; if ($itemLevelTypes) { - $itemLoopIter->{description} = $itemInfo->{description}; + $itemLoopIter->{translated_description} = $itemInfo->{translated_description}; + $itemLoopIter->{itype} = $itemInfo->{itype}; $itemLoopIter->{imageurl} = $itemInfo->{imageurl}; } # If the holdingbranch is different than the homebranch, we show the # holdingbranch of the document too. if ( $itemInfo->{homebranch} ne $itemInfo->{holdingbranch} ) { - $itemLoopIter->{holdingBranchName} = - $branches->{ $itemInfo->{holdingbranch} }{branchname}; + $itemLoopIter->{holdingBranchName} = $itemInfo->{holdingbranch}; } # If the item is currently on loan, we display its return date and # change the background color. - my $issues= GetItemIssue($itemNum); - if ( $issues->{'date_due'} ) { - $itemLoopIter->{dateDue} = output_pref({ dt => dt_from_string($issues->{date_due}, 'sql'), as_due_date => 1 }); + my $issue = Koha::Checkouts->find( { itemnumber => $itemNum } ); + if ( $issue ) { + $itemLoopIter->{dateDue} = output_pref({ dt => dt_from_string($issue->date_due, 'sql'), as_due_date => 1 }); $itemLoopIter->{backgroundcolor} = 'onloan'; } # checking reserve - my ($reservedate,$reservedfor,$expectedAt,undef,$wait) = GetReservesFromItemnumber($itemNum); - my $ItemBorrowerReserveInfo = GetMemberDetails( $reservedfor, 0); + my $holds = $item->current_holds; - # the item could be reserved for this borrower vi a host record, flag this - if ($reservedfor eq $borrowernumber){ - $itemLoopIter->{already_reserved} = 1; - } - - if ( defined $reservedate ) { + if ( my $first_hold = $holds->next ) { $itemLoopIter->{backgroundcolor} = 'reserved'; - $itemLoopIter->{reservedate} = format_date($reservedate); - $itemLoopIter->{ReservedForBorrowernumber} = $reservedfor; - $itemLoopIter->{ReservedForSurname} = $ItemBorrowerReserveInfo->{'surname'}; - $itemLoopIter->{ReservedForFirstname} = $ItemBorrowerReserveInfo->{'firstname'}; - $itemLoopIter->{ExpectedAtLibrary} = $expectedAt; - #waiting status - $itemLoopIter->{waitingdate} = $wait; + $itemLoopIter->{reservedate} = output_pref({ dt => dt_from_string($first_hold->reservedate), dateonly => 1 }); # FIXME Should be formatted in the template + $itemLoopIter->{ExpectedAtLibrary} = $first_hold->branchcode; + $itemLoopIter->{waitingdate} = $first_hold->waitingdate; } $itemLoopIter->{notforloan} = $itemInfo->{notforloan}; @@ -495,63 +503,69 @@ foreach my $biblioNum (@biblionumbers) { $itemInfo->{backgroundcolor} = 'other'; } - # Check of the transfered documents + # Check of the transferred documents my ( $transfertwhen, $transfertfrom, $transfertto ) = GetTransfers($itemNum); if ( $transfertwhen && ($transfertwhen ne '') ) { - $itemLoopIter->{transfertwhen} = format_date($transfertwhen); - $itemLoopIter->{transfertfrom} = - $branches->{$transfertfrom}{branchname}; - $itemLoopIter->{transfertto} = $branches->{$transfertto}{branchname}; + $itemLoopIter->{transfertwhen} = output_pref({ dt => dt_from_string($transfertwhen), dateonly => 1 }); + $itemLoopIter->{transfertfrom} = $transfertfrom; + $itemLoopIter->{transfertto} = $transfertto; $itemLoopIter->{nocancel} = 1; } - # if the items belongs to a host record, show link to host record - if ($itemInfo->{biblionumber} ne $biblioNum){ - $biblioLoopIter{hostitemsflag} = 1; - $itemLoopIter->{hostbiblionumber} = $itemInfo->{biblionumber}; - $itemLoopIter->{hosttitle} = GetBiblioData($itemInfo->{biblionumber})->{title}; - } + # if the items belongs to a host record, show link to host record + if ( $itemInfo->{biblionumber} ne $biblioNum ) { + $biblioLoopIter{hostitemsflag} = 1; + $itemLoopIter->{hostbiblionumber} = $itemInfo->{biblionumber}; + $itemLoopIter->{hosttitle} = Koha::Biblios->find( $itemInfo->{biblionumber} )->title; + } # If there is no loan, return and transfer, we show a checkbox. $itemLoopIter->{notforloan} = $itemLoopIter->{notforloan} || 0; - my $branch = GetReservesControlBranch( $itemInfo, $borr ); + my $patron_unblessed = $patron->unblessed; + my $branch = GetReservesControlBranch( $itemInfo, $patron_unblessed ); my $policy_holdallowed = !$itemLoopIter->{already_reserved}; - if ($policy_holdallowed) { - if (my $branchitemrule = GetBranchItemRule( $branch, $itemInfo->{'itype'} )) { - $policy_holdallowed = - ($branchitemrule->{'holdallowed'} == 2) || - ($branchitemrule->{'holdallowed'} == 1 - && $borr->{'branchcode'} eq $itemInfo->{'homebranch'}); - } else { - $policy_holdallowed = 0; # No rule - not allowed - } - } $policy_holdallowed &&= - IsAvailableForItemLevelRequest($itemInfo,$borr) && - CanItemBeReserved($borrowernumber,$itemNum) eq 'OK'; + IsAvailableForItemLevelRequest($itemInfo,$patron_unblessed) && + CanItemBeReserved( $borrowernumber, $itemNum )->{status} eq 'OK'; if ($policy_holdallowed) { - if ( my $hold_allowed = OPACItemHoldsAllowed( $itemInfo, $borr ) ) { + my $opac_hold_policy = Koha::IssuingRules->get_opacitemholds_policy( { item => $item, patron => $patron } ); + if ( $opac_hold_policy ne 'N' ) { # If Y or F $itemLoopIter->{available} = 1; $numCopiesOPACAvailable++; - $biblioLoopIter{force_hold} = 1 if $hold_allowed eq 'F'; + $biblioLoopIter{force_hold} = 1 if $opac_hold_policy eq 'F'; } $numCopiesAvailable++; + + unless ( $can_place_hold_if_available_at_pickup ) { + my $items_in_this_library = Koha::Items->search({ biblionumber => $itemInfo->{biblionumber}, holdingbranch => $itemInfo->{holdingbranch} }); + my $nb_of_items_issued = $items_in_this_library->search({ 'issue.itemnumber' => { not => undef }}, { join => 'issue' })->count; + if ( $items_in_this_library->count > $nb_of_items_issued ) { + push @not_available_at, $itemInfo->{holdingbranch}; + } + } } - $itemLoopIter->{imageurl} = getitemtypeimagelocation( 'opac', $itemTypes->{ $itemInfo->{itype} }{imageurl} ); + $itemLoopIter->{imageurl} = getitemtypeimagelocation( 'opac', $itemtypes->{ $itemInfo->{itype} }{imageurl} ); # Show serial enumeration when needed if ($itemLoopIter->{enumchron}) { $itemdata_enumchron = 1; } + # Show collection when needed + if ($itemLoopIter->{ccode}) { + $itemdata_ccode = 1; + } push @{$biblioLoopIter{itemLoop}}, $itemLoopIter; } - $template->param( itemdata_enumchron => $itemdata_enumchron ); + $template->param( + itemdata_enumchron => $itemdata_enumchron, + itemdata_ccode => $itemdata_ccode, + ); if ($numCopiesAvailable > 0) { $numBibsAvailable++; @@ -568,17 +582,62 @@ foreach my $biblioNum (@biblionumbers) { $biblioLoopIter{already_patron_possession} = 1; } - $biblioLoopIter{holdable} &&= CanBookBeReserved($borrowernumber,$biblioNum) eq 'OK'; + if ( $biblioLoopIter{holdable} ) { + @not_available_at = uniq @not_available_at; + $biblioLoopIter{not_available_at} = \@not_available_at ; + } + + unless ( $can_place_hold_if_available_at_pickup ) { + @not_available_at = uniq @not_available_at; + $biblioLoopIter{not_available_at} = \@not_available_at ; + # The record is not holdable is not available at any of the libraries + if ( Koha::Libraries->search->count == @not_available_at ) { + $biblioLoopIter{holdable} = 0; + } + } + + $biblioLoopIter{holdable} &&= CanBookBeReserved( $borrowernumber, $biblioNum )->{status} eq 'OK'; + + # For multiple holds per record, if a patron has previously placed a hold, + # the patron can only place more holds of the same type. That is, if the + # patron placed a record level hold, all the holds the patron places must + # be record level. If the patron placed an item level hold, all holds + # the patron places must be item level + my $forced_hold_level = Koha::Holds->search( + { + borrowernumber => $borrowernumber, + biblionumber => $biblioNum, + found => undef, + } + )->forced_hold_level(); + if ($forced_hold_level) { + $biblioLoopIter{force_hold} = 1 if $forced_hold_level eq 'item'; + $biblioLoopIter{itemholdable} = 0 if $forced_hold_level eq 'record'; + } + push @$biblioLoop, \%biblioLoopIter; $anyholdable = 1 if $biblioLoopIter{holdable}; } +unless ($pickup_locations->count) { + $numBibsAvailable = 0; + $anyholdable = 0; + $template->param( + message => 1, + no_pickup_locations => 1 + ); +} + if ( $numBibsAvailable == 0 || $anyholdable == 0) { $template->param( none_available => 1 ); } +if (scalar @biblionumbers > 1) { + $template->param( multi_hold => 1); +} + my $show_notes=C4::Context->preference('OpacHoldNotes'); $template->param(OpacHoldNotes=>$show_notes); @@ -594,5 +653,4 @@ if ( ); } -output_html_with_http_headers $query, $cookie, $template->output; - +output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 };