X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=reports%2Fborrowers_out.pl;h=278e412b483274ccd6fe448f21f736a64a76c5a4;hb=e012957186426b9577bfc8498c5971990b258024;hp=0a135e1119953f2abe3263969ea2367d42e4d7fb;hpb=fc2fe083fcc34742a1f80e3fb3df1ab4bd072ca1;p=koha.git diff --git a/reports/borrowers_out.pl b/reports/borrowers_out.pl index 0a135e1119..278e412b48 100755 --- a/reports/borrowers_out.pl +++ b/reports/borrowers_out.pl @@ -230,18 +230,12 @@ sub calculate { @$filters[0]=~ s/\*/%/g if (@$filters[0]); $strcalc .= " AND borrowers.categorycode like '" . @$filters[0] ."'" if ( @$filters[0] ); - my $strqueryfilter = "SELECT DISTINCT borrowernumber FROM "; - $strqueryfilter .= "(SELECT borrowernumber from old_issues WHERE borrowernumber IS NOT NULL "; - if ($filters->[1]){ - $strqueryfilter .= "AND old_issues.timestamp> '$filters->[1]' "; - } - $strqueryfilter .= "UNION SELECT borrowernumber FROM issues WHERE 1 "; - if ($filters->[1]){ - $strqueryfilter .= "AND issues.timestamp> '$filters->[1]' "; - } - $strqueryfilter .= ") active_borrowers"; - - $strcalc .= " AND borrowers.borrowernumber not in ($strqueryfilter)"; + $strcalc .= " AND NOT EXISTS (SELECT * FROM issues WHERE issues.borrowernumber=borrowers.borrowernumber "; + $strcalc .= " AND issues.timestamp> '" . @$filters[1] . "'" if (@$filters[1]); + $strcalc .= ") "; + $strcalc .= " AND NOT EXISTS (SELECT * FROM old_issues WHERE old_issues.borrowernumber=borrowers.borrowernumber "; + $strcalc .= " AND old_issues.timestamp> '" . @$filters[1] . "'" if (@$filters[1]); + $strcalc .= ") "; $strcalc .= " group by borrowers.borrowernumber"; $strcalc .= ", $colfield" if ($column); $strcalc .= " order by $colfield " if ($colfield);