X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=t%2F20-methods.t;h=9d260c379cf664d332e9ec4038476b6fac2f48b9;hb=71970361377c34791fd6e7970a32fd2ba345d8bc;hp=ac09cb9084aa5188818cfb943aeb638819ac28b9;hpb=f164de0a280f1ebcf8fd031f58ea917fb79bcedf;p=perl-cwmp.git

diff --git a/t/20-methods.t b/t/20-methods.t
index ac09cb9..9d260c3 100755
--- a/t/20-methods.t
+++ b/t/20-methods.t
@@ -4,7 +4,7 @@ use warnings;
 
 my $debug = shift @ARGV;
 
-use Test::More tests => 14;
+use Test::More tests => 16;
 use Data::Dump qw/dump/;
 use Cwd qw/abs_path/;
 use File::Slurp;
@@ -17,20 +17,20 @@ BEGIN {
 ok(my $abs_path = abs_path($0), "abs_path");
 $abs_path =~ s!/[^/]*$!/!;	#!fix-vim
 
-ok( my $response = CWMP::Methods->new({ debug => $debug }), 'new' );
-isa_ok( $response, 'CWMP::Methods' );
+ok( my $method = CWMP::Methods->new({ debug => $debug }), 'new' );
+isa_ok( $method, 'CWMP::Methods' );
 
-sub check_response {
+sub check_method {
 	my $command = shift || die "no command?";
 
 	my $state = {
 		ID => 42,
 	};
 
-	diag "check_response $command",dump( 'state', @_ ) if $debug;
-	ok( my $xml = $response->$command( $state, @_ ), "generate response $command" . dump(@_) );
+	diag "check_method $command",dump( 'state', @_ ) if $debug;
+	ok( my $xml = $method->$command( $state, shift ), "generate method $command" . dump(@_) );
 
-	my $file = "$abs_path/response/$command.xml";
+	my $file = "$abs_path/methods/$command.xml";
 
 	if ( ! -e $file ) {
 		diag "creating $file";
@@ -39,11 +39,18 @@ sub check_response {
 
 	my $template_xml = read_file( $file ) || die "can't read template xml $file: $!";
 
-	is( $xml, $template_xml, "compare $command" );
+	is( $xml, $template_xml, "compare $file" );
 }
 
-check_response( 'InformResponse' );
-check_response( 'GetRPCMethods' );
-check_response( 'Reboot' );
-check_response( 'GetParameterNames', 'InternetGatewayDevice.DeviceInfo.SerialNumber' );
-check_response( 'GetParameterValues', 'InternetGatewayDevice.DeviceInfo.SerialNumber', 'InternetGatewayDevice.DeviceInfo.VendorConfigFile.' );
+check_method( 'InformResponse' );
+check_method( 'GetRPCMethods' );
+check_method( 'Reboot' );
+check_method( 'SetParameterValues', {
+	'InternetGatewayDevice.DeviceInfo.ProvisioningCode' => 'test provision',
+	'InternetGatewayDevice.DeviceInfo.X_000E50_Country' => 42,
+});
+check_method( 'GetParameterNames', [ 'InternetGatewayDevice.DeviceInfo.SerialNumber' ] );
+check_method( 'GetParameterValues', [
+	'InternetGatewayDevice.DeviceInfo.SerialNumber',
+	'InternetGatewayDevice.DeviceInfo.VendorConfigFile.',
+]);