X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=t%2F3-normalize.t;h=5c59052782489190555545adb16906da022b6ea0;hb=5d5fc808565b88bca0e2d10aa62bd89c7e748743;hp=6dcc3b33dd90a74dbfd3721b7f6c019b0b30110d;hpb=d8abf58ba24b367d2a8cbd5c87c890a8498ec561;p=webpac2

diff --git a/t/3-normalize.t b/t/3-normalize.t
index 6dcc3b3..5c59052 100755
--- a/t/3-normalize.t
+++ b/t/3-normalize.t
@@ -1,25 +1,15 @@
 #!/usr/bin/perl -w
 
 use strict;
-
-use Test::More tests => 322;
-use Test::Exception;
-use Cwd qw/abs_path/;
 use blib;
-use File::Slurp;
-use Getopt::Long;
+
+use Test::More tests => 344;
 
 BEGIN {
+	use_ok( 'WebPAC::Test' );
 	use_ok( 'WebPAC::Normalize' );
 }
 
-use Data::Dump qw/dump/;
-
-my $debug = 0;
-GetOptions(
-	"debug+", \$debug
-);
-
 cmp_ok(_debug(1), '==', 1, '_debug level');
 cmp_ok(_debug(0), '==', 0, '_debug level');
 
@@ -28,10 +18,6 @@ if ($debug > 2) {
 	diag "debug level for WebPAC::Normalize is ", _debug( $debug - 2 );
 }
 
-ok(my $abs_path = abs_path($0), "abs_path");
-$abs_path =~ s#/[^/]*$#/#;
-diag "abs_path: $abs_path" if ($debug);
-
 my $rec1 = {
 	'200' => [{
 		'a' => '200a',
@@ -176,7 +162,7 @@ sub test_s {
 
 	ok(! _set_lookup( undef ), "set_lookup(undef)");
 
-	_set_rec( $rec1 );
+	_set_ds( $rec1 );
 
 	cmp_ok( join(",", rec2('200','a') ), 'eq', '200a,200a*2', 'join rec2' );
 	cmp_ok( join(",", rec2('200','a'), rec2('200','b') ), 'eq', '200a,200a*2,200b', 'join rec2 rec2' );
@@ -191,8 +177,16 @@ sub test_s {
 
 	# simple list manipulatons
 	cmp_ok( join('', prefix('ab', 'cd') ), 'eq', 'abcd', 'prefix');
+	cmp_ok( join('-', prefix('', 'x', 'y') ), 'eq', 'x-y', 'prefix empty');
+	cmp_ok( join('-', prefix(0, 'x', 'y') ), 'eq', '0x-0y', 'prefix 0');
+
 	cmp_ok( join('', suffix('xy', 'cd') ), 'eq', 'cdxy', 'suffix');
+	cmp_ok( join('-', suffix('', 'x', 'y' ) ), 'eq', 'x-y', 'suffix empty');
+	cmp_ok( join('-', suffix(0, 'x', 'y' ) ), 'eq', 'x0-y0', 'suffix 0');
+
 	cmp_ok( join('', surround('->', '<-', 'a','b','c') ), 'eq', '->a<-->b<-->c<-', 'surround');
+	cmp_ok( join('-', surround('', '', 'x','y','z') ), 'eq', 'x-y-z', 'surround empty');
+	cmp_ok( join('-', surround(0, 0, 'x','y','z') ), 'eq', '0x0-0y0-0z0', 'surround 0 0');
 
 	# count
 	my @el;
@@ -207,7 +201,7 @@ sub test_s {
 
 	ok(_set_load_row(sub {
 		my ($database,$input,$mfn) = @_;
-		diag "load_row( $database, $input, $mfn )";
+		diag "load_row( $database, $input, $mfn )" if ($debug);
 		cmp_ok( $#_, '==', 2, 'have 3 arguments');
 		ok($database, '_load_row database');
 		ok($input, '_load_row input');
@@ -236,13 +230,13 @@ sub test_s {
 		);
 
 		ok(my $l = WebPAC::Normalize::_get_lookup(), '_get_lookup');
-		diag "_get_lookup = ", dump($l);
+		diag "_get_lookup = ", dump($l) if ($debug);
 
 		my @lookup;
 
 		ok(@lookup = lookup(
 				sub {
-					diag "in show";
+					diag "in show" if ($debug);
 					rec('900','x');
 				},
 				'db','input','key',
@@ -261,7 +255,7 @@ sub test_s {
 	}
 
 	ok(my $l = WebPAC::Normalize::_get_lookup(), '_get_lookup');
-	diag "_get_lookup = ", dump($l);
+	diag "_get_lookup = ", dump($l) if ($debug);
 
 	is_deeply( $l, {
 		db => {
@@ -281,7 +275,7 @@ sub test_s {
 
 #######
 
-	diag "lookup_hash1 = ", dump($lookup_hash1);
+	diag "lookup_hash1 = ", dump($lookup_hash1) if ($debug);
 	ok(_set_lookup( $lookup_hash1 ), '_set_lookup $lookup_hash1');
 
 	throws_ok { _set_load_row() } qr/CODE/, 'empty _set_load_row()';
@@ -364,15 +358,15 @@ sub test_s {
 
 	#ok(! lookup('non-existent'), 'lookup non-existant' );
 
-	_set_rec( $rec2 );
+	_set_ds( $rec2 );
 
 	test_s(qq{
-		tag('Title',
+		search_display('Title',
 			rec('200','a')
 		);
 	});
 	test_s(qq{
-		tag('Who',
+		search_display('Who',
 			join_with(" ",
 				rec('702','a'),
 				rec('702','b')
@@ -423,11 +417,16 @@ sub test_s {
 	test_check_ds('display');
 
 	_clean_ds();
-	test_s(qq{ tag('something', '42'); });
-	test_s(qq{ tag('empty', ''); });
+	test_s(qq{ search_display('something', '42'); });
+	test_s(qq{ search_display('empty', ''); });
 	test_check_ds('search');
 	test_check_ds('display');
 
+	_clean_ds();
+	test_s(qq{ sorted('something', '42'); });
+	test_s(qq{ sorted('empty', ''); });
+	test_check_ds('sorted');
+
 	_clean_ds();
 	my $n = read_file( "$abs_path/data/normalize.pl" );
 	$n .= "\n1;\n";
@@ -446,13 +445,12 @@ sub test_s {
 	my $rules = qq{ search('mixed', rec('200') ) };
 	
 	_clean_ds();
-	_set_rec( $rec );
+	_set_ds( $rec );
 	test_s( $rules );
 	ok($ds = _get_ds(), "get_ds");
 	is_deeply( $ds, {
 		'mixed' => {
 			'search' => [ '200a', '200b' ],
-			'tag' => 'mixed'
 		}
 	}, 'correct get_ds');
 
@@ -464,7 +462,7 @@ sub test_s {
 
 	# wird and non-valid structure which is supported anyway
 	_clean_ds();
-	_set_rec({
+	_set_ds({
 		'200' => [{
 			'a' => '200a',
 		},
@@ -476,7 +474,6 @@ sub test_s {
 	is_deeply( $ds, {
 		'mixed' => {
 			'search' => [ '200a', '200-solo' ],
-			'tag' => 'mixed'
 		}
 	}, 'correct get_ds');
 
@@ -488,7 +485,7 @@ sub test_s {
 	test_s(qq{ marc_indicators('900',1,2) });
 	test_s(qq{ marc('900','a', rec('200') ) });
 	my $marc;
-	ok($marc = WebPAC::Normalize::_get_marc_fields(), "_get_marc_fields");
+	ok($marc = WebPAC::Normalize::MARC::_get_marc_fields(), "_get_marc_fields");
 	diag dump( $marc ) if ($debug);
 
 	is_deeply( $marc, [
@@ -499,7 +496,7 @@ sub test_s {
 	test_s(qq{ marc_indicators('900',' ',9) });
 	test_s(qq{ marc_repeatable_subfield('900','a', rec('200') ) });
 
-	ok($marc = WebPAC::Normalize::_get_marc_fields(), "_get_marc_fields");
+	ok($marc = WebPAC::Normalize::MARC::_get_marc_fields(), "_get_marc_fields");
 	diag dump( $marc ) if ($debug);
 
 	is_deeply( $marc, [
@@ -515,17 +512,18 @@ sub test_s {
 		my ($msg, $rec, $rules, $struct) = @_;
 
 		_clean_ds();
-		_set_rec($rec);
+		_set_ds($rec);
 
-		foreach my $r (split(/;/, $rules)) {
+		foreach my $r (split(/;\s*$/, $rules)) {
 			$r =~ s/[\s\n\r]+/ /gs;
 			$r =~ s/^\s+//gs;
 			$r =~ s/\s+$//gs;
+			diag "rule: $r" if $debug;
 			test_s($r) if ($r);
 		}
 
-		ok(my $marc = WebPAC::Normalize::_get_marc_fields(), "_get_marc_fields");
-		diag dump( $marc ) if ($debug);
+		ok(my $marc = WebPAC::Normalize::MARC::_get_marc_fields(), "_get_marc_fields");
+		diag dump( $marc ) if $debug;
 		diag "expects:\n", dump($struct) if ($debug > 1);
 		is_deeply( $marc, $struct, $msg );
 	}
@@ -624,7 +622,7 @@ sub test_s {
 	sub test_rule {
 		my ($msg, $rec, $rule, $struct) = @_;
 		_clean_ds();
-		_set_rec( $rec );
+		_set_ds( $rec );
 		$rule =~ s/\\/\\/gs;
 		my $r = test_s( $rule );
 		diag "for ", dump($rec), " got:\n", dump($r), "\nexpect:\n" if ($debug > 1);
@@ -734,21 +732,26 @@ sub test_s {
 	);
 
 	test_s(qq{ marc_remove('*'); });
-	ok(! WebPAC::Normalize::_get_marc_fields(), 'marc_remove(*)');
+	ok(! WebPAC::Normalize::MARC::_get_marc_fields(), 'marc_remove(*)');
 
 	test_rec_rules(
 		'marc_duplicate',
 		{ '200' => [{ a => 42, b => 'bar', c => 'baz', d => 'bing', e => 'bong' }] },
 		qq{
+			marc_leader('06',42);
+			marc_leader('11',0);
 			marc('900', 'a', rec('200','a') );
 			marc('900', 'b', rec('200','b') );
 			marc_duplicate;
+			marc_leader('11',1);
 			marc_remove('900','b');
 			marc('900', 'b', rec('200','c') );
 			marc_duplicate;
+			marc_leader('11',2);
 			marc_remove('900','b');
 			marc('900', 'b', rec('200','d') );
 			marc_duplicate;
+			marc_leader('11',3);
 			marc_remove('900','b');
 			marc('900', 'b', rec('200','e') );
 		},
@@ -758,10 +761,12 @@ sub test_s {
 		],
 	);
 
+	cmp_ok( marc_count(), '==', 3, 'marc_count' );
+
 	my $i = 0;
 	foreach my $v ( qw/bar baz bing bong/ ) {
 
-		ok($marc = WebPAC::Normalize::_get_marc_fields( offset => $i ),
+		ok($marc = WebPAC::Normalize::MARC::_get_marc_fields( offset => $i ),
 			"_get_marc_fields( offset => $i )"
 		);
 		diag "marc $i = ", dump( $marc ) if ($debug);
@@ -769,6 +774,7 @@ sub test_s {
 			[ [ '900', ' ', ' ', 'a', 42, 'b', $v ] ],
 			"MARC copy $i has $v",
 		);
+		is_deeply(WebPAC::Normalize::MARC::_get_marc_leader(), { '06' => 42, 11 => $i }, "_get_marc_leader copy $i");
 		$i++;
 	}
 
@@ -827,5 +833,68 @@ sub test_s {
 		'^aa1^bb1^aa2^bb2^cc1^cc2',
 		'_pack_subfields_hash( $h, 1 )'
 	);
+
+	_clean_ds();
+	test_s(qq{
+		marc_fixed('008', 0, 'abcdef');
+		marc_fixed('000', 5, '5');
+		marc_fixed('000', 10, 'A');
+		marc_fixed('000', 0, '0');
+	});
+	ok( my $m = WebPAC::Normalize::MARC::_get_marc_fields(), '_get_marc_fields');
+	diag dump( $m );
+	is_deeply( WebPAC::Normalize::MARC::_get_marc_fields(),
+		[
+			["008", "abcdef"], 
+			#        0....5....10
+			["000", "0    5    A"]
+		]
+	);
+
+	test_s(qq{ isbn_13( '1558607013', '978-1558607019' ) });
+	test_s(qq{ isbn_10( '1558607013', '978-1558607019' ) });
+
+	is_deeply(
+		[ isbn_13( '1558607013', '978-1558607019' ) ],
+		[ '978-1-55860-701-9', '978-1-55860-701-9', ],
+	'isbn_13' );
+
+	is_deeply(
+		[ isbn_10( '1558607013', '978-1558607019' ) ],
+		[ '1-55860-701-3', '1-55860-701-3' ],
+	'isbn_10' );
+
+	# frec
+
+	my $rec = {
+			'200' => [ {
+				a => [ 'a1', 'a2' ], b => [ 'b1', 'b2' ], c => [ 'c1', 'c2' ],
+				subfields => [ qw/a 0 b 0 a 1 b 1 c 0 c 1/ ],
+				i1 => '0', i2 => '1',
+			}, {
+				a => [ 'a3', 'a4', 'a5' ], b => 'b3', c => 'c3',
+				subfields => [ qw/a 0 a 1 b 0 c 0 a 2/ ],
+			} ],
+	};
+
+	test_rule( 'frec', $rec, qq{ frec(200) }, [ 'a1' ] );
+	test_rule( 'frec', $rec, qq{ frec(200,'a') }, [ 'a1' ] );
+	test_rule( 'frec', $rec, qq{ frec(200,'b') }, [ 'b1' ] );
+	test_rule( 'frec', $rec, qq{ frec(200,'c') }, [ 'c1' ] );
+
+	$rec->{'900'} = $rec->{'200'};
+	foreach my $sf ( qw/a b c/ ) {
+		ok( frec_eq( '200' => $sf, '900' => $sf ), "frec_eq 200 == 900 $sf");
+		ok( ! frec_ne( '200' => $sf, '900' => $sf ), "! frec_ne 200 == 900 $sf");
+	}
+
+	foreach my $sf ( qw/a b/ ) {
+		ok( ! frec_eq( '200' => $sf, '200' => 'c' ), "! frec_eq 200 $sf == 200 c");
+		ok( frec_ne( '200' => $sf, '200' => 'c' ), "frec_ne 200 $sf == 200 c");
+	}
+
+	test_rule( 'rec(200,i1)', $rec, qq{ rec(200,'i1') }, [ '0' ] );
+	test_rule( 'rec(200,i2)', $rec, qq{ rec(200,'i2') }, [ '1' ] );
+
 }