X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=t%2FClassSortRoutine_LCC.t;h=9ec37cfc690417370521ed0158ee146270a7e801;hb=89a8a17fdc793b145fc0d7bdcef601698b36fdaa;hp=573c8fe840e1159b652e9e6aa0d8f864915d51a2;hpb=ba6c8485ca7afdaaace20d021591ac532de55b3a;p=koha.git

diff --git a/t/ClassSortRoutine_LCC.t b/t/ClassSortRoutine_LCC.t
index 573c8fe840..9ec37cfc69 100755
--- a/t/ClassSortRoutine_LCC.t
+++ b/t/ClassSortRoutine_LCC.t
@@ -6,7 +6,7 @@
 use strict;
 use warnings;
 
-use Test::More tests => 9;
+use Test::More tests => 10;
 
 BEGIN {
         use_ok('C4::ClassSortRoutine::LCC');
@@ -14,14 +14,32 @@ BEGIN {
 
 #Obvious cases
 is(C4::ClassSortRoutine::LCC::get_class_sort_key(), "", "No arguments returns an empty string");
-is(C4::ClassSortRoutine::LCC::get_class_sort_key('a','b'), "A_B", "Arguments 'a','b' return 'A_B'");
+is(C4::ClassSortRoutine::LCC::get_class_sort_key('a','b'), "A B", "Arguments 'a','b' return 'A B'");
 
 #spaces in arguements
-is(C4::ClassSortRoutine::LCC::get_class_sort_key(' ','b'), "B_", "Arguments ' ','b' return 'B_'");
-is(C4::ClassSortRoutine::LCC::get_class_sort_key('a',' '), "A_", "Arguments 'a',' ' return 'A_'");
+is(C4::ClassSortRoutine::LCC::get_class_sort_key(' ','b'), "B", "Arguments ' ','b' return 'B'");
+is(C4::ClassSortRoutine::LCC::get_class_sort_key('a',' '), "A", "Arguments 'a',' ' return 'A'");
 is(C4::ClassSortRoutine::LCC::get_class_sort_key(' ','    '), "", "Arguments ' ','    ' return ''");
 
 #'funky cases' based on regex in code
-is(C4::ClassSortRoutine::LCC::get_class_sort_key('.','b'), "_B", "Arguments '.','b' return '_B'");
-is(C4::ClassSortRoutine::LCC::get_class_sort_key('....','........'), "_______", "Arguments '....','........' return '_______'");
-is(C4::ClassSortRoutine::LCC::get_class_sort_key('.','.'), "__", "Arguments '.','.' return '__'");
+is(C4::ClassSortRoutine::LCC::get_class_sort_key('.','b'), "", "Arguments '.','b' return ''");
+is(C4::ClassSortRoutine::LCC::get_class_sort_key('....','........'), "", "Arguments '....','........' return ''");
+is(C4::ClassSortRoutine::LCC::get_class_sort_key('.','.'), "", "Arguments '.','.' return ''");
+
+# list of example call numbers -- these
+# are intentionally in the _reverse_ of
+# the correct sort order
+my @call_numbers = (
+    'SB410.9 .P26 1993',
+    'SB410.A26 I75 2000',
+    'QC995 .E29 1997',
+    'QC145.45 .H4 D65 1998',
+    'QC145 .A57 V.12 1980',
+    'QC100 .U57 NO. 555 1986',
+);
+
+my @sorted_call_numbers = map { $_->{call_number} }
+                          sort { $a->{sortkey} cmp $b->{sortkey} }
+                          map { { call_number => $_, sortkey => C4::ClassSortRoutine::LCC::get_class_sort_key($_, '') } }
+                          @call_numbers;
+is_deeply(\@sorted_call_numbers, [ reverse @call_numbers ], 'LC call numbers sorted in correct order');