X-Git-Url: http://git.rot13.org/?a=blobdiff_plain;f=t%2Fdb_dependent%2FHolds.t;h=e2066c7a88c3cec24a82c72ee7c743f49d2f7dd7;hb=2b765487705fa90298f8e843b660df386bbc1730;hp=4ec478081014f8ca499ae6fb5007fc803e0ac0e0;hpb=7f7a6879b2df3cf52c56f4d75d020e34e60e7221;p=koha.git

diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t
index 4ec4780810..e2066c7a88 100755
--- a/t/db_dependent/Holds.t
+++ b/t/db_dependent/Holds.t
@@ -7,22 +7,28 @@ use t::lib::TestBuilder;
 
 use C4::Context;
 
-use Test::More tests => 54;
+use Test::More tests => 57;
 use MARC::Record;
+
 use C4::Biblio;
-use C4::Items;
-use C4::Members;
 use C4::Calendar;
+use C4::Items;
+use C4::Reserves;
+
+use Koha::Biblios;
+use Koha::CirculationRules;
 use Koha::Database;
 use Koha::DateUtils qw( dt_from_string output_pref );
-use Koha::Biblios;
 use Koha::Holds;
+use Koha::IssuingRules;
+use Koha::Item::Transfer::Limits;
+use Koha::Items;
+use Koha::Libraries;
 use Koha::Patrons;
 
 BEGIN {
     use FindBin;
     use lib $FindBin::Bin;
-    use_ok('C4::Reserves');
 }
 
 my $schema  = Koha::Database->new->schema;
@@ -48,45 +54,41 @@ $insert_sth->execute('DUMMY');
 $insert_sth->execute('ONLY1');
 
 # Setup Test------------------------
-# Create a biblio instance for testing
-my ($bibnum, $title, $bibitemnum) = create_helper_biblio('DUMMY');
+my $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
 
 # Create item instance for testing.
 my ($item_bibnum, $item_bibitemnum, $itemnumber)
-    = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $bibnum);
+    = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $biblio->biblionumber);
 
 # Create some borrowers
 my @borrowernumbers;
 foreach (1..$borrowers_count) {
-    my $borrowernumber = AddMember(
+    my $borrowernumber = Koha::Patron->new({
         firstname =>  'my firstname',
         surname => 'my surname ' . $_,
         categorycode => $category->{categorycode},
         branchcode => $branch_1,
-    );
+    })->store->borrowernumber;
     push @borrowernumbers, $borrowernumber;
 }
 
-my $biblionumber = $bibnum;
-
 # Create five item level holds
 foreach my $borrowernumber ( @borrowernumbers ) {
     AddReserve(
         $branch_1,
         $borrowernumber,
-        $biblionumber,
+        $biblio->biblionumber,
         my $bibitems = q{},
-        my $priority = C4::Reserves::CalculatePriority( $biblionumber ),
+        my $priority = C4::Reserves::CalculatePriority( $biblio->biblionumber ),
         my $resdate,
         my $expdate,
         my $notes = q{},
-        $title,
+        'a title',
         my $checkitem = $itemnumber,
         my $found,
     );
 }
 
-my $biblio = Koha::Biblios->find( $biblionumber );
 my $holds = $biblio->holds;
 is( $holds->count, $borrowers_count, 'Test GetReserves()' );
 is( $holds->next->priority, 1, "Reserve 1 has a priority of 1" );
@@ -147,6 +149,15 @@ ok( $hold->priority eq '4', "Test ModReserve, priority changed correctly" );
 ok( $hold->suspend, "Test ModReserve, suspend hold" );
 is( $hold->suspend_until, '2013-01-01 00:00:00', "Test ModReserve, suspend until date" );
 
+ModReserve({ # call without reserve_id
+    rank          => '3',
+    biblionumber  => $item_bibnum,
+    itemnumber    => $itemnumber,
+    borrowernumber => $borrowernumber,
+});
+$hold = Koha::Holds->find( $reserve_id );
+ok( $hold->priority eq '3', "Test ModReserve, priority changed correctly" );
+
 ToggleSuspend( $reserve_id );
 $hold = Koha::Holds->find( $reserve_id );
 ok( ! $hold->suspend, "Test ToggleSuspend(), no date" );
@@ -161,7 +172,7 @@ ok( ! $hold->suspend, "Test AutoUnsuspendReserves()" );
 
 SuspendAll(
     borrowernumber => $borrowernumber,
-    biblionumber   => $biblionumber,
+    biblionumber   => $biblio->biblionumber,
     suspend => 1,
     suspend_until => '2012-01-01',
 );
@@ -171,7 +182,7 @@ is( $hold->suspend_until, '2012-01-01 00:00:00', "Test SuspendAll(), with date"
 
 SuspendAll(
     borrowernumber => $borrowernumber,
-    biblionumber   => $biblionumber,
+    biblionumber   => $biblio->biblionumber,
     suspend => 0,
 );
 $hold = Koha::Holds->find( $reserve_id );
@@ -182,38 +193,38 @@ is( $hold->suspend_until, undef, "Test resuming with SuspendAll(), should have n
 AddReserve(
     $branch_1,
     $borrowernumbers[0],
-    $biblionumber,
+    $biblio->biblionumber,
     my $bibitems = q{},
     my $priority,
     my $resdate,
     my $expdate,
     my $notes = q{},
-    $title,
+    'a title',
     my $checkitem,
     my $found,
 );
 $patron = Koha::Patrons->find( $borrowernumber );
 $holds = $patron->holds;
-my $reserveid = Koha::Holds->search({ biblionumber => $bibnum, borrowernumber => $borrowernumbers[0] })->next->reserve_id;
+my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $borrowernumbers[0] })->next->reserve_id;
 ModReserveMinusPriority( $itemnumber, $reserveid );
 $holds = $patron->holds;
 is( $holds->next->itemnumber, $itemnumber, "Test ModReserveMinusPriority()" );
 
 $holds = $biblio->holds;
 $hold = $holds->next;
-AlterPriority( 'top', $hold->reserve_id );
+AlterPriority( 'top', $hold->reserve_id, undef, 2, 1, 6 );
 $hold = Koha::Holds->find( $reserveid );
 is( $hold->priority, '1', "Test AlterPriority(), move to top" );
 
-AlterPriority( 'down', $hold->reserve_id );
+AlterPriority( 'down', $hold->reserve_id, undef, 2, 1, 6 );
 $hold = Koha::Holds->find( $reserveid );
 is( $hold->priority, '2', "Test AlterPriority(), move down" );
 
-AlterPriority( 'up', $hold->reserve_id );
+AlterPriority( 'up', $hold->reserve_id, 1, 3, 1, 6 );
 $hold = Koha::Holds->find( $reserveid );
 is( $hold->priority, '1', "Test AlterPriority(), move up" );
 
-AlterPriority( 'bottom', $hold->reserve_id );
+AlterPriority( 'bottom', $hold->reserve_id, undef, 2, 1, 6 );
 $hold = Koha::Holds->find( $reserveid );
 is( $hold->priority, '6', "Test AlterPriority(), move to bottom" );
 
@@ -228,9 +239,9 @@ is( $hold->priority, '6', "Test AlterPriority(), move to bottom" );
 # Note that canreservefromotherbranches has no effect if
 # IndependentBranches is OFF.
 
-my ($foreign_bibnum, $foreign_title, $foreign_bibitemnum) = create_helper_biblio('DUMMY');
+my $foreign_biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
 my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber)
-  = AddItem({ homebranch => $branch_2, holdingbranch => $branch_2 } , $foreign_bibnum);
+  = AddItem({ homebranch => $branch_2, holdingbranch => $branch_2 } , $foreign_biblio->biblionumber);
 $dbh->do('DELETE FROM issuingrules');
 $dbh->do(
     q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record)
@@ -252,7 +263,7 @@ t::lib::Mocks::mock_preference('item-level_itypes', 1);
 # if IndependentBranches is OFF, a $branch_1 patron can reserve an $branch_2 item
 t::lib::Mocks::mock_preference('IndependentBranches', 0);
 ok(
-    CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'OK',
+    CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status} eq 'OK',
     '$branch_1 patron allowed to reserve $branch_2 item with IndependentBranches OFF (bug 2394)'
 );
 
@@ -260,27 +271,27 @@ ok(
 t::lib::Mocks::mock_preference('IndependentBranches', 1);
 t::lib::Mocks::mock_preference('canreservefromotherbranches', 0);
 ok(
-    CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'cannotReserveFromOtherBranches',
+    CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status} eq 'cannotReserveFromOtherBranches',
     '$branch_1 patron NOT allowed to reserve $branch_2 item with IndependentBranches ON ... (bug 2394)'
 );
 
 # ... unless canreservefromotherbranches is ON
 t::lib::Mocks::mock_preference('canreservefromotherbranches', 1);
 ok(
-    CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber) eq 'OK',
+    CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber)->{status} eq 'OK',
     '... unless canreservefromotherbranches is ON (bug 2394)'
 );
 
 {
     # Regression test for bug 11336 # Test if ModReserve correctly recalculate the priorities
-    ($bibnum, $title, $bibitemnum) = create_helper_biblio('DUMMY');
-    ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $bibnum);
-    my $reserveid1 = AddReserve($branch_1, $borrowernumbers[0], $bibnum, '', 1);
-    ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $bibnum);
-    my $reserveid2 = AddReserve($branch_1, $borrowernumbers[1], $bibnum, '', 2);
-    ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $bibnum);
-    my $reserveid3 = AddReserve($branch_1, $borrowernumbers[2], $bibnum, '', 3);
-    my $hhh = Koha::Holds->search({ biblionumber => $bibnum });
+    $biblio = $builder->build_sample_biblio({ itemtype => 'DUMMY' });
+    ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $biblio->biblionumber);
+    my $reserveid1 = AddReserve($branch_1, $borrowernumbers[0], $biblio->biblionumber, '', 1);
+    ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $biblio->biblionumber);
+    my $reserveid2 = AddReserve($branch_1, $borrowernumbers[1], $biblio->biblionumber, '', 2);
+    ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1 } , $biblio->biblionumber);
+    my $reserveid3 = AddReserve($branch_1, $borrowernumbers[2], $biblio->biblionumber, '', 3);
+    my $hhh = Koha::Holds->search({ biblionumber => $biblio->biblionumber });
     my $hold3 = Koha::Holds->find( $reserveid3 );
     is( $hold3->priority, 3, "The 3rd hold should have a priority set to 3" );
     ModReserve({ reserve_id => $reserveid1, rank => 'del' });
@@ -290,7 +301,7 @@ ok(
 
 ModItem({ damaged => 1 }, $item_bibnum, $itemnumber);
 t::lib::Mocks::mock_preference( 'AllowHoldsOnDamagedItems', 1 );
-is( CanItemBeReserved( $borrowernumbers[0], $itemnumber), 'OK', "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" );
+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status}, 'OK', "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" );
 ok( defined( ( CheckReserves($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" );
 
 $hold = Koha::Hold->new(
@@ -300,39 +311,39 @@ $hold = Koha::Hold->new(
         biblionumber   => $item_bibnum,
     }
 )->store();
-is( CanItemBeReserved( $borrowernumbers[0], $itemnumber ),
+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
     'itemAlreadyOnHold',
     "Patron cannot place a second item level hold for a given item" );
 $hold->delete();
 
 t::lib::Mocks::mock_preference( 'AllowHoldsOnDamagedItems', 0 );
-ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'damaged', "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" );
+ok( CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status} eq 'damaged', "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" );
 ok( !defined( ( CheckReserves($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
 
 # Regression test for bug 9532
-($bibnum, $title, $bibitemnum) = create_helper_biblio('CANNOT');
-($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $bibnum);
+$biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' });
+($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $biblio->biblionumber);
 AddReserve(
     $branch_1,
     $borrowernumbers[0],
-    $bibnum,
+    $biblio->biblionumber,
     '',
     1,
 );
 is(
-    CanItemBeReserved( $borrowernumbers[0], $itemnumber), 'tooManyReserves',
+    CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status}, 'tooManyReserves',
     "cannot request item if policy that matches on item-level item type forbids it"
 );
 ModItem({ itype => 'CAN' }, $item_bibnum, $itemnumber);
 ok(
-    CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'OK',
+    CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status} eq 'OK',
     "can request item if policy that matches on item type allows it"
 );
 
 t::lib::Mocks::mock_preference('item-level_itypes', 0);
 ModItem({ itype => undef }, $item_bibnum, $itemnumber);
 ok(
-    CanItemBeReserved( $borrowernumbers[0], $itemnumber) eq 'tooManyReserves',
+    CanItemBeReserved( $borrowernumbers[0], $itemnumber)->{status} eq 'tooManyReserves',
     "cannot request item if policy that matches on bib-level item type forbids it (bug 9532)"
 );
 
@@ -358,21 +369,21 @@ $dbh->do(q{
     INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch)
     VALUES (?, ?, ?, ?)
 }, {}, $branch_1, 'CAN', 1, 'homebranch');
-($bibnum, $title, $bibitemnum) = create_helper_biblio('CANNOT');
+$biblio = $builder->build_sample_biblio({ itemtype => 'CANNOT' });
 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
-    { homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $bibnum);
-is(CanItemBeReserved($borrowernumbers[0], $itemnumber), 'notReservable',
+    { homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CANNOT' } , $biblio->biblionumber);
+is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status}, 'notReservable',
     "CanItemBeReserved should return 'notReservable'");
 
 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
-    { homebranch => $branch_2, holdingbranch => $branch_1, itype => 'CAN' } , $bibnum);
-is(CanItemBeReserved($borrowernumbers[0], $itemnumber),
+    { homebranch => $branch_2, holdingbranch => $branch_1, itype => 'CAN' } , $biblio->biblionumber);
+is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status},
     'cannotReserveFromOtherBranches',
     "CanItemBeReserved should return 'cannotReserveFromOtherBranches'");
 
 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem(
-    { homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CAN' } , $bibnum);
-is(CanItemBeReserved($borrowernumbers[0], $itemnumber), 'OK',
+    { homebranch => $branch_1, holdingbranch => $branch_1, itype => 'CAN' } , $biblio->biblionumber);
+is(CanItemBeReserved($borrowernumbers[0], $itemnumber)->{status}, 'OK',
     "CanItemBeReserved should return 'OK'");
 
 # Bug 12632
@@ -384,9 +395,9 @@ $dbh->do('DELETE FROM issues');
 $dbh->do('DELETE FROM items');
 $dbh->do('DELETE FROM biblio');
 
-( $bibnum, $title, $bibitemnum ) = create_helper_biblio('ONLY1');
+$biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' });
 ( $item_bibnum, $item_bibitemnum, $itemnumber )
-    = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $bibnum );
+    = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $biblio->biblionumber );
 
 $dbh->do(
     q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record)
@@ -394,24 +405,254 @@ $dbh->do(
     {},
     '*', '*', 'ONLY1', 1, 99
 );
-is( CanItemBeReserved( $borrowernumbers[0], $itemnumber ),
+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
     'OK', 'Patron can reserve item with hold limit of 1, no holds placed' );
 
-my $res_id = AddReserve( $branch_1, $borrowernumbers[0], $bibnum, '', 1, );
+my $res_id = AddReserve( $branch_1, $borrowernumbers[0], $biblio->biblionumber, '', 1, );
 
-is( CanItemBeReserved( $borrowernumbers[0], $itemnumber ),
+is( CanItemBeReserved( $borrowernumbers[0], $itemnumber )->{status},
     'tooManyReserves', 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' );
 
+subtest 'Test max_holds per library/patron category' => sub {
+    plan tests => 6;
+
+    $dbh->do('DELETE FROM reserves');
+    $dbh->do('DELETE FROM issuingrules');
+    $dbh->do('DELETE FROM circulation_rules');
+
+    $biblio = $builder->build_sample_biblio({ itemtype => 'TEST' });
+    ( $item_bibnum, $item_bibitemnum, $itemnumber ) =
+      AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 },
+        $biblio->biblionumber );
+    $dbh->do(
+        q{
+            INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record)
+            VALUES (?, ?, ?, ?, ?)
+        },
+        {},
+        '*', '*', 'TEST', 99, 99
+    );
+    AddReserve( $branch_1, $borrowernumbers[0], $biblio->biblionumber, '', 1, );
+    AddReserve( $branch_1, $borrowernumbers[0], $biblio->biblionumber, '', 1, );
+    AddReserve( $branch_1, $borrowernumbers[0], $biblio->biblionumber, '', 1, );
+
+    my $count =
+      Koha::Holds->search( { borrowernumber => $borrowernumbers[0] } )->count();
+    is( $count, 3, 'Patron now has 3 holds' );
+
+    my $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
+    is( $ret->{status}, 'OK', 'Patron can place hold with no borrower circ rules' );
+
+    my $rule_all = Koha::CirculationRules->set_rule(
+        {
+            categorycode => $category->{categorycode},
+            branchcode   => undef,
+            itemtype     => undef,
+            rule_name    => 'max_holds',
+            rule_value   => 3,
+        }
+    );
 
-# Helper method to set up a Biblio.
-sub create_helper_biblio {
-    my $itemtype = shift;
-    my $bib = MARC::Record->new();
-    my $title = 'Silence in the library';
-    $bib->append_fields(
-        MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
-        MARC::Field->new('245', ' ', ' ', a => $title),
-        MARC::Field->new('942', ' ', ' ', c => $itemtype),
+    my $rule_branch = Koha::CirculationRules->set_rule(
+        {
+            branchcode   => $branch_1,
+            categorycode => $category->{categorycode},
+            itemtype     => undef,
+            rule_name    => 'max_holds',
+            rule_value   => 5,
+        }
     );
-    return ($bibnum, $title, $bibitemnum) = AddBiblio($bib, '');
-}
+
+    $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
+    is( $ret->{status}, 'OK', 'Patron can place hold with branch/category rule of 5, category rule of 3' );
+
+    $rule_branch->delete();
+
+    $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
+    is( $ret->{status}, 'tooManyReserves', 'Patron cannot place hold with only a category rule of 3' );
+
+    $rule_all->delete();
+    $rule_branch->rule_value(3);
+    $rule_branch->store();
+
+    $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
+    is( $ret->{status}, 'tooManyReserves', 'Patron cannot place hold with only a branch/category rule of 3' );
+
+    $rule_branch->rule_value(5);
+    $rule_branch->update();
+    $rule_branch->rule_value(5);
+    $rule_branch->store();
+
+    $ret = CanItemBeReserved( $borrowernumbers[0], $itemnumber );
+    is( $ret->{status}, 'OK', 'Patron can place hold with branch/category rule of 5, category rule of 5' );
+};
+
+subtest 'Pickup location availability tests' => sub {
+    plan tests => 4;
+
+    $biblio = $builder->build_sample_biblio({ itemtype => 'ONLY1' });
+    my ( $item_bibnum, $item_bibitemnum, $itemnumber )
+    = AddItem( { homebranch => $branch_1, holdingbranch => $branch_1 }, $biblio->biblionumber );
+    #Add a default rule to allow some holds
+    $dbh->do(
+        q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record)
+          VALUES (?, ?, ?, ?, ?)},
+        {},
+        '*', '*', '*', 25, 99
+    );
+    my $item = Koha::Items->find($itemnumber);
+    my $branch_to = $builder->build({ source => 'Branch' })->{ branchcode };
+    my $library = Koha::Libraries->find($branch_to);
+    $library->pickup_location('1')->store;
+    my $patron = $builder->build({ source => 'Borrower' })->{ borrowernumber };
+
+    t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1);
+    t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'itemtype');
+
+    $library->pickup_location('1')->store;
+    is(CanItemBeReserved($patron, $item->itemnumber, $branch_to)->{status},
+       'OK', 'Library is a pickup location');
+
+    my $limit = Koha::Item::Transfer::Limit->new({
+        fromBranch => $item->holdingbranch,
+        toBranch => $branch_to,
+        itemtype => $item->effective_itemtype,
+    })->store;
+    is(CanItemBeReserved($patron, $item->itemnumber, $branch_to),
+       'cannotBeTransferred', 'Item cannot be transferred');
+    $limit->delete;
+
+    $library->pickup_location('0')->store;
+    is(CanItemBeReserved($patron, $item->itemnumber, $branch_to)->{status},
+       'libraryNotPickupLocation', 'Library is not a pickup location');
+    is(CanItemBeReserved($patron, $item->itemnumber, 'nonexistent')->{status},
+       'libraryNotFound', 'Cannot set unknown library as pickup location');
+};
+
+$schema->storage->txn_rollback;
+
+subtest 'CanItemBeReserved / holds_per_day tests' => sub {
+
+    plan tests => 9;
+
+    $schema->storage->txn_begin;
+
+    Koha::Holds->search->delete;
+    $dbh->do('DELETE FROM issues');
+    Koha::Items->search->delete;
+    Koha::Biblios->search->delete;
+
+    my $itemtype = $builder->build_object( { class => 'Koha::ItemTypes' } );
+    my $library  = $builder->build_object( { class => 'Koha::Libraries' } );
+    my $patron   = $builder->build_object( { class => 'Koha::Patrons' } );
+
+    # Create 3 biblios with items
+    my $biblio_1 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
+    my ( undef, undef, $itemnumber_1 ) = AddItem(
+        {   homebranch    => $library->branchcode,
+            holdingbranch => $library->branchcode
+        },
+        $biblio_1->biblionumber
+    );
+    my $biblio_2 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
+    my ( undef, undef, $itemnumber_2 ) = AddItem(
+        {   homebranch    => $library->branchcode,
+            holdingbranch => $library->branchcode
+        },
+        $biblio_2->biblionumber
+    );
+    my $biblio_3 = $builder->build_sample_biblio({ itemtype => $itemtype->itemtype });
+    my ( undef, undef, $itemnumber_3 ) = AddItem(
+        {   homebranch    => $library->branchcode,
+            holdingbranch => $library->branchcode
+        },
+        $biblio_3->biblionumber
+    );
+
+    Koha::IssuingRules->search->delete;
+    my $issuingrule = Koha::IssuingRule->new(
+        {   categorycode     => '*',
+            branchcode       => '*',
+            itemtype         => $itemtype->itemtype,
+            reservesallowed  => 1,
+            holds_per_record => 99,
+            holds_per_day    => 2
+        }
+    )->store;
+
+    is_deeply(
+        CanItemBeReserved( $patron->borrowernumber, $itemnumber_1 ),
+        { status => 'OK' },
+        'Patron can reserve item with hold limit of 1, no holds placed'
+    );
+
+    AddReserve( $library->branchcode, $patron->borrowernumber, $biblio_1->biblionumber, '', 1, );
+
+    is_deeply(
+        CanItemBeReserved( $patron->borrowernumber, $itemnumber_1 ),
+        { status => 'tooManyReserves', limit => 1 },
+        'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed'
+    );
+
+    # Raise reservesallowed to avoid tooManyReserves from it
+    $issuingrule->set( { reservesallowed => 3 } )->store;
+
+    is_deeply(
+        CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
+        { status => 'OK' },
+        'Patron can reserve item with 2 reserves daily cap'
+    );
+
+    # Add a second reserve
+    my $res_id = AddReserve( $library->branchcode, $patron->borrowernumber, $biblio_2->biblionumber, '', 1, );
+    is_deeply(
+        CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
+        { status => 'tooManyReservesToday', limit => 2 },
+        'Patron cannot a third item with 2 reserves daily cap'
+    );
+
+    # Update last hold so reservedate is in the past, so 2 holds, but different day
+    $hold = Koha::Holds->find($res_id);
+    my $yesterday = dt_from_string() - DateTime::Duration->new( days => 1 );
+    $hold->reservedate($yesterday)->store;
+
+    is_deeply(
+        CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
+        { status => 'OK' },
+        'Patron can reserve item with 2 bib level hold placed on different days, 2 reserves daily cap'
+    );
+
+    # Set holds_per_day to 0
+    $issuingrule->set( { holds_per_day => 0 } )->store;
+
+    # Delete existing holds
+    Koha::Holds->search->delete;
+    is_deeply(
+        CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
+        { status => 'tooManyReservesToday', limit => 0 },
+        'Patron cannot reserve if holds_per_day is 0 (i.e. 0 is 0)'
+    );
+
+    $issuingrule->set( { holds_per_day => undef } )->store;
+    Koha::Holds->search->delete;
+    is_deeply(
+        CanItemBeReserved( $patron->borrowernumber, $itemnumber_2 ),
+        { status => 'OK' },
+        'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)'
+    );
+    AddReserve( $library->branchcode, $patron->borrowernumber, $biblio_1->biblionumber, '', 1, );
+    AddReserve( $library->branchcode, $patron->borrowernumber, $biblio_2->biblionumber, '', 1, );
+    is_deeply(
+        CanItemBeReserved( $patron->borrowernumber, $itemnumber_3 ),
+        { status => 'OK' },
+        'Patron can reserve if holds_per_day is undef (i.e. undef is unlimited daily cap)'
+    );
+    AddReserve( $library->branchcode, $patron->borrowernumber, $biblio_3->biblionumber, '', 1, );
+    is_deeply(
+        CanItemBeReserved( $patron->borrowernumber, $itemnumber_3 ),
+        { status => 'tooManyReserves', limit => 3 },
+        'Unlimited daily holds, but reached reservesallowed'
+    );
+
+    $schema->storage->txn_rollback;
+};