Bug 7034: de-nesting C4/Branch.pm
authorPaul Poulain <paul.poulain@biblibre.com>
Fri, 16 Sep 2011 16:09:57 +0000 (18:09 +0200)
committerChris Cormack <chrisc@catalyst.net.nz>
Tue, 18 Oct 2011 14:23:31 +0000 (03:23 +1300)
commit69732f5c62337a97269d8b0b09343805a970c6fa
treeaf22b035a19f9f737934b99e0319a242faa3b79b
parent9c84f38b3496f32037a97b441aab21e8c2647250
Bug 7034: de-nesting C4/Branch.pm

use C4::Koha was loaded only to call C4::Koha::get_infos_of in get_branchinfos_of

the sub get_branchinfos_of was used nowhere
(checked with "grep -R get_branchinfos_of *")
only one reference was made to get_branchinfos_of, in reserve/request.pl, but the sub was not used in fact (maybe removed previously & silently)

This patch removes sub get_branchinfos_of and use C4::Koha in C4::Branch, as well as the reference in request.pl and the t test

The patch doesn't remove use C4::Branch in reserve/request.pl, as it's still used for other subroutines.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
C4/Branch.pm
reserve/request.pl
t/db_dependent/lib/KohaTest/Branch.pm