Bug 19088: plugins-upload causes error log noise
authorLee Jamison <ldjamison@marywood.edu>
Fri, 11 Aug 2017 18:58:53 +0000 (18:58 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 30 Aug 2017 18:05:56 +0000 (15:05 -0300)
commit1076a0edf32b621da54c53ea71595885f7e14c38
tree5216df5430fb0297ddfc12384d6153b8e40caf96
parent86e8612c020cea44be123be45f2e503af38ef98b
Bug 19088: plugins-upload causes error log noise

After uploading a plugin the error log indicates
use of uninitialized value in $op. This patch
silences the noise.

To test:
1) Set <enable_plugins> to 1 (one) in koha-conf.xml.
2) Set the UseKohaPlugins system preference to 'Enable'.
3) Navigate to Administration -> Manage plugins.
4) Install the test plugin KPZ file attached to this bug.
5) Notice the uninitialized value noise in the error log.
6) Uninstall the plugin (plack restart may be required if plack is
    enabled).
7) Apply patch.
8) Install the plugin again.
9) Notice no noise in the error log.
10) Run qa tools.
11) Run prove t/db_dependent/Plugins.t

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
plugins/plugins-upload.pl