Bug 4450 Use more consistent error returns in C4/Creators/*
authorColin Campbell <colin.campbell@ptfs-europe.com>
Thu, 6 May 2010 17:13:36 +0000 (13:13 -0400)
committerGalen Charlton <gmcharlt@gmail.com>
Fri, 7 May 2010 17:04:58 +0000 (13:04 -0400)
commit1f56a04cadc60f26b36f5599f24d0f380bc23828
tree42bffff01cfd8d6320badc81d33c0cf1e47c7c9c
parent46cbf7806cb24aa20d401e97a7bfeb75e5b2d1ca
Bug 4450 Use more consistent error returns in C4/Creators/*

A lot of routines were defaulting to return -1 in error conditions
but calling code was expecting a ref or object
use return with explicit undef (or emptyness in array context)
for these cases. Extended this to cases where return was not tested
( -1 might in some cases be legit data).

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 5cf2b78b6ffa401bc82b3f913c89828c38b8e4ed)
[RM note: ... thereby undoing the revert]
C4/Creators/Batch.pm
C4/Creators/Layout.pm
C4/Creators/Lib.pm
C4/Creators/PDF.pm
C4/Creators/Profile.pm
C4/Creators/Template.pm