Bug 14321: [QA Follow-up] Changes for Upload.pm and upload-file.pl
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 16 Sep 2015 11:53:38 +0000 (13:53 +0200)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 25 Sep 2015 15:02:52 +0000 (12:02 -0300)
commit1f5be3ffabdf259f4c415634359aa682d6455c45
tree9a7b68cbae142833f7e0a6c3ce5732fbb2fcce59
parent9e8d89dd70d1a5dde4dc700eea16b5b1d6edf3fe
Bug 14321: [QA Follow-up] Changes for Upload.pm and upload-file.pl

Based on QA comments, this patch does the following:
[1] Destroy an empty DESTROY.
[2] Promote some comment lines to POD.
[3] Use File::Spec->catfile in sub _full_fname.
[4] Remove variable interpolation from a sql query.
[5] Add a comment in upload-file.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Run the unit test again, and uploaded a file.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/Upload.pm
tools/upload-file.pl