Fines fixes: apparent problems with fines prevent processing.
authorJoe Atzberger <joe.atzberger@liblime.com>
Tue, 26 Aug 2008 03:57:01 +0000 (22:57 -0500)
committerHenri-Damien LAURENT <henridamien.laurent@biblibre.com>
Tue, 28 Oct 2008 21:09:27 +0000 (22:09 +0100)
commit2a8ba38bd3a8ccda748c725601d58e6b843d7a7e
tree2970fd57ad3a3b7a5f954e634ce8b1490eed5443
parentcce9d3156e0106f282ddad4172361d53c6d80cb6
Fines fixes: apparent problems with fines prevent processing.

CalcFine returned values that mismatched expectations in fines.pl.

fines.pl refactored: added debugging, prevent needless recreation of
Calendar objects by storing them in hash by branch.
Still outstanding problems with fines, including the output of a field
that has no other references in Koha (so is always undef) and the
incorrect description of FinesMode.

Calendar exported "new" erroneously.  I also cleaned up the queries to
avoid needlessly compiling additional statement handles.

Please test and consider application to 3.0 maintenance.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
C4/Calendar.pm
C4/Overdues.pm
misc/cronjobs/fines.pl
t/lib/KohaTest/Calendar.pm