Bug 9924 - Simplify and rename patron card creator error message include
authorOwen Leonard <oleonard@myacpl.org>
Mon, 25 Mar 2013 16:22:33 +0000 (12:22 -0400)
committerGalen Charlton <gmc@esilibrary.com>
Sun, 8 Sep 2013 19:19:23 +0000 (19:19 +0000)
commit3d8f462cce3779fd1963d623b051dbc79d2f799a
tree90d06bae01a41a77258f9f653540b6b74dac07af
parent6434f9264ac0415e1e52904dc953a00ee0806491
Bug 9924 - Simplify and rename patron card creator error message include

The patron card creator error message include uses a non-standard method
for displaying error messages, and is poorly-named.

This patch converts the method of displaying error messages for various
patron card creator options to the standard one ('<div class="dialog
alert">') and renames the include file to make it clear that it relates
only to patron card creator operations.

To test, perform various operations:

- Go to 'manage images' and try to upload a file which exceeds the
  500KBfile size limit
- Go to the edit batch page and manually append an error code to the
  URL:  /cgi-bin/koha/patroncards/edit-batch.pl?op=new&error=403
- Go to one of the manage pages and manually append an error code to the
  URL:
  /cgi-bin/koha/patroncards/manage.pl?card_element=profile&error=201

Correct display of an error message indicates that the include file is
being found.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes test plan, test suite and QA script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
koha-tmpl/intranet-tmpl/prog/en/includes/error-messages.inc [deleted file]
koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt