projects / koha.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1076a0e) | patch
Bug 19025: Move GetReserveInfo to Koha::Holds
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 2 Aug 2017 14:49:08 +0000 (11:49 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 30 Aug 2017 18:06:10 +0000 (15:06 -0300)
commit3ecc6fd8c68af0ed410ee2ea77060999993220a7
treeed3cc33b7505d67b095ea82b654aee6ac94d5271tree | snapshot
parent1076a0edf32b621da54c53ea71595885f7e14c38commit | diff
Bug 19025: Move GetReserveInfo to Koha::Holds

This subroutine is only used once and can be replaced with a call to
Koha::Holds->find
It will avoid unnecessary joins.

Test plan:
- Define a HOLD_SLIP template notice using fields from the tables
reserves, branches, borrowers, biblio, biblioitems and items.
- Generate one and make sure the values are correctly filled

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Reserves.pm diff | blob | history
t/db_dependent/Holds.t diff | blob | history
t/db_dependent/Reserves/GetReserveFee.t diff | blob | history
Koha ILS @ FFZG - based on git://git.koha.org/pub/scm/koha.git