Bug 17588: Koha::Patrons - Move GetMemberIssuesAndFines
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 8 Nov 2016 13:52:56 +0000 (13:52 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 20 Jan 2017 14:25:34 +0000 (14:25 +0000)
commit45cee0cec8684824d6e4e3cd83cd30b44c511c02
treed0802424e7de5c6602ae0eaca754b6abd9819262
parent42bef19fe9794394ff89eb864fd656295b5e60df
Bug 17588: Koha::Patrons - Move GetMemberIssuesAndFines

The GetMemberIssuesAndFines subroutine used to retrieve the issues,
overdues and fines for a given patron. Most of the time, only 1 or 2 of
these values were used.
This patch removes this subroutine and uses the new get_issues,
get_overdues and get_balance method from Koha::Patron and Koha::Account::Lines.

Test plan:
1/ Add overdues, issues and fines to different patrons
2/ On the checkout, checkin and patron search result and the patron
detail pages, these 3 informations, if displayed before this patch, must be
correctly displayed.
3/ Use the batch patron deletion tool and make sure that patrons with a
balance > 0 are not deleted

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Members.pm
C4/Utils/DataTables/Members.pm
C4/Utils/DataTables/VirtualShelves.pm
circ/circulation.pl
circ/returns.pl
members/moremember.pl
t/db_dependent/Reserves.t
tools/cleanborrowers.pl