platform/x86: dell-wmi: Fix driver interface version query
authorAndy Lutomirski <luto@kernel.org>
Tue, 1 Aug 2017 15:37:26 +0000 (08:37 -0700)
committerDarren Hart (VMware) <dvhart@infradead.org>
Tue, 1 Aug 2017 22:41:43 +0000 (15:41 -0700)
commit51391caf99e34d2d75ffc428845062d93aa739c6
tree79fc403fb880e3c3989788e3c28046eaafb7e12d
parent972777171f33f9932f51feebe42dbcc1b475d01a
platform/x86: dell-wmi: Fix driver interface version query

When I converted dell-wmi to the new bus infrastructure, I left the
call to dell_wmi_check_descriptor_buffer() in dell_wmi_init().  This
could cause two problems:

 - An error message when loading the driver on a system without
   dell-wmi.  We'd try to read the event descriptor even if the WMI
   GUID wasn't there.

 - A possible race if dell-wmi was loaded manually before wmi was
   fully initialized.

Fix it by moving the call to the probe function where it belongs.

Fixes: bff589be59c5 ("platform/x86: dell-wmi: Convert to the WMI bus infrastructure")
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
drivers/platform/x86/dell-wmi.c