Bug 20120: Prevent writeoffs of more than the amount owed for a fee
authorKyle M Hall <kyle@bywatetsolutions.com>
Fri, 9 Mar 2018 14:20:40 +0000 (09:20 -0500)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 8 Jun 2018 11:45:23 +0000 (11:45 +0000)
commit515cab0c46467efbdcb7e4cbbac7ccdb38e8845a
treec0b082ddf5e60ad92e895f2ac6315dfe1102261f
parentf8ea20344b931bb92e6b48639ae626f604853ffe
Bug 20120: Prevent writeoffs of more than the amount owed for a fee

In short, it is possible to 'over-writeoff' a fee such that the value of the fee is now a credit.

Test Plan:
1) Attempt to writeoff a single fee, set the amount input to more than
   the amount of the fee.
2) Note the writeoff makes the fee go negative.
3) Apply this patch
4) Attempt to repeat step 1, you should be unable to write-off an
   amount more than the amount outstanding for the fee!

Signed-off-by: George Williams <george@nekls.org>
Signed-off-by: George Williams <george@nekls.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
members/pay.pl
members/paycollect.pl