Bug 10030: QA Followup for trivial false warning detected while testing
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 15 May 2013 14:06:49 +0000 (16:06 +0200)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Thu, 16 May 2013 01:51:16 +0000 (21:51 -0400)
commit656aba3e1ff1a2eb69baf9bbab38cf4b37b38afe
treefcde016cc662d10ee74e4e8ae8d3f44f0c4abb5f
parent9fc4c64140640df25b7a6519226d3d097bd9b72c
Bug 10030: QA Followup for trivial false warning detected while testing

Moving the warn line below the line that returns if amount<=0.
If amount<=0, a false warn is now raised because of the return after it.
We should only warn here if we do not return.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested with fines.pl on overdue.
Before this patch:
Reducing fine for item 199709 borrower 23 from 44 to -1 - MaxFine reached.
This did not happen however because of the return.
After this change: no false warning.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
C4/Overdues.pm