Bug 22051: Make Koha::Object->store translate incorrect value exceptions
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 28 Dec 2018 15:15:53 +0000 (12:15 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 25 Jan 2019 20:44:24 +0000 (20:44 +0000)
commit659253eef12bb213058a8aed835ba6789aa3d9f0
tree9ed57db254f4d3fa1950eb6b40c6a5ec1de339b3
parent0ce4ccdceea74fa8b26a2142deecaee3794f7228
Bug 22051: Make Koha::Object->store translate incorrect value exceptions

This patch adds a new condition to Koha::Object->store so it catches
incorrect value-related DBIC exceptions.

This DBIC exceptions get now translated into
Koha::Exceptions::Object::BadValue exceptions with relevant parameters
passed.

To test:
- Apply the exception and unit tests patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail because this exception handling code is not
implemented
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/Object.pm