Bug 20145: Do not insert 0000-00-00 in patron tests (and more)
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 14 Feb 2018 18:15:39 +0000 (15:15 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sun, 18 Feb 2018 17:48:05 +0000 (14:48 -0300)
commit744e9a03791f50be98cb5c43cb4223f31fa30ed4
tree82e702a86f51bb8228f3d7dd7eeee830b5f5f2b0
parent69e51d729ff7e5e1a90a0d6ce13e2ca6a0c69308
Bug 20145: Do not insert 0000-00-00 in patron tests (and more)

We should call Koha::Patron->is_expired in CanBookBeIssued instead of
doing the same calculation.

Tests have been adapted to pass with new SQL modes.

We should not need to update the values in DB, we already have
  Bug 14717: Prevent 0000-00-00 dates in patron data (3.21.00.023)

Test plan:
  prove t/db_dependent/Circulation/dateexpiry.t
  prove t/db_dependent/Koha/Patrons.t
must return green

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Circulation.pm
C4/Utils/DataTables/Members.pm
Koha/Patron.pm
t/db_dependent/Circulation/dateexpiry.t
t/db_dependent/Koha/Patrons.t