Bug 13254 - Delete record don't wait for confirmation
authorRafal Kopaczka <rkk0@poczta.onet.pl>
Fri, 14 Nov 2014 13:06:22 +0000 (14:06 +0100)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 17 Nov 2014 00:21:43 +0000 (21:21 -0300)
commit866017e1523ec430d4ec37fc92a02edb86c106e5
tree4a919215312b10c87016d1ee2edb9d4a9dea8d14
parent474735017379277b5f613b43686049ff955e152f
Bug 13254 - Delete record don't wait for confirmation

In some cases (eg. when Staf Client Search is active), when user choose
Edit->Delete record on record tool bar, browser don't wait for
confirmation and goes immediately to delete record.

To reproduce:
1. Search for some biblio records and choose one without items attached.
2. Note that there, must be "Return to search results" box on left side,
bug works in that case, when in normal view everything work fine.
3. Click Edit->Delete record, watch that confirmation box shows, but
don't wait for OK and runs immediately. If you are fast enough to
click OK, then you get error as below, because record was deleted
earlier.

To test:
1. Apply patch.
2. Follow reproduce steps.
3. Check if waits for confirmation in all cases.
4. Check if deletes record after confirm.

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Confirmed the problem and that the patch fixes it.
Good catch!

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc