[PATCH] ahci: simplify ahci_start_engine()
authorTejun Heo <htejun@gmail.com>
Wed, 26 Jul 2006 06:59:26 +0000 (15:59 +0900)
committerJeff Garzik <jeff@garzik.org>
Sat, 29 Jul 2006 08:01:31 +0000 (04:01 -0400)
commit9f5920567bfabbd1be26112a31c44652b6587394
tree27e06539d48f05b85693ba2e9854ebf9a5a4abd7
parentd8fcd116d203dfe2f6c272d0cd67724b172f1bc2
[PATCH] ahci: simplify ahci_start_engine()

Simplify ahci_start_engine() by killing prerequisite condition checks.
Rationales are..

* No user checks error return from ahci_start_engine()

* Code flow guarantees the prerequisite conditions unless the
  controller is malfunctioning.  In such cases, the driver had chances
  to learn about the problem _before_ calling this function.

* Closely related to the above two, driver calls into this function
  even when prerequisites fail hoping for the best.

Basically, ahci_start_engine() should only do the operation itself.
It isn't the right place to check for prerequisites.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Zhao, Forrest <forrest.zhao@intel.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/scsi/ahci.c