Bug 10685: remove inappropriate uses of finish in C4::Accounts.pm
authorKenza Zaki <kenza.zaki@biblibre.com>
Mon, 5 Aug 2013 13:55:40 +0000 (15:55 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 9 Oct 2013 03:35:37 +0000 (03:35 +0000)
commitb6577d13af2319f03b98ff19ac1d17773f55bff8
tree9778d6d5f8447700fdd354f6916393b8533493ad
parent547c6d29499a3e1306a27050b407560a1c4f8fb6
Bug 10685: remove inappropriate uses of finish in C4::Accounts.pm

This patch gets rid of finish.

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Similar to other patches from the same author.
Run prove t/db_dependent/Accounts.t without errors
No koha-qa errors

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Accounts.pm