Bug 9183: Refactor ZOOM event loop
authorJared Camins-Esakov <jcamins@cpbibliography.com>
Sat, 1 Dec 2012 03:45:48 +0000 (22:45 -0500)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Thu, 27 Dec 2012 15:09:07 +0000 (10:09 -0500)
commitc8e8328cb1de72e822028b23d96dd10b56b601aa
treeb127be050ce83bb0ecc959143896d84742b8a308
parent6de8f9533c1a0a23fa10eadfa366253b6c4b6960
Bug 9183: Refactor ZOOM event loop

Prior to this patch, there were three identical ZOOM event loops in
C4::Search. This is wasteful, and goes against all good programming
practice. This patch refactors the ZOOM event loops into a separate
subroutine which is called by SimpleSearch, searchResults, and
GetDistinctValues call.

The new routine, _ZOOM_event_loop process the ZOOM event loop and,
once it has been fully processed, passes control to a closure provided
by the calling routine for processing the results, and destroys the
result sets.

To test (after applying patch):
1) Do a regular bibliographic search that should return results.
2) Do a search in the Cataloging module that should return results.
3) If you get results from both searches, the patch works.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
C4/Search.pm