Bug 6273: add support for recording type of payment made via SIP2
authorIan Walls <ian.walls@bywatersolutions.com>
Fri, 2 Dec 2011 15:49:07 +0000 (10:49 -0500)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 30 Apr 2014 16:38:09 +0000 (16:38 +0000)
commitc8e99f313fe19dea6b11ed5fc05231e86283edf7
tree9af68869a7af0dfd0aedceb9f1afa41463f05d5b
parent7b295e9dd7a1f2a9b1d1cf1882edbc2a0e70fe3a
Bug 6273: add support for recording type of payment made via SIP2

Adds support for recording in Koha accountlines a different accounttype
depending on how the fee was paid at the SIP2 station (cash, credit,
etc.)

Adds a new param to recordpayment(), $sip_paytype, which is appended to
the 'Pay' type if present.  The payment description is also appended
with " (via SIP2)" if this is present.

In order for other scripts to keep working as expected, "eq 'Pay'"
needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay'
and 'Pay-##' would continue to group together.

To test:
1.  Make a payment over a SIP2 connection
2.  Check the patron record in the staff client; you should see the
    modified description
3.  Attempt to print a invoice or a reciept for the borrower; the
    payment should show up where expected

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Accounts.pm
C4/SIP/ILS.pm
C4/SIP/ILS/Transaction/FeePayment.pm
members/boraccount.pl
members/printfeercpt.pl
members/printinvoice.pl