Bug 16129: Remove URL::Encode dependency
authorTomas Cohen Arazi <tomascohen@theke.io>
Tue, 22 Mar 2016 20:17:59 +0000 (17:17 -0300)
committerBrendan A Gallagher <brendan@bywatersolutions.com>
Fri, 1 Apr 2016 18:48:18 +0000 (18:48 +0000)
commitda052b3d10d71cb1256693fbd3166caaa4b53f41
treeeecca6e5abf0532ef1e932b031ed392b6c6d2a40
parent93efeab13e25aea7e467b112983536833c69ceea
 Bug 16129: Remove URL::Encode dependency

This patch makes the PayPal integration feature independent from the
URL::Encode library, which is absent in some supported distributions.

It uses the URI package which is already a Koha dependency.

To test:
- Apply the patch
- Notice there are no deps for URL::Encode
- Follow the steps from the original patch
=> SUCCESS: It works as expected
- Sign-off :-D

Note: I deleted the line in which $amount_to_pay was url-encoded, because that's
one of the things query_form does (and the variable is only used as a parameter to it).

Sponsored-by: ByWater Solutions
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
C4/Installer/PerlDependencies.pm
opac/opac-account-pay-paypal-return.pl
opac/opac-account-pay.pl