dccp: don't restart ccid2_hc_tx_rto_expire() if sk in closed state
authorAlexey Kodanev <alexey.kodanev@oracle.com>
Fri, 26 Jan 2018 12:14:16 +0000 (15:14 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Jan 2018 16:15:00 +0000 (11:15 -0500)
commitdd5684ecae3bd8e44b644f50e2c12c7e57fdfef5
tree6f04791133e716d485656413cef7d9f47b421279
parent1e19c4d689dc1e95bafd23ef68fbc0c6b9e05180
dccp: don't restart ccid2_hc_tx_rto_expire() if sk in closed state

ccid2_hc_tx_rto_expire() timer callback always restarts the timer
again and can run indefinitely (unless it is stopped outside), and after
commit 120e9dabaf55 ("dccp: defer ccid_hc_tx_delete() at dismantle time"),
which moved ccid_hc_tx_delete() (also includes sk_stop_timer()) from
dccp_destroy_sock() to sk_destruct(), this started to happen quite often.
The timer prevents releasing the socket, as a result, sk_destruct() won't
be called.

Found with LTP/dccp_ipsec tests running on the bonding device,
which later couldn't be unloaded after the tests were completed:

  unregister_netdevice: waiting for bond0 to become free. Usage count = 148

Fixes: 2a91aa396739 ("[DCCP] CCID2: Initial CCID2 (TCP-Like) implementation")
Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dccp/ccids/ccid2.c