Bug 11393: fix display of Thai in language menu when Thai translation is installed
authorBernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Thu, 27 Mar 2014 13:26:41 +0000 (10:26 -0300)
committerGalen Charlton <gmc@esilibrary.com>
Thu, 3 Apr 2014 15:38:10 +0000 (15:38 +0000)
commitfe205c907a6ec1959add1b24a5bf3ff09ee5149c
treecbd98adde411226c66f20e51532288825cedbd0a
parent5da480b61b689c7497d386fdd0b9bd30f260d2db
Bug 11393: fix display of Thai in language menu when Thai translation is installed

The problem is with the name of PO files

Currently Koha expect, among other variants, that PO filenames
began with (using as example *-pref.po):
{lang}-pref.po
{lang}-{region}-pref.po
{lang}-{script}-pref.po
{lang}-{script}-{region}-pref.po
and expect 2 chars for lang and region, and 4 for script

So the problem with Thai translation files are that it's names
do not match that convention.

This patch only rename Thai files as th-THA-* to th-TH-*.
In that way language description is right.
translate script use that chars to make dirs, and use dirs to find
description.

To test:
1) Go to I18N/L10N sysprefs
2) Install th-THA language (or simply mkdir koha-tmpl/intranet-tmpl/prog/th-THA)
3) Reload page, wrong description
4) Apply patch
5) Install th-TH language (or simply mkdir koha-tmpl/intranet-tmpl/prog/th-TH)
6) Reload page, right description
7) If you want do "mkdir koha-tmpl/intranet-tmpl/prog/th-Thai", reload,
   also right description

To the reporter of this Bug: the rename of the folder is a good
workaround, when this patch is pushed to stable I'll rename Thai
files

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
This does not correct existing problems which need human
intervention. It does, however, allow for a correct installation
of Thai after the patch is made.

If we really want a patch for fixing an existing install. I
wrote it, but have not tested it.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
As pointed out by Mark, this does not fix existing installations.
Putting a note in the release notes might be something we can do here.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 files changed:
misc/translator/po/th-TH-i-opac-t-prog-v-3006000.po [new file with mode: 0644]
misc/translator/po/th-TH-i-staff-t-prog-v-3006000.po [new file with mode: 0644]
misc/translator/po/th-TH-opac-bootstrap.po [new file with mode: 0644]
misc/translator/po/th-TH-opac-ccsr.po [new file with mode: 0644]
misc/translator/po/th-TH-pref.po [new file with mode: 0644]
misc/translator/po/th-TH-staff-help.po [new file with mode: 0644]
misc/translator/po/th-THA-i-opac-t-prog-v-3006000.po [deleted file]
misc/translator/po/th-THA-i-staff-t-prog-v-3006000.po [deleted file]
misc/translator/po/th-THA-opac-bootstrap.po [deleted file]
misc/translator/po/th-THA-opac-ccsr.po [deleted file]
misc/translator/po/th-THA-pref.po [deleted file]
misc/translator/po/th-THA-staff-help.po [deleted file]