summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
c462238)
Spring cleaning time...
There seems to be a lot of places in the network code that have
extra bogus semicolons after conditionals. Most commonly is a
bogus semicolon after: switch() { }
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
47 files changed:
if(j==1) {
segment=ntohs(entry->rseg[j-1])>>4;
seq_printf(seq," %03X",segment);
if(j==1) {
segment=ntohs(entry->rseg[j-1])>>4;
seq_printf(seq," %03X",segment);
segment=ntohs(entry->rseg[j])>>4;
brdgnmb=ntohs(entry->rseg[j-1])&0x00f;
seq_printf(seq,"-%01X-%03X",brdgnmb,segment);
segment=ntohs(entry->rseg[j])>>4;
brdgnmb=ntohs(entry->rseg[j-1])&0x00f;
seq_printf(seq,"-%01X-%03X",brdgnmb,segment);
*/
default:
snprintf(name, IFNAMSIZ, "vlan%.4i", VLAN_ID);
*/
default:
snprintf(name, IFNAMSIZ, "vlan%.4i", VLAN_ID);
new_dev = alloc_netdev(sizeof(struct vlan_dev_info), name,
vlan_setup);
new_dev = alloc_netdev(sizeof(struct vlan_dev_info), name,
vlan_setup);
printk(VLAN_DBG "%s: Unknown VLAN CMD: %x \n",
__FUNCTION__, args.cmd);
return -EINVAL;
printk(VLAN_DBG "%s: Unknown VLAN CMD: %x \n",
__FUNCTION__, args.cmd);
return -EINVAL;
memcpy(veth->h_source, dev->dev_addr, ETH_ALEN);
break;
memcpy(veth->h_source, dev->dev_addr, ETH_ALEN);
break;
/* Was a VLAN packet, grab the encapsulated protocol, which the layer
* three protocols care about.
/* Was a VLAN packet, grab the encapsulated protocol, which the layer
* three protocols care about.
digipeat = route->digipeat;
dev = route->dev;
ip_mode = route->ip_mode;
digipeat = route->digipeat;
dev = route->dev;
ip_mode = route->ip_mode;
if (dev == NULL)
dev = skb->dev;
if (dev == NULL)
dev = skb->dev;
default:
err = -ETIMEDOUT;
break;
default:
err = -ETIMEDOUT;
break;
hdev->req_status = hdev->req_result = 0;
hdev->req_status = hdev->req_result = 0;
case HCI_SCODATA_PKT:
kfree_skb(skb);
continue;
case HCI_SCODATA_PKT:
kfree_skb(skb);
continue;
default:
sock_set_flag(sk, SOCK_ZAPPED);
break;
default:
sock_set_flag(sk, SOCK_ZAPPED);
break;
case IF_LINK_MODE_DEFAULT:
default:
break;
case IF_LINK_MODE_DEFAULT:
default:
break;
dev->operstate = operstate;
dev->operstate = operstate;
break;
default:
goto done;
break;
default:
goto done;
case NETDEV_UNREGISTER:
pktgen_mark_device(dev->name);
break;
case NETDEV_UNREGISTER:
pktgen_mark_device(dev->name);
break;
operstate == IF_OPER_UNKNOWN)
operstate = IF_OPER_DORMANT;
break;
operstate == IF_OPER_UNKNOWN)
operstate = IF_OPER_DORMANT;
break;
if (dev->operstate != operstate) {
write_lock_bh(&dev_base_lock);
if (dev->operstate != operstate) {
write_lock_bh(&dev_base_lock);
if (atomic_dec_and_test(fclone_ref))
kmem_cache_free(skbuff_fclone_cache, other);
break;
if (atomic_dec_and_test(fclone_ref))
kmem_cache_free(skbuff_fclone_cache, other);
break;
default:
printk(KERN_DEBUG "impossible 102\n");
return -EINVAL;
default:
printk(KERN_DEBUG "impossible 102\n");
return -EINVAL;
if (opt[1] >= 4)
memcpy(&server_id, opt + 2, 4);
break;
if (opt[1] >= 4)
memcpy(&server_id, opt + 2, 4);
break;
ic_myaddr = NONE;
ic_servaddr = NONE;
goto drop_unlock;
ic_myaddr = NONE;
ic_servaddr = NONE;
goto drop_unlock;
spin_unlock_bh(&state_lock);
break;
spin_unlock_bh(&state_lock);
break;
break;
default:
return -ENOIOCTLCMD;
break;
default:
return -ENOIOCTLCMD;
return put_user(answ, (int __user *)arg);
}
return put_user(answ, (int __user *)arg);
}
default:
err = -ENOPROTOOPT;
break;
default:
err = -ENOPROTOOPT;
break;
release_sock(sk);
return err;
}
release_sock(sk);
return err;
}
return 0;
default:
return -ENOPROTOOPT;
return 0;
default:
return -ENOPROTOOPT;
if (put_user(len, optlen))
return -EFAULT;
if (put_user(len, optlen))
return -EFAULT;
default:
tcp_ratehalving_spur_to_response(sk);
break;
default:
tcp_ratehalving_spur_to_response(sk);
break;
tp->frto_counter = 0;
}
return 0;
tp->frto_counter = 0;
}
return 0;
ptr+=opsize-2;
length-=opsize;
ptr+=opsize-2;
length-=opsize;
printk(KERN_ERR "%s: Impossible, sk->sk_state=%d\n",
__FUNCTION__, sk->sk_state);
break;
printk(KERN_ERR "%s: Impossible, sk->sk_state=%d\n",
__FUNCTION__, sk->sk_state);
break;
/* It _is_ possible, that we have something out-of-order _after_ FIN.
* Probably, we should reset in this case. For now drop them.
/* It _is_ possible, that we have something out-of-order _after_ FIN.
* Probably, we should reset in this case. For now drop them.
default:
fl->fl_ipsec_spi = 0;
break;
default:
fl->fl_ipsec_spi = 0;
break;
}
fl->proto = iph->protocol;
fl->fl4_dst = iph->daddr;
}
fl->proto = iph->protocol;
fl->fl4_dst = iph->daddr;
default:
addrconf_dev_config(dev);
break;
default:
addrconf_dev_config(dev);
break;
if (idev) {
if (run_pending)
addrconf_dad_run(idev);
if (idev) {
if (run_pending)
addrconf_dad_run(idev);
cmsg->cmsg_type);
err = -EINVAL;
break;
cmsg->cmsg_type);
err = -EINVAL;
break;
case 2: /* send ICMP PARM PROB regardless and drop packet */
icmpv6_param_prob(skb, ICMPV6_UNK_OPTION, optoff);
return 0;
case 2: /* send ICMP PARM PROB regardless and drop packet */
icmpv6_param_prob(skb, ICMPV6_UNK_OPTION, optoff);
return 0;
kfree_skb(skb);
return 0;
kfree_skb(skb);
return 0;
*/
icmpv6_notify(skb, type, hdr->icmp6_code, hdr->icmp6_mtu);
*/
icmpv6_notify(skb, type, hdr->icmp6_code, hdr->icmp6_mtu);
kfree_skb(skb);
return 0;
kfree_skb(skb);
return 0;
case ICMPV6_TIME_EXCEED:
*err = EHOSTUNREACH;
break;
case ICMPV6_TIME_EXCEED:
*err = EHOSTUNREACH;
break;
case NDISC_REDIRECT:
ndisc_redirect_rcv(skb);
break;
case NDISC_REDIRECT:
ndisc_redirect_rcv(skb);
break;
return 0;
default:
return -ENOPROTOOPT;
return 0;
default:
return -ENOPROTOOPT;
return 0;
default:
return -ENOPROTOOPT;
return 0;
default:
return -ENOPROTOOPT;
default:
return ipv6_setsockopt(sk, level, optname, optval,
optlen);
default:
return ipv6_setsockopt(sk, level, optname, optval,
optlen);
return do_rawv6_setsockopt(sk, level, optname, optval, optlen);
}
return do_rawv6_setsockopt(sk, level, optname, optval, optlen);
}
default:
return compat_ipv6_setsockopt(sk, level, optname,
optval, optlen);
default:
return compat_ipv6_setsockopt(sk, level, optname,
optval, optlen);
return do_rawv6_setsockopt(sk, level, optname, optval, optlen);
}
#endif
return do_rawv6_setsockopt(sk, level, optname, optval, optlen);
}
#endif
default:
return ipv6_getsockopt(sk, level, optname, optval,
optlen);
default:
return ipv6_getsockopt(sk, level, optname, optval,
optlen);
return do_rawv6_getsockopt(sk, level, optname, optval, optlen);
}
return do_rawv6_getsockopt(sk, level, optname, optval, optlen);
}
default:
return compat_ipv6_getsockopt(sk, level, optname,
optval, optlen);
default:
return compat_ipv6_getsockopt(sk, level, optname,
optval, optlen);
return do_rawv6_getsockopt(sk, level, optname, optval, optlen);
}
#endif
return do_rawv6_getsockopt(sk, level, optname, optval, optlen);
}
#endif
rtnl_unlock();
return err;
rtnl_unlock();
return err;
if (!afinfo) {
dst = *dst_p;
goto error;
if (!afinfo) {
dst = *dst_p;
goto error;
dst_prev->output = afinfo->output;
xfrm_state_put_afinfo(afinfo);
/* Sheit... I remember I did this right. Apparently,
dst_prev->output = afinfo->output;
xfrm_state_put_afinfo(afinfo);
/* Sheit... I remember I did this right. Apparently,
fl->fl_ipsec_spi = 0;
fl->proto = nexthdr;
return;
fl->fl_ipsec_spi = 0;
fl->proto = nexthdr;
return;
break;
default:
self->max_data_size = irttp_get_max_seg_size(self->tsap);
break;
default:
self->max_data_size = irttp_get_max_seg_size(self->tsap);
IRDA_DEBUG(2, "%s(), max_data_size=%d\n", __FUNCTION__,
self->max_data_size);
IRDA_DEBUG(2, "%s(), max_data_size=%d\n", __FUNCTION__,
self->max_data_size);
break;
default:
self->max_data_size = irttp_get_max_seg_size(self->tsap);
break;
default:
self->max_data_size = irttp_get_max_seg_size(self->tsap);
IRDA_DEBUG(2, "%s(), max_data_size=%d\n", __FUNCTION__,
self->max_data_size);
IRDA_DEBUG(2, "%s(), max_data_size=%d\n", __FUNCTION__,
self->max_data_size);
default:
sock_set_flag(sk, SOCK_ZAPPED);
break;
default:
sock_set_flag(sk, SOCK_ZAPPED);
break;
release_sock(sk);
iucv_sock_kill(sk);
release_sock(sk);
iucv_sock_kill(sk);
*/
return -EINVAL;
break;
*/
return -EINVAL;
break;
BUG_TRAP(ht->refcnt == 0);
kfree(ht);
BUG_TRAP(ht->refcnt == 0);
kfree(ht);
default:
skb->tc_index = 0;
break;
default:
skb->tc_index = 0;
break;
}
if (TC_H_MAJ(skb->priority) == sch->handle)
}
if (TC_H_MAJ(skb->priority) == sch->handle)
if (p->default_index != NO_DEFAULT_INDEX)
skb->tc_index = p->default_index;
break;
if (p->default_index != NO_DEFAULT_INDEX)
skb->tc_index = p->default_index;
break;
}
err = p->q->enqueue(skb,p->q);
}
err = p->q->enqueue(skb,p->q);
"unsupported protocol %d\n",
ntohs(skb->protocol));
break;
"unsupported protocol %d\n",
ntohs(skb->protocol));
break;
skb->tc_index = TC_H_MIN(res.classid);
result = TC_ACT_OK;
break;
skb->tc_index = TC_H_MIN(res.classid);
result = TC_ACT_OK;
break;
/* backward compat */
#else
#ifdef CONFIG_NET_CLS_POLICE
/* backward compat */
#else
#ifdef CONFIG_NET_CLS_POLICE
sch->bstats.bytes += skb->len;
result = NF_ACCEPT;
break;
sch->bstats.bytes += skb->len;
result = NF_ACCEPT;
break;
#else
D2PRINTK("Overriding result to ACCEPT\n");
#else
D2PRINTK("Overriding result to ACCEPT\n");
*qerr = NET_XMIT_SUCCESS;
case TC_ACT_SHOT:
return NULL;
*qerr = NET_XMIT_SUCCESS;
case TC_ACT_SHOT:
return NULL;
if (!q->filter_list ) {
#else
if (!q->filter_list ) {
#else
/* Generate and send a SCTP_PEER_ADDR_CHANGE notification to the
* user.
/* Generate and send a SCTP_PEER_ADDR_CHANGE notification to the
* user.
return "FWD_TSN";
default:
return "FWD_TSN";
default:
- return "unknown chunk";
- };
return "unknown chunk";
}
return "unknown chunk";
}
default:
retval = SCTP_SCOPE_GLOBAL;
break;
default:
retval = SCTP_SCOPE_GLOBAL;
break;
case SCTP_XMIT_OK:
case SCTP_XMIT_NAGLE_DELAY:
break;
case SCTP_XMIT_OK:
case SCTP_XMIT_NAGLE_DELAY:
break;
SCTP_INC_STATS(SCTP_MIB_OUTORDERCHUNKS);
q->empty = 0;
break;
SCTP_INC_STATS(SCTP_MIB_OUTORDERCHUNKS);
q->empty = 0;
break;
} else {
list_add_tail(&chunk->list, &q->control_chunk_list);
SCTP_INC_STATS(SCTP_MIB_OUTCTRLCHUNKS);
} else {
list_add_tail(&chunk->list, &q->control_chunk_list);
SCTP_INC_STATS(SCTP_MIB_OUTCTRLCHUNKS);
/* Retrieve a new chunk to bundle. */
lchunk = sctp_list_dequeue(lqueue);
break;
/* Retrieve a new chunk to bundle. */
lchunk = sctp_list_dequeue(lqueue);
break;
/* If we are here due to a retransmit timeout or a fast
* retransmit and if there are any chunks left in the retransmit
/* If we are here due to a retransmit timeout or a fast
* retransmit and if there are any chunks left in the retransmit
default:
/* We built a chunk with an illegal type! */
BUG();
default:
/* We built a chunk with an illegal type! */
BUG();
}
/* Is it OK to send data chunks? */
}
/* Is it OK to send data chunks? */
SCTP_DEBUG_PRINTK("ACKed: %08x", tsn);
dbg_prt_state = 0;
dbg_ack_tsn = tsn;
SCTP_DEBUG_PRINTK("ACKed: %08x", tsn);
dbg_prt_state = 0;
dbg_ack_tsn = tsn;
dbg_last_ack_tsn = tsn;
#endif /* SCTP_DEBUG */
dbg_last_ack_tsn = tsn;
#endif /* SCTP_DEBUG */
SCTP_DEBUG_PRINTK("KEPT: %08x",tsn);
dbg_prt_state = 1;
dbg_kept_tsn = tsn;
SCTP_DEBUG_PRINTK("KEPT: %08x",tsn);
dbg_prt_state = 1;
dbg_kept_tsn = tsn;
dbg_last_kept_tsn = tsn;
#endif /* SCTP_DEBUG */
dbg_last_kept_tsn = tsn;
#endif /* SCTP_DEBUG */
} else {
SCTP_DEBUG_PRINTK("\n");
}
} else {
SCTP_DEBUG_PRINTK("\n");
}
#endif /* SCTP_DEBUG */
if (transport) {
if (bytes_acked) {
#endif /* SCTP_DEBUG */
if (transport) {
if (bytes_acked) {
default: /* Just ignore anything else. */
break;
default: /* Just ignore anything else. */
break;
SCTP_DEBUG_PRINTK("Ignoring param: %d for association %p.\n",
ntohs(param.p->type), asoc);
break;
SCTP_DEBUG_PRINTK("Ignoring param: %d for association %p.\n",
ntohs(param.p->type), asoc);
break;
status, state, event_type, subtype.chunk);
BUG();
break;
status, state, event_type, subtype.chunk);
BUG();
break;
printk(KERN_WARNING "Impossible command: %u, %p\n",
cmd->verb, cmd->obj.ptr);
break;
printk(KERN_WARNING "Impossible command: %u, %p\n",
cmd->verb, cmd->obj.ptr);
break;
case -SCTP_IERROR_BAD_SIG:
default:
return sctp_sf_pdiscard(ep, asoc, type, arg, commands);
case -SCTP_IERROR_BAD_SIG:
default:
return sctp_sf_pdiscard(ep, asoc, type, arg, commands);
new_asoc->c.my_ttag = asoc->c.my_vtag;
new_asoc->c.peer_ttag = asoc->c.peer_vtag;
break;
new_asoc->c.my_ttag = asoc->c.my_vtag;
new_asoc->c.peer_ttag = asoc->c.peer_vtag;
break;
/* Other parameters for the endpoint SHOULD be copied from the
* existing parameters of the association (e.g. number of
/* Other parameters for the endpoint SHOULD be copied from the
* existing parameters of the association (e.g. number of
case -SCTP_IERROR_BAD_SIG:
default:
return sctp_sf_pdiscard(ep, asoc, type, arg, commands);
case -SCTP_IERROR_BAD_SIG:
default:
return sctp_sf_pdiscard(ep, asoc, type, arg, commands);
}
/* Compare the tie_tag in cookie with the verification tag of
}
/* Compare the tie_tag in cookie with the verification tag of
default: /* Discard packet for all others. */
retval = sctp_sf_pdiscard(ep, asoc, type, arg, commands);
break;
default: /* Discard packet for all others. */
retval = sctp_sf_pdiscard(ep, asoc, type, arg, commands);
break;
/* Delete the tempory new association. */
sctp_add_cmd_sf(commands, SCTP_CMD_NEW_ASOC, SCTP_ASOC(new_asoc));
/* Delete the tempory new association. */
sctp_add_cmd_sf(commands, SCTP_CMD_NEW_ASOC, SCTP_ASOC(new_asoc));
default:
/* Yikes! We got an illegal event type. */
return &bug;
default:
/* Yikes! We got an illegal event type. */
return &bug;
}
#define TYPE_SCTP_FUNC(func) {.fn = func, .name = #func}
}
#define TYPE_SCTP_FUNC(func) {.fn = func, .name = #func}
default:
err = -EINVAL;
break;
default:
err = -EINVAL;
break;
default:
retval = -ENOPROTOOPT;
break;
default:
retval = -ENOPROTOOPT;
break;
default:
retval = -ENOPROTOOPT;
break;
default:
retval = -ENOPROTOOPT;
break;
sctp_release_sock(sk);
return retval;
sctp_release_sock(sk);
return retval;
transport->cwnd = max(transport->cwnd/2,
4*transport->asoc->pathmtu);
break;
transport->cwnd = max(transport->cwnd/2,
4*transport->asoc->pathmtu);
break;
transport->partial_bytes_acked = 0;
SCTP_DEBUG_PRINTK("%s: transport: %p reason: %d cwnd: "
transport->partial_bytes_acked = 0;
SCTP_DEBUG_PRINTK("%s: transport: %p reason: %d cwnd: "
break;
pos->next = pnext;
pos = pnext;
break;
pos->next = pnext;
pos = pnext;
event = sctp_skb2event(f_frag);
SCTP_INC_STATS(SCTP_MIB_REASMUSRMSGS);
event = sctp_skb2event(f_frag);
SCTP_INC_STATS(SCTP_MIB_REASMUSRMSGS);
else
first_frag = NULL;
break;
else
first_frag = NULL;
break;
goto done;
default:
return NULL;
goto done;
default:
return NULL;
}
/* We have the reassembled event. There is no need to look
}
/* We have the reassembled event. There is no need to look
break;
default:
return NULL;
break;
default:
return NULL;
}
/* We have the reassembled event. There is no need to look
}
/* We have the reassembled event. There is no need to look
if (obuf == NULL) {
warn("Link unable to unbundle message(s)\n");
break;
if (obuf == NULL) {
warn("Link unable to unbundle message(s)\n");
break;
pos += align(msg_size(buf_msg(obuf)));
msg_dbg(buf_msg(obuf), " /");
tipc_net_route_msg(obuf);
pos += align(msg_size(buf_msg(obuf)));
msg_dbg(buf_msg(obuf), " /");
tipc_net_route_msg(obuf);
return FLOW_DIR_OUT;
case XFRM_POLICY_FWD:
return FLOW_DIR_FWD;
return FLOW_DIR_OUT;
case XFRM_POLICY_FWD:
return FLOW_DIR_FWD;
}
static struct xfrm_policy *xfrm_sk_policy_lookup(struct sock *sk, int dir, struct flowi *fl)
}
static struct xfrm_policy *xfrm_sk_policy_lookup(struct sock *sk, int dir, struct flowi *fl)
x->id.daddr.a6))
continue;
break;
x->id.daddr.a6))
continue;
break;
xfrm_state_hold(x);
return x;
xfrm_state_hold(x);
return x;
x->props.saddr.a6))
continue;
break;
x->props.saddr.a6))
continue;
break;
xfrm_state_hold(x);
return x;
xfrm_state_hold(x);
return x;
(struct in6_addr *)saddr))
continue;
break;
(struct in6_addr *)saddr))
continue;
break;
xfrm_state_hold(x);
return x;
xfrm_state_hold(x);
return x;
ipv6_addr_copy((struct in6_addr *)x->id.daddr.a6,
(struct in6_addr *)daddr);
break;
ipv6_addr_copy((struct in6_addr *)x->id.daddr.a6,
(struct in6_addr *)daddr);
break;
x->km.state = XFRM_STATE_ACQ;
x->id.proto = proto;
x->km.state = XFRM_STATE_ACQ;
x->id.proto = proto;
algp->alg_name[CRYPTO_MAX_ALG_NAME - 1] = '\0';
return 0;
algp->alg_name[CRYPTO_MAX_ALG_NAME - 1] = '\0';
return 0;
err = -EINVAL;
switch (p->id.proto) {
err = -EINVAL;
switch (p->id.proto) {
if ((err = verify_one_alg(xfrma, XFRMA_ALG_AUTH)))
goto out;
if ((err = verify_one_alg(xfrma, XFRMA_ALG_AUTH)))
goto out;
if (p->min > p->max)
return -EINVAL;
if (p->min > p->max)
return -EINVAL;
switch (p->action) {
case XFRM_POLICY_ALLOW:
switch (p->action) {
case XFRM_POLICY_ALLOW:
switch (p->sel.family) {
case AF_INET:
switch (p->sel.family) {
case AF_INET:
return verify_policy_dir(p->dir);
}
return verify_policy_dir(p->dir);
}
#endif
default:
return -EINVAL;
#endif
default:
return -EINVAL;