[1] Resolve warnings like:
Use of uninitialized value $rounding_pref in string eq at /usr/share/koha/devclone/C4/Acquisition.pm line 2040.
[2] Fixing unusual use of whitespace too.
[3] Remove list operator from get_rounding_sql return. Only used in scalar
context.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
- $rounding_sql = get_rounding_sql("mysql_variable_to_round_string");
+ $rounding_sql = get_rounding_sql($column_name);
returns the correct SQL routine based on OrderPriceRounding system preference.
returns the correct SQL routine based on OrderPriceRounding system preference.
sub get_rounding_sql {
my ( $round_string ) = @_;
sub get_rounding_sql {
my ( $round_string ) = @_;
- my $rounding_pref = C4::Context->preference('OrderPriceRounding');
- if ( $rounding_pref eq "nearest_cent" ) { return ("CAST($round_string*100 AS UNSIGNED)/100"); }
- else { return ("$round_string"); }
+ my $rounding_pref = C4::Context->preference('OrderPriceRounding') // q{};
+ if ( $rounding_pref eq "nearest_cent" ) {
+ return "CAST($round_string*100 AS UNSIGNED)/100";
+ }
+ return $round_string;
}
=head3 get_rounded_price
}
=head3 get_rounded_price
sub get_rounded_price {
my ( $price ) = @_;
sub get_rounded_price {
my ( $price ) = @_;
- my $rounding_pref = C4::Context->preference('OrderPriceRounding');
- if( $rounding_pref eq 'nearest_cent' ) { return Koha::Number::Price->new( $price )->round(); }
- else { return $price; }
+ my $rounding_pref = C4::Context->preference('OrderPriceRounding') // q{};
+ if( $rounding_pref eq 'nearest_cent' ) {
+ return Koha::Number::Price->new( $price )->round();
+ }
+ return $price;