The t/Barcodes_ValueBuilder.t test had the wrong number of tests
declared, and rather than checking that a variable was undefined I was
checking that it had a length of zero. Fixed both issues.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
use strict;
use warnings;
use DBI;
use strict;
use warnings;
use DBI;
-use Test::More tests => 15;
+use Test::More tests => 10;
use Test::MockModule;
BEGIN {
use Test::MockModule;
BEGIN {
($nextnum, $scr) = C4::Barcodes::ValueBuilder::incremental::get_barcode(\%args);
is($nextnum, 33333074344564, 'incremental barcode');
($nextnum, $scr) = C4::Barcodes::ValueBuilder::incremental::get_barcode(\%args);
is($nextnum, 33333074344564, 'incremental barcode');
-ok(length($scr) == 0, 'incremental javascript');
+is($scr, undef, 'incremental javascript');
# This should run exactly one query so we can test
$history = $dbh->{mock_all_history};
# This should run exactly one query so we can test
$history = $dbh->{mock_all_history};
$dbh->{mock_clear_history} = 1;
($nextnum, $scr) = C4::Barcodes::ValueBuilder::annual::get_barcode(\%args);
is($nextnum, '2012-0035', 'annual barcode');
$dbh->{mock_clear_history} = 1;
($nextnum, $scr) = C4::Barcodes::ValueBuilder::annual::get_barcode(\%args);
is($nextnum, '2012-0035', 'annual barcode');
-ok(length($scr) == 0, 'annual javascript');
+is($scr, undef, 'annual javascript');
# This should run exactly one query so we can test
$history = $dbh->{mock_all_history};
# This should run exactly one query so we can test
$history = $dbh->{mock_all_history};