perf thread-stack: Simplify some code in thread_stack__process()
authorAdrian Hunter <adrian.hunter@intel.com>
Fri, 21 Dec 2018 12:06:13 +0000 (14:06 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 2 Jan 2019 13:42:45 +0000 (10:42 -0300)
In preparation for fixing thread stack processing for the idle task,
simplify some code in thread_stack__process().

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20181221120620.9659-2-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/thread-stack.c

index 61a4286..115dc4b 100644 (file)
@@ -593,17 +593,13 @@ int thread_stack__process(struct thread *thread, struct comm *comm,
        struct thread_stack *ts = thread->ts;
        int err = 0;
 
-       if (ts) {
-               if (!ts->crp) {
-                       /* Supersede thread_stack__event() */
-                       thread_stack__free(thread);
-                       thread->ts = thread_stack__new(thread, crp);
-                       if (!thread->ts)
-                               return -ENOMEM;
-                       ts = thread->ts;
-                       ts->comm = comm;
-               }
-       } else {
+       if (ts && !ts->crp) {
+               /* Supersede thread_stack__event() */
+               thread_stack__free(thread);
+               ts = NULL;
+       }
+
+       if (!ts) {
                thread->ts = thread_stack__new(thread, crp);
                if (!thread->ts)
                        return -ENOMEM;