Bug 21826: Move Heading tests to db_dependent since they require database connection
authorEre Maijala <ere.maijala@helsinki.fi>
Thu, 22 Nov 2018 09:23:57 +0000 (11:23 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 25 Jan 2019 20:13:39 +0000 (20:13 +0000)
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
t/Heading.t [deleted file]
t/db_dependent/Heading.t [new file with mode: 0755]

diff --git a/t/Heading.t b/t/Heading.t
deleted file mode 100755 (executable)
index bcbbe51..0000000
+++ /dev/null
@@ -1,61 +0,0 @@
-#!/usr/bin/perl
-#
-# This file is part of Koha.
-#
-# Koha is free software; you can redistribute it and/or modify it
-# under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3 of the License, or
-# (at your option) any later version.
-#
-# Koha is distributed in the hope that it will be useful, but
-# WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with Koha; if not, see <http://www.gnu.org/licenses>.
-
-use strict;
-use warnings;
-
-use Test::More tests => 3;
-
-use t::lib::Mocks;
-
-BEGIN {
-    use_ok('C4::Heading');
-}
-
-subtest "MARC21 tests" => sub {
-    plan tests => 7;
-
-    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
-
-    ok(C4::Heading::valid_bib_heading_subfield('100', 'a'), '100a valid');
-    ok(!C4::Heading::valid_bib_heading_subfield('100', 'e'), '100e not valid');
-
-    ok(C4::Heading::valid_bib_heading_subfield('110', 'a'), '110a valid');
-    ok(!C4::Heading::valid_bib_heading_subfield('110', 'e'), '110e not valid');
-
-    ok(C4::Heading::valid_bib_heading_subfield('600', 'a'), '600a valid');
-    ok(!C4::Heading::valid_bib_heading_subfield('600', 'e'), '600e not valid');
-
-    ok(!C4::Heading::valid_bib_heading_subfield('012', 'a'), '012a invalid field');
-};
-
-subtest "UNIMARC tests" => sub {
-    plan tests => 7;
-
-    t::lib::Mocks::mock_preference('marcflavour', 'UNIMARC');
-
-    ok(C4::Heading::valid_bib_heading_subfield('100', 'a'), '100a valid');
-    ok(!C4::Heading::valid_bib_heading_subfield('100', 'i'), '100i not valid');
-
-    ok(C4::Heading::valid_bib_heading_subfield('110', 'a'), '110a valid');
-    ok(!C4::Heading::valid_bib_heading_subfield('110', 'i'), '110i not valid');
-
-    ok(C4::Heading::valid_bib_heading_subfield('600', 'a'), '600a valid');
-    ok(!C4::Heading::valid_bib_heading_subfield('600', 'i'), '600i not valid');
-
-    ok(!C4::Heading::valid_bib_heading_subfield('012', 'a'), '012a invalid field');
-}
diff --git a/t/db_dependent/Heading.t b/t/db_dependent/Heading.t
new file mode 100755 (executable)
index 0000000..bcbbe51
--- /dev/null
@@ -0,0 +1,61 @@
+#!/usr/bin/perl
+#
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
+
+use strict;
+use warnings;
+
+use Test::More tests => 3;
+
+use t::lib::Mocks;
+
+BEGIN {
+    use_ok('C4::Heading');
+}
+
+subtest "MARC21 tests" => sub {
+    plan tests => 7;
+
+    t::lib::Mocks::mock_preference('marcflavour', 'MARC21');
+
+    ok(C4::Heading::valid_bib_heading_subfield('100', 'a'), '100a valid');
+    ok(!C4::Heading::valid_bib_heading_subfield('100', 'e'), '100e not valid');
+
+    ok(C4::Heading::valid_bib_heading_subfield('110', 'a'), '110a valid');
+    ok(!C4::Heading::valid_bib_heading_subfield('110', 'e'), '110e not valid');
+
+    ok(C4::Heading::valid_bib_heading_subfield('600', 'a'), '600a valid');
+    ok(!C4::Heading::valid_bib_heading_subfield('600', 'e'), '600e not valid');
+
+    ok(!C4::Heading::valid_bib_heading_subfield('012', 'a'), '012a invalid field');
+};
+
+subtest "UNIMARC tests" => sub {
+    plan tests => 7;
+
+    t::lib::Mocks::mock_preference('marcflavour', 'UNIMARC');
+
+    ok(C4::Heading::valid_bib_heading_subfield('100', 'a'), '100a valid');
+    ok(!C4::Heading::valid_bib_heading_subfield('100', 'i'), '100i not valid');
+
+    ok(C4::Heading::valid_bib_heading_subfield('110', 'a'), '110a valid');
+    ok(!C4::Heading::valid_bib_heading_subfield('110', 'i'), '110i not valid');
+
+    ok(C4::Heading::valid_bib_heading_subfield('600', 'a'), '600a valid');
+    ok(!C4::Heading::valid_bib_heading_subfield('600', 'i'), '600i not valid');
+
+    ok(!C4::Heading::valid_bib_heading_subfield('012', 'a'), '012a invalid field');
+}